search for: nbd_connect_systemd_socket_activ

On Sat, Mar 25, 2023 at 12:39:28PM +0100, Laszlo Ersek wrote: > From: "Richard W.M. Jones" <rjones at redhat.com> > > To allow us to name the socket passed down to the NBD server when > calling nbd_connect_systemd_socket_activation(3), we need to add the > field to the handle and add access functions. > > [Laszlo's notes: > > - Originally posted by Rich at > <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html> > (Message-Id: <20230130225521.1771496-4-rjones at...

On 3/28/23 04:06, Eric Blake wrote: > On Sat, Mar 25, 2023 at 12:39:28PM +0100, Laszlo Ersek wrote: >> From: "Richard W.M. Jones" <rjones at redhat.com> >> >> To allow us to name the socket passed down to the NBD server when >> calling nbd_connect_systemd_socket_activation(3), we need to add the >> field to the handle and add access functions. >> >> [Laszlo's notes: >> >> - Originally posted by Rich at >> <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html> >> (Message-Id: <202301302...

From: "Richard W.M. Jones" <rjones at redhat.com> To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. [Laszlo's notes: - Originally posted by Rich at <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html> (Message-Id: <20230130225521.1771496-4-rjones at redhat.com>). - I've rename...

To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. --- generator/API.ml | 49 ++++++++++++++++++++++++++++++++++++++++++ lib/handle.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ lib/internal.h | 1 + 3 files changed, 106 insertions(+) diff --git a/generato...

From: "Richard W.M. Jones" <rjones at redhat.com> To allow us to name the socket passed down to the NBD server when calling nbd_connect_systemd_socket_activation(3), we need to add the field to the handle and add access functions. [Laszlo's note: originally posted by Rich at <https://listman.redhat.com/archives/libguestfs/2023-January/030557.html>. I've renamed "sa_name" to "sact_name", due to <signal.h> reservi...

On Mon, Jan 30, 2023 at 10:55:20PM +0000, Richard W.M. Jones wrote: > To allow us to name the socket passed down to the NBD server when > calling nbd_connect_systemd_socket_activation(3), we need to add the > field to the handle and add access functions. > --- > generator/API.ml | 49 ++++++++++++++++++++++++++++++++++++++++++ > lib/handle.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ > lib/internal.h | 1 + > 3 files changed, 106 insert...

For commands with long names and/or short descriptors, you can end up going over 72 characters in the first line of the man page (causing podwrapper to complain). Wrap these lines. --- generator/generator | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generator/generator b/generator/generator index 7d3f656..ad1cb6b 100755 --- a/generator/generator +++ b/generator/generator

...receiving this email because of your account on gitlab.com > <https://gitlab.com>. Manage all notifications > <https://gitlab.com/-/profile/notifications> ? Help > <https://gitlab.com/help> The "copy-file-to-qcow2-compressed.sh" test case failed with: nbdkit: nbd_connect_systemd_socket_activation: recv: Connection reset by peer I started downloading a ci-almalinux-8:latest container for local repro, but meanwhile, I kicked the failed job on gitlab too, and the latter succeeded. So <https://gitlab.com/nbdkit/libnbd/-/pipelines/819889104> is green now. Laszlo

On Tue, Jan 31, 2023 at 10:29:00AM -0600, Eric Blake wrote: > On Mon, Jan 30, 2023 at 10:55:20PM +0000, Richard W.M. Jones wrote: > > To allow us to name the socket passed down to the NBD server when > > calling nbd_connect_systemd_socket_activation(3), we need to add the > > field to the handle and add access functions. > > --- > > generator/API.ml | 49 ++++++++++++++++++++++++++++++++++++++++++ > > lib/handle.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ > > lib/internal.h | 1 + > &gt...

This is an alternative approach to https://listman.redhat.com/archives/libguestfs/2023-January/030535.html After discussing this with Dan Berrange we came to the conclusion that you really might want to set LISTEN_FDNAMES to arbitrary short strings (or not set it). Especially when talking to qemu-storage-daemon which would allow you to use these names on the command line. Rich.

V4 was here (incorrectly versioned on the mailing list as v3): <http://mid.mail-archive.com/20230323121016.1442655-1-lersek at redhat.com>. See the Notes section on each patch for the v5 updates. Laszlo Ersek (2): socket activation: generalize environment construction socket activation: set LISTEN_FDNAMES Richard W.M. Jones (2): common/include: Copy ascii-ctype functions from nbdkit

...int readonly) r = nbd_connect_unix (h->nbd, sockname); else if (hostname) r = nbd_connect_tcp (h->nbd, hostname, port); + else if (raw_cid) +#if !USE_VSOCK + abort (); +#else + r = nbd_connect_vsock (h->nbd, cid, vport); +#endif else if (command.size > 0) r = nbd_connect_systemd_socket_activation (h->nbd, (char **) command.ptr); else if (socket_fd >= 0) -- 2.27.0

Pipeline #819889104 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 2db30279 ( https://gitlab.com/nbdkit/libnbd/-/commit/2db30279bad4f9923baa541008f5da11624d2d1f ) Commit Message: socket activation: set LISTEN_FDNAMES Add LIST... Commit Author: Laszlo Ersek ( https://gitlab.com/lersek ) Pipeline

...if you want to proxy through to qemu-nbd (eg. for handling qcow2 files) it's rather complicated and you end up having to manage the sockets and clean up yourself. However the library we use for the proxying supports a perfectly good way to run qemu-nbd as a subprocess: http://libguestfs.org/nbd_connect_systemd_socket_activation.3.html#EXAMPLE Why not use that instead? Then you'd be able to write: nbdkit nbd command=' qemu-nbd -f qcow2 disk.qcow2 ' and place filters in front. nbdkit would deal with clean up of the qemu-nbd process. However I've been staring at this most of the day and for reaso...

[attempting to loop in systemd folks; this started in libnbd at https://listman.redhat.com/archives/libguestfs/2023-March/031178.html - although I may have to retry since I'm not a usual subscriber of systemd-devel] On Fri, Mar 24, 2023 at 11:32:26AM +0100, Laszlo Ersek wrote: > >> @@ -245,6 +245,9 @@ CONNECT_SA.START: > >> "LISTEN_PID=",

...he debug output of nbdkit, + * hence the journey through the shell. + */ + unlink (DEBUG_FILE); + char *cmd[] = { + "sh", "-c", + "exec 2> " DEBUG_FILE "\n" + "exec nbdkit -v -D nbdkit.environ=1 null 1024\n", + NULL + }; + if (nbd_connect_systemd_socket_activation (nbd, cmd) == -1) { + fprintf (stderr, "%s\n", nbd_get_error ()); + exit (EXIT_FAILURE); + } + + /* Check the size is expected so we know we managed to connect to nbdkit. */ + assert (nbd_get_size (nbd) == 1024); + + nbd_close (nbd); + + /* nbdkit doesn't know anything...

This is version 4 of the following sub-series: [libnbd PATCH v3 06/29] lib/utils: introduce xwrite() as a more robust write() [libnbd PATCH v3 07/29] lib/utils: add async-signal-safe assert() [libnbd PATCH v3 08/29] lib/utils: add unit test for async-signal-safe assert() http://mid.mail-archive.com/20230215141158.2426855-7-lersek at redhat.com

...APIs nbd_can_fast_zero(3) Test support by the server for fast zeroing (Eric Blake). nbd_connect_socket(3) nbd_aio_connect_socket(3) Connect to a local connected socket which you create in your main program using your own chosen method. nbd_connect_systemd_socket_activation(3) nbd_aio_connect_systemd_socket_activation(3) Connect to local processes that support systemd socket activation. nbd_connect_vsock(3) nbd_aio_connect_vsock(3) Used to connect to servers over "AF_VSOCK". nbd_get_handshake_flags(3)...

This commit adds a simple test of qemu-storage-daemon (QSD). On the basis that QSD is just qemu-nbd in new clothes this is only a simple test, not complete coverage. Nor does it test the unique features of QSD like being able to use QMP to create new server instances. Unfortunately QSD is not yet stable upstream. This version works with qemu 5.1.0 but at least two of the command line

..., sockname); > else if (hostname) > r = nbd_connect_tcp (h->nbd, hostname, port); > + else if (raw_cid) > +#if !USE_VSOCK > + abort (); > +#else > + r = nbd_connect_vsock (h->nbd, cid, vport); > +#endif > else if (command.size > 0) > r = nbd_connect_systemd_socket_activation (h->nbd, (char **) command.ptr); > else if (socket_fd >= 0) I wonder if we should just call the flag "vsock=..."? However patch looks good, ACK. It may be possible to add a test. See this example, especially the line requires_linux_kernel_version. https://github.com/...