Displaying 4 results from an estimated 4 matches for "nbd_aio_pread_structr".
Did you mean:
nbd_aio_pread_structred
2019 Jun 25
2
Re: [libnbd PATCH v2 2/5] states: Wire in a read callback
...if an
> earlier chunk failed - we may decide to change one or the other for
> consistency before the API is stable.)
>
> Nothing actually passes a callback function yet, so for now this is no
> functional change; but this will make it possible for the next patch
> to add an 'nbd_aio_pread_structred' API.
I don't think non-C callbacks will be able to reliably set errno, but
that's something we can solve in future. Therefore ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.word...
2019 Jun 25
0
Re: [libnbd PATCH v2 2/5] states: Wire in a read callback
...chunk failed - we may decide to change one or the other for
>> consistency before the API is stable.)
>>
>> Nothing actually passes a callback function yet, so for now this is no
>> functional change; but this will make it possible for the next patch
>> to add an 'nbd_aio_pread_structred' API.
>
> I don't think non-C callbacks will be able to reliably set errno, but
> that's something we can solve in future. Therefore ACK.
Perhaps we could change the API to:
cmd->cb.fn.read (cmd->cb.opaque, cmd->data, cmd->count, cmd->offset,...
2019 Jun 21
0
[libnbd PATCH v2 2/5] states: Wire in a read callback
...callback on subsequent chunks if an
earlier chunk failed - we may decide to change one or the other for
consistency before the API is stable.)
Nothing actually passes a callback function yet, so for now this is no
functional change; but this will make it possible for the next patch
to add an 'nbd_aio_pread_structred' API.
---
generator/generator | 4 +++
generator/states-reply-simple.c | 15 +++++++++-
generator/states-reply-structured.c | 44 +++++++++++++++++++++++++++--
lib/internal.h | 4 ++-
4 files changed, 63 insertions(+), 4 deletions(-)
diff --git a/g...
2019 Jun 21
9
[libnbd PATCH v2 0/5] nbd_pread_structured
Since v1:
- rebase to applied patches
- split out support for Int in callbacks
- sort of test that callbacks work in OCaml (see comment in patch 5)
- rename API to nbd_pread_structured
- expose error as explicit parameter to callback
Eric Blake (5):
generator: Allow Int in callbacks
states: Wire in a read callback
states: Add nbd_pread_structured API
states: Add tests for