search for: nb_coupled_stream

...ondirectional channel gets (rate_ratio_num / rate_ratio_den) times - * as many bits as all other ambisonics channels. - */ - const int rate_ratio_num = 4; - const int rate_ratio_den = 3; + opus_int32 per_stream_rate; + const int nb_channels = st->layout.nb_streams + st->layout.nb_coupled_streams; - /* The omnidirectional ambisonics and non-diegetic stereo channels */ - const int nb_nondirectional_channels = st->layout.nb_coupled_streams * 2 + 1; - /* The remaining ambisonics channels */ - const int nb_directional_channels = nb_channels - nb_nondirectional_channels; if (st...

.../opus_multistream_encoder.c +++ b/src/opus_multistream_encoder.c @@ -747,7 +747,8 @@ static void ambisonics_rate_allocation( if (st->bitrate_bps==OPUS_AUTO) { - total_rate = num_channels * (20000 + st->layout.nb_streams*(Fs+60*Fs/frame_size)); + total_rate = (st->layout.nb_coupled_streams + st->layout.nb_streams) * + (Fs+60*Fs/frame_size) + st->layout.nb_streams * 15000; } else if (st->bitrate_bps==OPUS_BITRATE_MAX) { total_rate = num_channels * 320000; -- 2.8.0.rc3.226.g39d4020

...e implemented. Done. Also, many sure you catch all non-sensical values. For example, what if channels is set to 1000? Done. 3) From the draft, it seems like you can only have two nondiegetic channels, so instead of: + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2); + nb_coupled_streams = nondiegetic_channels / 2; Why not just have: + nb_streams = acn_channels + nondiegetic_channels; + nb_coupled_streams = nondiegetic_channels != 0; Done 4) About this change: - if (!validate_layout(&st->layout) || !validate_encoder_layout(&st->layout)) + if (!valid...

Hello all, Attached is a proposed patch for Opus that allows support for encoding non-diegetic stereo audio as a coupled stream for use with channel mapping 254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0 to 14 and j is either 0 or 1 (See IETF public draft doc attached for clarification). Please let me know any suggestions / concerns / comments. Thank you for your

...that may one day be implemented. Also, many sure you catch all non-sensical values. For example, what if channels is set to 1000? 3) From the draft, it seems like you can only have two nondiegetic channels, so instead of: + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2); + nb_coupled_streams = nondiegetic_channels / 2; Why not just have: + nb_streams = acn_channels + nondiegetic_channels; + nb_coupled_streams = nondiegetic_channels != 0; 4) About this change: - if (!validate_layout(&st->layout) || !validate_encoder_layout(&st->layout)) + if (!validate_lay...

...ues. For example, what if > channels is set to 1000? > > > Done. > > > 3) From the draft, it seems like you can only have two nondiegetic > channels, so instead of: > + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2); > + nb_coupled_streams = nondiegetic_channels / 2; > > Why not just have: > + nb_streams = acn_channels + nondiegetic_channels; > + nb_coupled_streams = nondiegetic_channels != 0; > > Done > > > 4) About this change: > - if (!validate_layout(&st->...

...els is set to 1000? > > > > > > Done. > > > > > > 3) From the draft, it seems like you can only have two nondiegetic > > channels, so instead of: > > + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2); > > + nb_coupled_streams = nondiegetic_channels / 2; > > > > Why not just have: > > + nb_streams = acn_channels + nondiegetic_channels; > > + nb_coupled_streams = nondiegetic_channels != 0; > > > > Done > > > > > > 4) About this change: > &...

...tatic int opus_multistream_encoder_init_impl( (streams<1) || (coupled_streams<0) || (streams>255-coupled_streams)) return OPUS_BAD_ARG; + st->arch = opus_select_arch(); st->layout.nb_channels = channels; st->layout.nb_streams = streams; st->layout.nb_coupled_streams = coupled_streams; @@ -767,7 +770,7 @@ static int opus_multistream_encode_native ALLOC(bandSMR, 21*st->layout.nb_channels, opus_val16); if (st->surround) { - surround_analysis(celt_mode, pcm, bandSMR, mem, preemph_mem, frame_size, 120, st->layout.nb_channels, Fs, copy_cha...

...tatic int opus_multistream_encoder_init_impl( (streams<1) || (coupled_streams<0) || (streams>255-coupled_streams)) return OPUS_BAD_ARG; + st->arch = opus_select_arch(); st->layout.nb_channels = channels; st->layout.nb_streams = streams; st->layout.nb_coupled_streams = coupled_streams; @@ -767,7 +770,7 @@ static int opus_multistream_encode_native ALLOC(bandSMR, 21*st->layout.nb_channels, opus_val16); if (st->surround) { - surround_analysis(celt_mode, pcm, bandSMR, mem, preemph_mem, frame_size, 120, st->layout.nb_channels, Fs, copy_cha...

...tatic int opus_multistream_encoder_init_impl( (streams<1) || (coupled_streams<0) || (streams>255-coupled_streams)) return OPUS_BAD_ARG; + st->arch = opus_select_arch(); st->layout.nb_channels = channels; st->layout.nb_streams = streams; st->layout.nb_coupled_streams = coupled_streams; @@ -767,7 +770,7 @@ static int opus_multistream_encode_native ALLOC(bandSMR, 21*st->layout.nb_channels, opus_val16); if (st->surround) { - surround_analysis(celt_mode, pcm, bandSMR, mem, preemph_mem, frame_size, 120, st->layout.nb_channels, Fs, copy_cha...

Changes from RFC PATCH v3 - Just rebased on tip - For all else, please see notes from RFC PATCH v3 at http://lists.xiph.org/pipermail/opus/2015-March/002902.html - latest wip opus tree/branch https://git.linaro.org/people/viswanath.puttagunta/Ne10.git branch: rfcv4_final_fft_ne10 Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am

Changes from RFC PATCH v1: - passing arch parameter explicitly - reduced stack usage by ~3.5K by using scaled NE10 fft version - moved all optimization array functions to arm_celt_map.c - Other cleanups pointed out by Timothy Phil, As you mentioned earlier, could you please address all compile and linker errors/warnings coming out of Ne10 library? You can find my working Ne10 repo at [1] You

Changes from RFC PATCH v2 - fixed compile issue when just compiling for --enable-intrinsics for ARMv7 without NE10 - Notes for NE10: - All compile/link warnings are now in upstream NE10 - Only patch pending upstream in NE10 is the one that needs to add -funsafe-math-optimizations for ARMv7 targets. - Phil Wang @ ARM is working on getting this fixed. - Note that even without

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest

Hello Timothy / Jean-Marc / opus-dev, This patch series is follow up on work I posted on [1]. In addition to what was posted on [1], this patch series mainly integrates Fixed point FFT implementations in NE10 library into opus. You can view my opus wip code at [2]. Note that while I found some issues both with the NE10 library(fixed fft) and with Linaro toolchain (armv8 intrinsics), the work