Displaying 5 results from an estimated 5 matches for "native_false".
2017 Nov 17
2
[PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros
...PARAVIRT_SPINLOCKS)
DEF_NATIVE(pv_lock_ops, queued_spin_unlock, NATIVE_QUEUED_SPIN_UNLOCK);
DEF_NATIVE(pv_lock_ops, vcpu_is_preempted, NATIVE_ZERO);
#endif
Isn't that a bug? Seems like it should _return_ zero. Zeroing the arg
shouldn't have any effect.
If I'm right, we could call it NATIVE_FALSE.
--
Josh
2017 Nov 17
2
[PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros
...PARAVIRT_SPINLOCKS)
DEF_NATIVE(pv_lock_ops, queued_spin_unlock, NATIVE_QUEUED_SPIN_UNLOCK);
DEF_NATIVE(pv_lock_ops, vcpu_is_preempted, NATIVE_ZERO);
#endif
Isn't that a bug? Seems like it should _return_ zero. Zeroing the arg
shouldn't have any effect.
If I'm right, we could call it NATIVE_FALSE.
--
Josh
2017 Nov 18
0
[PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros
...ATIVE(pv_lock_ops, vcpu_is_preempted, NATIVE_ZERO);
> #endif
>
> Isn't that a bug? Seems like it should _return_ zero. Zeroing the arg
> shouldn't have any effect.
Right. Before that patch it _did_ return zero instead of zeroing arg1.
> If I'm right, we could call it NATIVE_FALSE.
I'd prefer NATIVE_ZERO, as it will be usable for non-boolean cases, too.
Juergen
2017 Nov 17
2
[PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros
On Wed, Oct 04, 2017 at 10:58:24AM -0500, Josh Poimboeuf wrote:
> Convert the hard-coded native patch assembly code strings to macros to
> facilitate sharing common code between 32-bit and 64-bit.
>
> These macros will also be used by a future patch which requires the GCC
> extended asm syntax of two '%' characters instead of one when specifying
> a register name.
>
2017 Nov 17
2
[PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros
On Wed, Oct 04, 2017 at 10:58:24AM -0500, Josh Poimboeuf wrote:
> Convert the hard-coded native patch assembly code strings to macros to
> facilitate sharing common code between 32-bit and 64-bit.
>
> These macros will also be used by a future patch which requires the GCC
> extended asm syntax of two '%' characters instead of one when specifying
> a register name.
>