search for: natechancellor

...ed cpumask_available to fix warnings of this nature. Use that here so that clang does not warn regardless of CONFIG_CPUMASK_OFFSTACK's value. Link: https://github.com/ClangBuiltLinux/linux/issues/982 Reported-by: Sedat Dilek <sedat.dilek at gmail.com> Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- arch/x86/mm/mmio-mod.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c index 109325d77b3e..43fd19b3f118 100644 --- a/arch/x86/mm/mmio-mod.c +++ b/arch/x86/mm/mmio-mod.c @@ -372,7 +372,7 @@ static void ente...

...ve the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") Link: https://github.com/ClangBuiltLinux/linux/issues/886 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7bfe365d9372..341458fd95ca 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_ballo...

...ve the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") Link: https://github.com/ClangBuiltLinux/linux/issues/886 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7bfe365d9372..341458fd95ca 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_ballo...

On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor <natechancellor at gmail.com> wrote: > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > When building with Clang + -Wtautological-compare and > > CONFIG_CPUMASK_OFFSTACK unset: > > > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cp...

On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote: > > > > Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor at gmail.com>: > > > > ?Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label > > 'out_del_vqs' [-Wunused-label] > > out_del_vqs: > > ^~~~~~~~~~~~ > > 1 warning genera...

On Wed, 8 Apr 2020 13:53:23 -0700 Nathan Chancellor <natechancellor at gmail.com> wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false [-Wtautological-pointer-compare] >...

On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor <natechancellor at gmail.com> wrote: > > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > Hi Nathan, thanks for the quick patch. I can confirm I have no CONFIG_CPUMASK_OFFSTACK set. Regards, - Sedat - > arch/x86/mm/mmio-mod.c:375:6: warning: compariso...

On Wed, Apr 8, 2020 at 11:12 PM Sedat Dilek <sedat.dilek at gmail.com> wrote: > > On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor > <natechancellor at gmail.com> wrote: > > > > When building with Clang + -Wtautological-compare and > > CONFIG_CPUMASK_OFFSTACK unset: > > > > Hi Nathan, > > thanks for the quick patch. > > I can confirm I have no CONFIG_CPUMASK_OFFSTACK set. > Feel free to add appro...

On Mon, 18 May 2020 11:52:47 -0700 Nick Desaulniers <ndesaulniers at google.com> wrote: > On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor > <natechancellor at gmail.com> wrote: > > > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-compare and > > > CONFIG_CPUMASK_OFFSTACK unset: > > > > > > arch/x86/mm/mmio-mod.c:375:6: warning: co...

...rated. Add the parentheses as it was clearly intended for the ternary condition to be evaluated first. Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail") Link: https://github.com/ClangBuiltLinux/linux/issues/1159 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- Presumably, this will be squashed but I included a fixes tag nonetheless. Apologies if this has already been noticed and fixed already, I did not find anything on LKML. kernel/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/resource.c b/...

...be defined under those conditions so that the meaning of the code doesn't change and clang no longer warns. Fixes: 7f466032dc9e ("vhost: access vq metadata through kernel virtual address") Link: https://github.com/ClangBuiltLinux/linux/issues/508 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/vhost/vhost.c | 44 +++++++++++++++++++++---------------------- drivers/vhost/vhost.h | 7 ++++--- 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index dc9301d31f12..cc56d08b4275 100644 --- a/drivers/vhos...

...be defined under those conditions so that the meaning of the code doesn't change and clang no longer warns. Fixes: 7f466032dc9e ("vhost: access vq metadata through kernel virtual address") Link: https://github.com/ClangBuiltLinux/linux/issues/508 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/vhost/vhost.c | 44 +++++++++++++++++++++---------------------- drivers/vhost/vhost.h | 7 ++++--- 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index dc9301d31f12..cc56d08b4275 100644 --- a/drivers/vhos...

...sirkin <mst at redhat.com> Note: due to code driver changes the driver-core tree, the following patch is needed when merging tree with commit 92ce7e83b4e5 ("driver_find_device: Unify the match function with class_find_device()") in the driver-core tree: From: Nathan Chancellor <natechancellor at gmail.com> Subject: [PATCH] iommu/virtio: Constify data parameter in viommu_match_node After commit 92ce7e83b4e5 ("driver_find_device: Unify the match function with class_find_device()") in the driver-core tree. Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>...

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David

...tches the size of the features field throughout this driver, which is u64 so there should be no functional change. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Link: https://github.com/ClangBuiltLinux/linux/issues/1140 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 50 +++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9df69d5efe8c..70676a6d1691 100644 --- a/drivers/vdpa/mlx5/net/mlx...

...tches the size of the features field throughout this driver, which is u64 so there should be no functional change. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Link: https://github.com/ClangBuiltLinux/linux/issues/1140 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 50 +++++++++++++++---------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9df69d5efe8c..70676a6d1691 100644 --- a/drivers/vdpa/mlx5/net/mlx...

...Slaby <jirislaby at kernel.org> Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org> Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp> Cc: Peilin Ye <yepeilin.cs at gmail.com> Cc: George Kennedy <george.kennedy at oracle.com> Cc: Nathan Chancellor <natechancellor at gmail.com> Cc: Peter Rosin <peda at axentia.se> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> --- Documentation/gpu/todo.rst | 18 ++++++++++++++ drivers/video/fbdev/core/fbcon.c | 42 ++++++-------------------------- 2 files changed, 25 insertions(+), 35 deleti...

...ernel.org> > Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org> > Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp> > Cc: Peilin Ye <yepeilin.cs at gmail.com> > Cc: George Kennedy <george.kennedy at oracle.com> > Cc: Nathan Chancellor <natechancellor at gmail.com> > Cc: Peter Rosin <peda at axentia.se> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > --- > Documentation/gpu/todo.rst | 18 +++++++++++++ > drivers/video/fbdev/core/fbcon.c | 45 ++++++-------------------------- > 2 files changed...

...c: "Gustavo A. R. Silva" <gustavoars at kernel.org> > > Cc: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp> > > Cc: Peilin Ye <yepeilin.cs at gmail.com> > > Cc: George Kennedy <george.kennedy at oracle.com> > > Cc: Nathan Chancellor <natechancellor at gmail.com> > > Cc: Peter Rosin <peda at axentia.se> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > > --- > > drivers/video/fbdev/core/fbcon.c | 38 ++++++-------------------------- > > 1 file changed, 7 insertions(+), 31 deletions(-)...