search for: name_err

Just updated to 3.0.4 under cygwin and I'm now getting lookup failures in the log. 2008/10/24 00:13:23 [1984] name lookup failed for X.X.X.X: Unknown server error Looking at the code it seems the call will never succeed? /* reverse lookup */ name_err = getnameinfo((struct sockaddr *) ss, ss_len, name_buf, name_buf_size, port_buf, port_buf_size, NI_NAMEREQD | NI_NUMERICSERV); if (name_err != 0) { strlcpy(name_buf, default_name, name_buf_size); rprintf(FLOG, "name l...

....uk QAContact: rsync-qa@samba.org Just updated to 3.0.4 under cygwin and I'm now getting lookup failures in the log. 2008/10/24 00:13:23 [1984] name lookup failed for X.X.X.X: Unknown server error Looking at the code it seems the call will never succeed? /* reverse lookup */ name_err = getnameinfo((struct sockaddr *) ss, ss_len, name_buf, name_buf_size, port_buf, port_buf_size, NI_NAMEREQD | NI_NUMERICSERV); if (name_err != 0) { strlcpy(name_buf, default_name, name_buf_size); rprintf(FLOG, "name l...

...return name_buf; } @@ -216,14 +216,13 @@ void client_sockaddr(int fd, * @param fd file descriptor for client socket. **/ int lookup_name(int fd, const struct sockaddr_storage *ss, - socklen_t ss_len, char *name_buf, size_t name_buf_len, char *port_buf, size_t port_buf_len) { int name_err; /* reverse lookup */ - name_err = getnameinfo((struct sockaddr *) ss, ss_len, + name_err = getnameinfo((struct sockaddr *) ss, ss->ss_len, name_buf, name_buf_len, port_buf, port_buf_len, NI_NAMEREQD | NI_NUMERICSERV);

...: old-style parameter list (anachronism) void setup_iconv(); ^ clientname.c(33): remark #1419: external declaration in primary source file extern int am_server; ^ clientname.c(224): remark #981: operands are evaluated in unspecified order client_addr(fd), gai_strerror(name_err)); ^ clientname.c(223): remark #981: operands are evaluated in unspecified order rprintf(FLOG, "name lookup failed for %s: %s\n", ^ clientname.c(270): remark #181: argument is incompatible with corresponding format string conversion fn, ai->ai_addr...