search for: naborted

Added a new function, "ask_yes_or_no", to ovirt-functions. It contains a default prompt if none is provided. Changed all prompts that ask for yes, no and/or abort to use this new method. Signed-off-by: Darryl L. Pierce <dpierce at redhat.com> --- scripts/ovirt-config-boot-wrapper | 8 ++--- scripts/ovirt-config-collectd | 39 +++++++++++++++-----------

Here is the first Perl script I've tried to write to run rsync. It seems to work, but I don't see the progress like I should. I apologize if it's sloppy, I should add that it's not only the first perl script I've written for rsync, it's the first perl script I've written at all. ___________________________ #!/usr/bin/perl -w print " This command will DELETE

If an existing set of configuration files exist they are deleted. While in the configuration menu, only one NIC is configured. If the user selects a second network card to configure then the previous configuration is discarded and only the new one saved. Signed-off-by: Darryl L. Pierce <dpierce at redhat.com> --- scripts/ovirt-config-networking | 29 ++++++++++++++++++++++++++--- 1 files

...-n "$OVIRT_DNS" ]; then - echo "Press Enter for defaults: ($OVIRT_DNS)" + read -ep "Please enter the ${dns} DNS server: " + if [[ -z "${DNS}" ]] && [[ -z "${REPLY}" ]]; then + printf "\nAborted...\n" + return fi - read -ep ": " - DNS=$REPLY - - if [ -z "$DNS" ]; then - DNS=$OVIRT_DNS + if [[ -z "${DNS}" ]]; then + DNS="${REPLY}" + el...

...if [[ -z "${REPLY}" ]]; then + local ADDRESS=$(trim_whitespace "$REPLY") + if [[ -z "${ADDRESS}" ]]; then if [[ -z "${DNS}" ]]; then printf "\nAborted...\n" return @@ -366,15 +367,20 @@ function configure_dns break fi fi - if is_valid_ipv4 $REPLY; then + if is_valid_ipv4 $ADDRES...

The first line of the comment had a typo in it.

This was an older patch that had to be rebased against the current tip.

This includes a missed break and two spots where $ADDRESS was copied as $address instead.

This patch supercedes the previous and includes fixes based on feedback from apevec. Duplicate checks now check the whole address, so substrings won't cause false positives.

I missed one situation in the last patch. It wasn't properly handling the karg for NTP. This patch fixes that.

This fixes networking changes when switching from dhcp/static to disabled. Before the ifcfg scripts would contain old values from the previous configuration. Support for disabled devices is now added and some useless remnant bash->python coding cleaned up --- scripts/network.py | 45 +++++++++++++++++++--------------------- scripts/ovirt-config-setup.py | 34

--- scripts/network.py | 207 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 207 insertions(+), 0 deletions(-) create mode 100644 scripts/network.py diff --git a/scripts/network.py b/scripts/network.py new file mode 100644 index 0000000..28e32f2 --- /dev/null +++ b/scripts/network.py @@ -0,0 +1,207 @@ +#!/usr/bin/python + +from ovirtfunctions import * +import tempfile

This is a repost of patches for ovirt-config-* ACK to all. Pushed.