search for: my_isspace

Hey, I noticed my_isspace() is being used in menu/mainmenu and readconfig com32 modules. Why not use isblank() instead? Here's a patch: thanks. Ram --- com32/modules/menu.h //depot/opensource/main/syslinux-3/com32/modules/menu.h#2 +++ com32/modules/menu.h 07-03-15 16:27:14 @@ -87,11 +87,6 @@ void parse_configs(char...

...+- com32/menu/readconfig.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/com32/include/menu.h b/com32/include/menu.h index bc0182f..b0251e4 100644 --- a/com32/include/menu.h +++ b/com32/include/menu.h @@ -195,7 +195,7 @@ void local_cursor_enable(bool); static inline int my_isspace(char c) { - return (unsigned char)c <= ' '; + return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f'; } int my_isxdigit(char c); diff --git a/com32/menu/readconfig.c b/com32/menu/readconfig.c index b7814be..a433fad 100644 --- a/com32/menu/readconfig.c...

...g patch? Feel free to only apply the change to readconfig.c if you want. -- -Gene diff --git a/com32/include/menu.h b/com32/include/menu.h index bc0182f..b0251e4 100644 --- a/com32/include/menu.h +++ b/com32/include/menu.h @@ -195,7 +195,7 @@ void local_cursor_enable(bool); static inline int my_isspace(char c) { - return (unsigned char)c <= ' '; + return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f'; } int my_isxdigit(char c); diff --git a/com32/menu/readconfig.c b/com32/menu/readconfig.c index 257b042..a433fad 100644 --- a/com32/menu/readconfig.c +...

Hi, hpa wrote: > On PowerPC (I think) "unsigned char" is the default. In any case it seems a good idea to interpret the character more explicitely. To my experience, one signdness change causes a little tree of consequential signedness changes or questionable cast operations. How about the following instead ? if ((c >= 0 && c <= ' ') || c == '\x7f')

...ing.h> +#include <fcntl.h> +#include <sys/stat.h> +#include <syslinux/linux.h> + #include <com32.h> #include "menu.h" +bool opt_quiet = false; + +static const char *refdup_word(char **p) +{ + char *sp = *p; + char *ep = sp; + + while (*ep && !my_isspace(*ep)) + ep++; + + *p = ep; + return refstrndup(sp, ep - sp); +} + + +// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - +char *skip_spaces(char *s) +{ + while(*s && (*s == ' ' || *s == '\t')) s++; + + return s; +} + + +// - - - - - -...

...elflink/ldlinux/readconfig.c --- a/com32/elflink/ldlinux/readconfig.c +++ b/com32/elflink/ldlinux/readconfig.c @@ -786,7 +786,7 @@ static int parse_path(char *p) char *c = p; /* Find the next directory */ - while (*c && *c != ':') + while (*c && !my_isspace(*c)) c++; str = refstrndup(p, c - p); Speaking of which, why does the code in elflink/ldlinux use "my_isspace" while the rest of SYSLINUX uses isspace()? And why is there not_whitespace() in core/include/fs.h? Next, path_add() adds new entries at the beginning of t...

...nst char *edit_cmdline(const char *input, int top /*, int width */ , redraw = 1; } break; + case KEY_TAB: + { + const char *p; + size_t len; + + /* Label completion enabled? */ + if (nocomplete) + break; + + p = cmdline; + len = 0; + while(*p && !my_isspace(*p)) { + p++; + len++; + } + + print_labels(cmdline, len); + redraw = 1; + break; + } default: if (key >= ' ' && key <= 0xFF && len < MAX_CMDLINE_LEN - 1) { diff --git a/com32/elflink/ldlinux/config.h b/com32/elflink/ldlinux/config.h inde...

From: Matt Fleming <matt.fleming at linux.intel.com> These patches are based on the elflink branch. This set of patches is my attempt at moving the command-line interface functionality out of the core and into an ELF module to reduce the size of the core. The most interesting patch is [PATCH 4/4] which moves the cli code out of core/elflink and into com32/elflink/modules. [PATCH 4/4] is

...ndex 3d6aa27..c6b86d4 100644 --- a/com32/elflink/ldlinux/readconfig.c +++ b/com32/elflink/ldlinux/readconfig.c @@ -786,7 +786,7 @@ static int parse_path(char *p) char *c = p; /* Find the next directory */ - while (*c && *c != ':') + while (*c && !my_isspace(*c)) c++; str = refstrndup(p, c - p); commit 647e30a1d12ec8a71551910e06e1d16fca27851e Author: Philip Pokorny <ppokorny at penguincomputing.com> Date: Sun Mar 5 20:59:05 2017 -0800 Change path_add so that it adds new entries at the end not the beginning of the...

The following changes since commit 8c576f1fe03e34879921311f46613a35c6530000: Merge remote-tracking branch 'mfleming/for-hpa/elflink/fix-compiler-warnings' into elflink (2011-03-16 12:53:58 -0700) are available in the git repository at: git://git.zytor.com/users/mfleming/syslinux.git for-hpa/elflink/ldlinux Matt Fleming (1): ldlinux: Perform auto-boot if NOESCAPE set in config

From: Matt Fleming <matt.fleming at intel.com> The following patch series is available at, git://git.zytor.com/users/mfleming/syslinux.git elflink All patches are against the 'elflink' branch. This series fixes a few serious bugs and some behavioural incompatibilities with the 4.x series. Matt Fleming (19): ldlinux: Initialise 'p' before using it. ldlinux: Parse

From: Matt Fleming <matt.fleming at linux.intel.com> This series fixes some bugs and switches the elflink branch to be entirely ELF modules. It applies on top of, http://syslinux.zytor.com/archives/2011-April/016369.html The deletions in the diff stat below are mainly from deleting com32/elflink/modules (finally!). Now there should be no duplicate code because we don't need COM32 and

From: Matt Fleming <matt.fleming at linux.intel.com> This is a series of patches that, * shrink the core by moving things into an ldlinux ELF module * begin wiring up some of the C versions of various functions The core now only contains essential code and loads the ldlinux module to do everything else, like providing a command line interface and loading kernels. The config file parsing

Hi, These patches contain support for some features that are already in Syslinux 4 but weren't working properly on the elflink branch. It's another step closer to feature parity with Syslinux 4. Having to jump through the comboot API for localboot support is less than ideal and I'll eventually fix that, probably when we move a big chunk of code from asm to C. Also, there's a

...KT_PXE }, + { NULL, KT_NONE }, +}; + +/* + * Return a pointer to one byte after the last character of the + * command. + */ +static inline const char *find_command(const char *str) +{ const char *p; - int len; - /* Find the end of the command */ - p = kernel; + p = str; while (*p && !my_isspace(*p)) p++; + return p; +} +static enum kernel_type parse_kernel_type(const char *kernel) +{ + const struct file_ext *ext; + const char *p; + int len; + + /* Find the end of the command */ + p = find_command(kernel); len = p - kernel; - if (!strncmp(kernel + len - 4, ".c32", 4)) {...