search for: mux_master_read_cb

...uct being pointed to. The bug is benign in the original code because the struct has only an int element inside it, but it would corrupt memory if the struct were to be extended. Simple fix here: diff --git a/mux.c b/mux.c index 3f5babc..f151021 100644 --- a/mux.c +++ b/mux.c @@ -931,7 +976,7 @@ mux_master_read_cb(Channel *c) /* Setup ctx and */ if (c->mux_ctx == NULL) { - state = xcalloc(1, sizeof(state)); + state = xcalloc(1, sizeof(*state)); c->mux_ctx = state; channel_register_cleanup(c->self, mux_master_control_cleanup_cb, 0); -- -- H...

...sist_detach: background process is 85607 debug2: fd 4 setting O_NONBLOCK debug1: forking to background debug1: multiplexing control connection debug3: fd 5 is O_NONBLOCK debug3: fd 5 is O_NONBLOCK debug1: channel 1: new [mux-control] debug3: channel_post_mux_listener: new mux channel 1 fd 5 debug3: mux_master_read_cb: channel 1: hello sent debug2: set_control_persist_exit_time: cancel scheduled exit debug3: mux_master_read_cb: channel 1 packet type 0x00000001 len 4 debug2: mux_master_process_hello: channel 1 slave version 4 debug2: mux_client_hello_exchange: master version 4 debug3: mux_client_forwards: request...

...ve session. debug1: pledge: id debug2: set_control_persist_exit_time: schedule exit in 60 seconds debug1: multiplexing control connection debug2: fd 5 setting O_NONBLOCK debug3: fd 5 is O_NONBLOCK debug1: channel 1: new [mux-control] debug3: channel_post_mux_listener: new mux channel 1 fd 5 debug3: mux_master_read_cb: channel 1: hello sent debug2: set_control_persist_exit_time: cancel scheduled exit debug3: mux_master_read_cb: channel 1 packet type 0x00000001 len 4 debug2: process_mux_master_hello: channel 1 slave version 4 debug2: mux_client_hello_exchange: master version 4 debug3: mux_client_forwards: request...

On Mon, 21 Sep 2020 at 09:53, Hisashi T Fujinaka <htodd at twofifty.com> wrote: > OK, NetBSD-current amd64, NetBSD-9-amd64, and NetBSD-9-i386 all pass all > tests. MacOS, well, I always try it but it has problems. What's the problem on OS X? We test on it regularly (El Capitan and High Sierra) and the only problem I'm aware of is that the native libcrypto on High Sierra is

...Version: 8.3p1 Hardware: ix86 OS: Linux Status: NEW Severity: critical Priority: P5 Component: ssh Assignee: unassigned-bugs at mindrot.org Reporter: sergiy.lozovsky at gmail.com mux_ctx is allocated at mux_master_read_cb() but not freed. This can cause ssh process memory leak when multiplexing is used. Steps to reproduce: - Create ControlMaster $ ./ssh -o ControlPath=~/.ssh/mux -o ControlMaster=yes -N -n localhost - Use multiplexing $ while true; do ./ssh -o ControlPath=~/.ssh/mux localhost true; done...

These patches implement a new mux client request to list the currently opened TCP forwardings. It also removes some todos regarding keeping the list of forwardings in the options up-to-date. Bert Wesarg (6): attach the forwarding type to struct Forward merge local and remote forward lists generate unique ids for forwardings to be used for identification remove closed forwardings from

...r, "unimplemented"); + + out: + if (fwd_desc != NULL) + xfree(fwd_desc); + if (fwd.listen_host != NULL) + xfree(fwd.listen_host); + if (fwd.connect_host != NULL) + xfree(fwd.connect_host); + + return ret; +} + +/* Channel callbacks fired on read/write from mux slave fd */ +static void +mux_master_read_cb(Channel *c, void *ctx) +{ + struct mux_master_state *state = (struct mux_master_state *)ctx; + Buffer in, out; + void *ptr; + u_int type, have, i; + int ret = -1; + + /* Complete setup of channel */ + if (ctx == NULL) { + state = xcalloc(1, sizeof(state)); + state->conn_state = MUX_HELLO_SEND;...