search for: multiple_matches

...src/librpm.ml | 4 ++-- src/librpm.mli | 2 +- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/librpm-c.c b/src/librpm-c.c index 3bd25a2..75ca4d7 100644 --- a/src/librpm-c.c +++ b/src/librpm-c.c @@ -66,10 +66,15 @@ librpm_handle_closed (void) } static void -librpm_raise_multiple_matches (int occurrences) +librpm_raise_multiple_matches (value pkgv, int occurrences) { - caml_raise_with_arg (*caml_named_value ("librpm_multiple_matches"), - Val_int (occurrences)); + CAMLparam1 (pkgv); + + value args[] = { pkgv, Val_int (occurrences) }; + caml_raise...

...9798f9..71d8b64 100644 --- a/src/supermin.ml +++ b/src/supermin.ml @@ -298,6 +298,8 @@ let () = error "error: %s: %s: %s" fname (Unix.error_message code) param | Failure msg -> (* from failwith/failwithf *) error "failure: %s" msg + | Librpm.Multiple_matches (package, count) -> (* from librpm *) + error "RPM error: %d occurrences for %s" count package | Invalid_argument msg -> (* probably should never happen *) error "internal error: invalid argument: %s" msg | Assert_failure (file, line, char) ->...

...uestfs/supermin.d/udev- rules.tar.gz type gzip base image (tar) supermin: build: visiting /usr/lib64/guestfs/supermin.d/zz-packages-xfs type uncompressed packages supermin: mapping package names to installed packages supermin: resolving full list of package dependencies supermin: exception: Librpm.Multiple_matches(2) libguestfs: error: /usr/bin/supermin exited with error status 1, see debug messages above libguestfs: clear_socket_create_context: setsockcreatecon failed: NULL: Invalid argument [you can ignore this message if you are not using SELinux + sVirt] libguestfs: closing guestfs handle 0x55f938840880...

Hi, On Tuesday, 22 January 2019 19:03:36 CET CHANU ROMAIN wrote: > supermin: resolving full list of package dependencies > supermin: exception: Librpm.Multiple_matches(2) > libguestfs: error: /usr/bin/supermin exited with error status 1, see > debug messages above This happens because librpm reports more than 1 RPM matching a NEVRA (Name/Epoch/Version/Release/Architecture), e.g. bash-4.4.23-6.fc29.x86_64. Unfortunately the error reporting does not provide...

Hi, this work makes supermin use the rpm library instead of invoking rpm directly. This, together with a needed refactoring of the dependency resolution, should help in make supermin faster on rpm-based systems. Surely the patches will still need polishing, especially for behaviours of newly added stuff, but at least it's a good starting point. Noting that you need rpm-devel on most of rpm

...ules.tar.gz type gzip base image (tar) > supermin: build: visiting /usr/lib64/guestfs/supermin.d/zz-packages-xfs > type uncompressed packages > supermin: mapping package names to installed packages > supermin: resolving full list of package dependencies > supermin: exception: Librpm.Multiple_matches(2) Ouch, yes, that's a new bug we've not seen before ... It's caused by librpm returning an unexpected value, but I'm not sure why: https://github.com/libguestfs/supermin/blob/1ed4bdd4d782d8f94b197283866cf24f86f7869b/src/librpm-c.c#L298 I'll have to have a look at the docume...

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1266918