search for: mszeredi

...> > >>>> In this first round of cleanups, I have taken care of most pressing > >>>> issues. > >>>> > >>>> These patches apply on top of following. > >>>> > >>>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > >>>> > >>>> I have tested these patches with mount/umount and device removal using > >>>> qemu monitor. For example. > >>> > >>> Is device removal mandatory? Can't this be made a non-removable > >...

...; > > > > > > > In this first round of cleanups, I have taken care of most pressing > > > > issues. > > > > > > > > These patches apply on top of following. > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > > > > > > > > I have tested these patches with mount/umount and device removal using > > > > qemu monitor. For example. > > > > > > Is device removal mandatory? Can't this be made a non-removable > > > device...

...; > > > > > > > In this first round of cleanups, I have taken care of most pressing > > > > issues. > > > > > > > > These patches apply on top of following. > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > > > > > > > > I have tested these patches with mount/umount and device removal using > > > > qemu monitor. For example. > > > > > > Is device removal mandatory? Can't this be made a non-removable > > > device...

...cking related TODO > > items and races w.r.t device removal. > > > > In this first round of cleanups, I have taken care of most pressing > > issues. > > > > These patches apply on top of following. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 > > > > I have tested these patches with mount/umount and device removal using > > qemu monitor. For example. > > Is device removal mandatory? Can't this be made a non-removable > device? Is there a good reason why removing the virtio-fs device...

On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > Git tree for this version is available here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v5 > > Only post patches that actually add virtiofs (virtiofs-v5-base..virtiofs-v5). > > I've folded the series from Vivek and fixed a couple of TODO comments > myself. AFAICS two issues remain that need to be resolved in the short > term, one way or the o...

On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > Git tree for this version is available here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v5 > > Only post patches that actually add virtiofs (virtiofs-v5-base..virtiofs-v5). > > I've folded the series from Vivek and fixed a couple of TODO comments > myself. AFAICS two issues remain that need to be resolved in the short > term, one way or the o...

The pull request you sent on Thu, 26 Sep 2019 10:43:40 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git tags/virtio-fs-5.4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8f744bdee4fefb17fac052c7418b830de2b59ac8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker

...thread is blocked on page lock (process A). Fix this by creating a unique work_struct for each async reply that can block (O_DIRECT read). Fixes: a62a8ef9d97d ("virtio-fs: add virtiofs filesystem") Signed-off-by: Vivek Goyal <vgoyal at redhat.com> Signed-off-by: Miklos Szeredi <mszeredi at redhat.com> Signed-off-by: Sasha Levin <sashal at kernel.org> --- fs/fuse/file.c | 1 + fs/fuse/fuse_i.h | 1 + fs/fuse/virtio_fs.c | 106 +++++++++++++++++++++++++++++--------------- 3 files changed, 73 insertions(+), 35 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/...

...thread is blocked on page lock (process A). Fix this by creating a unique work_struct for each async reply that can block (O_DIRECT read). Fixes: a62a8ef9d97d ("virtio-fs: add virtiofs filesystem") Signed-off-by: Vivek Goyal <vgoyal at redhat.com> Signed-off-by: Miklos Szeredi <mszeredi at redhat.com> Signed-off-by: Sasha Levin <sashal at kernel.org> --- fs/fuse/file.c | 1 + fs/fuse/fuse_i.h | 1 + fs/fuse/virtio_fs.c | 106 +++++++++++++++++++++++++++++--------------- 3 files changed, 73 insertions(+), 35 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/...

Hi, Michael Tsirkin pointed out issues w.r.t various locking related TODO items and races w.r.t device removal. In this first round of cleanups, I have taken care of most pressing issues. These patches apply on top of following. git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 I have tested these patches with mount/umount and device removal using qemu monitor. For example. virsh qemu-monitor-command --hmp vm9-f28 device_del myvirtiofs Now a mounted device can be removed and file system will return errors -ENOTCONN and one can unmount it. Miklos,...

...osed or an fsync(2) performed. This option has no effect > on mmap-ed writes or writes going through the DAX mechanism. > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > Signed-off-by: Miklos Szeredi <mszeredi at redhat.com> Overall this looks ok to me. Handling full vq by a timer is really gross but it's correct - just terribly inefficient. I think you should add a MAINTAINERS entry though, we want virtualization at lists.linux-foundation.org Cc'd on patches. With that corrected: Acked-b...

...osed or an fsync(2) performed. This option has no effect > on mmap-ed writes or writes going through the DAX mechanism. > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > Signed-off-by: Miklos Szeredi <mszeredi at redhat.com> What's with all of the TODOs? Some of these are really scary, looks like they need to be figured out before this is merged. Endian-ness for fuse header also looks wrong. > --- > fs/fuse/Kconfig | 11 + > fs/fuse/Makefile | 1 +...

...osed or an fsync(2) performed. This option has no effect > on mmap-ed writes or writes going through the DAX mechanism. > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > Signed-off-by: Miklos Szeredi <mszeredi at redhat.com> What's with all of the TODOs? Some of these are really scary, looks like they need to be figured out before this is merged. Endian-ness for fuse header also looks wrong. > --- > fs/fuse/Kconfig | 11 + > fs/fuse/Makefile | 1 +...

...e Yoknis <mike.yoknis@hp.com> Mikel Astiz <mikel.astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...

...astiz.oss@gmail.com> Mikel Astiz <mikel.astiz@bmw-carit.de> Mikhail Gruzdev <michail.gruzdev@gmail.com> Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> Mikko Tuumanen <mikko.tuumanen@qemsoftware.com> Mikko Vinni <mmvinni@yahoo.com> Miklos Szeredi <mszeredi@suse.cz> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> Mikulas Patocka <mpatocka@redhat.com> Milan Broz <mbroz@redhat.com> Milo Kim <milo.kim@ti.com> Milo(Woogyom) Kim <milo.kim@ti.com> Milos Vyletel <milos.vyletel@sde.cz> Mimi Zohar <zoh...