search for: mst_state

...,49 @@ static const struct drm_dp_mst_topology_cbs dm_mst_cbs = { .register_connector = dm_dp_mst_register_connector }; -void amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, - struct amdgpu_dm_connector *aconnector) +static const struct drm_private_state_funcs dm_mst_state_funcs = { + .atomic_duplicate_state = drm_atomic_dp_mst_duplicate_topology_state, + .atomic_destroy_state = drm_atomic_dp_mst_destroy_topology_state, +}; + +int amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, + struct amdgpu_dm_connector *aconnector) { + struct drm_dp...

...,49 @@ static const struct drm_dp_mst_topology_cbs dm_mst_cbs = { .register_connector = dm_dp_mst_register_connector }; -void amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, - struct amdgpu_dm_connector *aconnector) +static const struct drm_private_state_funcs dm_mst_state_funcs = { + .atomic_duplicate_state = drm_atomic_dp_mst_duplicate_topology_state, + .atomic_destroy_state = drm_atomic_dp_mst_destroy_topology_state, +}; + +int amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, + struct amdgpu_dm_connector *aconnector) { + struct drm_dp...

...,48 @@ static const struct drm_dp_mst_topology_cbs dm_mst_cbs = { .register_connector = dm_dp_mst_register_connector }; -void amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, - struct amdgpu_dm_connector *aconnector) +static const struct drm_private_state_funcs dm_mst_state_funcs = { + .atomic_duplicate_state = drm_atomic_dp_mst_duplicate_topology_state, + .atomic_destroy_state = drm_atomic_dp_mst_destroy_topology_state, +}; + +int amdgpu_dm_initialize_dp_connector(struct amdgpu_display_manager *dm, + struct amdgpu_dm_connector *aconnector) { + struct drm_dp...

...> + kfree(pos); > + kfree(state); > + > + return NULL; > } > > static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, > @@ -3128,14 +3199,99 @@ static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, > { > struct drm_dp_mst_topology_state *mst_state = > to_dp_mst_topology_state(state); > + struct drm_dp_vcpi_allocation *pos, *tmp; > + > + list_for_each_entry_safe(pos, tmp, &mst_state->vcpis, next) > + kfree(pos); > > kfree(mst_state); > } > > -static const struct drm_private_state_funcs mst_state...

Latest version of https://patchwork.freedesktop.org/series/39642/ , hopefully patchwork understands this and doesn't break anything! Lots of changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate state

Latest version of PW series 39642, hopefully this should also actually come up on intel-gfx and go through CI. No changes other than rebasing to the current drm-intel-next-queued Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all

Next version of https://patchwork.freedesktop.org/series/41576/ Only changes are removing duplicate SoBs that git send-email annoyingly added. Sorry about that :( Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate

Next version of https://patchwork.freedesktop.org/series/41576/ All changes in this patch series are just to make checkpatch a little happier, no functional changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate

..._entry_safe(pos, vcpi, &state->vcpis, next) + kfree(pos); + kfree(state); + + return NULL; } static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, @@ -3128,14 +3199,99 @@ static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, { struct drm_dp_mst_topology_state *mst_state = to_dp_mst_topology_state(state); + struct drm_dp_vcpi_allocation *pos, *tmp; + + list_for_each_entry_safe(pos, tmp, &mst_state->vcpis, next) + kfree(pos); kfree(mst_state); } -static const struct drm_private_state_funcs mst_state_funcs = { +static inline int +drm_dp_mst_atomic_c...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

...gt; > } > > > > > > static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, > > > @@ -3128,14 +3199,99 @@ static void drm_dp_mst_destroy_state(struct > > > drm_private_obj *obj, > > > { > > > struct drm_dp_mst_topology_state *mst_state = > > > to_dp_mst_topology_state(state); > > > + struct drm_dp_vcpi_allocation *pos, *tmp; > > > + > > > + list_for_each_entry_safe(pos, tmp, &mst_state->vcpis, next) > > > + kfree(pos); > > > > > > kfree(mst_state); >...

...; + > > + return NULL; > > } > > > > static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, > > @@ -3128,14 +3199,99 @@ static void drm_dp_mst_destroy_state(struct > > drm_private_obj *obj, > > { > > struct drm_dp_mst_topology_state *mst_state = > > to_dp_mst_topology_state(state); > > + struct drm_dp_vcpi_allocation *pos, *tmp; > > + > > + list_for_each_entry_safe(pos, tmp, &mst_state->vcpis, next) > > + kfree(pos); > > > > kfree(mst_state); > > } > > > > -sta...

...p_mst_duplicate_state(). This makes it so drm_dp_atomic_release_vcpi_slots() is still idempotent while also throwing warnings if the driver messes up it's book keeping and tries to release VCPI slots on a port that doesn't have any pre-existing VCPI allocation - danvet - Change mst_state/state in some debugging messages to "mst state" Changes since v2: - Use kmemdup() for duplicating MST state - danvet - Move port validation out of duplicate state callback - danvet - Handle looping through MST topology states in drm_dp_mst_atomic_check() so the driver doesn't h...

...This makes it so > drm_dp_atomic_release_vcpi_slots() is still idempotent while also > throwing warnings if the driver messes up it's book keeping and tries > to release VCPI slots on a port that doesn't have any pre-existing > VCPI allocation - danvet > - Change mst_state/state in some debugging messages to "mst state" > > Changes since v2: > - Use kmemdup() for duplicating MST state - danvet > - Move port validation out of duplicate state callback - danvet > - Handle looping through MST topology states in > drm_dp_mst_atomic_check...

...p_mst_duplicate_state(). This makes it so drm_dp_atomic_release_vcpi_slots() is still idempotent while also throwing warnings if the driver messes up it's book keeping and tries to release VCPI slots on a port that doesn't have any pre-existing VCPI allocation - danvet - Change mst_state/state in some debugging messages to "mst state" Changes since v2: - Use kmemdup() for duplicating MST state - danvet - Move port validation out of duplicate state callback - danvet - Handle looping through MST topology states in drm_dp_mst_atomic_check() so the driver doesn't h...

...; and > > > > > > > tries > > > > > > > to release VCPI slots on a port that doesn't have any pre- > > > > > > > existing > > > > > > > VCPI allocation - danvet > > > > > > > - Change mst_state/state in some debugging messages to "mst > > > > > > > state" > > > > > > > > > > > > > > Changes since v2: > > > > > > > - Use kmemdup() for duplicating MST state - danvet > > > > > >...

...nings if the driver messes up it's book keeping and > > > > > tries > > > > > to release VCPI slots on a port that doesn't have any pre- > > > > > existing > > > > > VCPI allocation - danvet > > > > > - Change mst_state/state in some debugging messages to "mst state" > > > > > > > > > > Changes since v2: > > > > > - Use kmemdup() for duplicating MST state - danvet > > > > > - Move port validation out of duplicate state callback - danvet > &...

...; > > > > static void drm_dp_mst_destroy_state(struct drm_private_obj *obj, > > > > @@ -3128,14 +3199,99 @@ static void drm_dp_mst_destroy_state(struct > > > > drm_private_obj *obj, > > > > { > > > > struct drm_dp_mst_topology_state *mst_state = > > > > to_dp_mst_topology_state(state); > > > > + struct drm_dp_vcpi_allocation *pos, *tmp; > > > > + > > > > + list_for_each_entry_safe(pos, tmp, &mst_state->vcpis, next) > > > > + kfree(pos); > > > > > >...

[sorry about the resend-copy pasted the wrong header and I want to make sure this doesn't get missed!] This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude

...elease_vcpi_slots() is still idempotent while also > > > throwing warnings if the driver messes up it's book keeping and tries > > > to release VCPI slots on a port that doesn't have any pre-existing > > > VCPI allocation - danvet > > > - Change mst_state/state in some debugging messages to "mst state" > > > > > > Changes since v2: > > > - Use kmemdup() for duplicating MST state - danvet > > > - Move port validation out of duplicate state callback - danvet > > > - Handle looping through MST...