Displaying 7 results from an estimated 7 matches for "msm_atomic_commit".
Did you mean:
drm_atomic_commit
2015 Mar 30
2
[PATCH] Add virtio gpu driver.
Hi,
> > Signed-off-by: Dave Airlie <airlied at redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
>
> Standard request from my side for new drm drivers (especially if they're
> this simple): Can you please update the drivers to latest drm internal
> interfaces, i.e. using universal planes and atomic?
Up'n'running. Incremental
2015 Mar 30
2
[PATCH] Add virtio gpu driver.
Hi,
> > Signed-off-by: Dave Airlie <airlied at redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
>
> Standard request from my side for new drm drivers (especially if they're
> this simple): Can you please update the drivers to latest drm internal
> interfaces, i.e. using universal planes and atomic?
Up'n'running. Incremental
2017 Jun 28
5
[PATCH 1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error.
...m, state);
+ return ret;
+ }
drm_atomic_state_get(state);
if (async)
diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
index 9633a68b14d7..85dd485fdef4 100644
--- a/drivers/gpu/drm/msm/msm_atomic.c
+++ b/drivers/gpu/drm/msm/msm_atomic.c
@@ -232,8 +232,12 @@ int msm_atomic_commit(struct drm_device *dev,
* mark our set of crtc's as busy:
*/
ret = start_atomic(dev->dev_private, c->crtc_mask);
+ if (ret)
+ goto err_free;
+
+ ret = drm_atomic_helper_swap_state(state, true);
if (ret) {
- kfree(c);
+ commit_destroy(c);
goto error;
}
@@ -241,11 +245,9...
2017 Jun 30
0
[Intel-gfx] [PATCH 1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error.
...atomic_state_get(state);
> if (async)
lgtm.
> diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
> index 9633a68b14d7..85dd485fdef4 100644
> --- a/drivers/gpu/drm/msm/msm_atomic.c
> +++ b/drivers/gpu/drm/msm/msm_atomic.c
> @@ -232,8 +232,12 @@ int msm_atomic_commit(struct drm_device *dev,
> * mark our set of crtc's as busy:
> */
> ret = start_atomic(dev->dev_private, c->crtc_mask);
> + if (ret)
> + goto err_free;
> +
> + ret = drm_atomic_helper_swap_state(state, true);
Hm, might be simpler to have stall = false (which...
2015 Mar 30
0
[PATCH] Add virtio gpu driver.
...raxel.org/cgit/linux/commit/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a
>
> v2 coming, but I'll go over the other reviews first.
Looking good. Wrt pageflip the current MO is to handroll it in your
driver, common approach is to use the msm async commit implementation
msm_atomic_commit. The issue is simply that right now there's still no
useable generic vblank callback support (drm_irq.c is a mess) hence why
the core helpers don't support async flips yet.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
2016 May 25
3
[PATCH] Add virtio gpu driver.
...t/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a
>>
>> v2 coming, but I'll go over the other reviews first.
>
> Looking good. Wrt pageflip the current MO is to handroll it in your
> driver, common approach is to use the msm async commit implementation
> msm_atomic_commit. The issue is simply that right now there's still no
> useable generic vblank callback support (drm_irq.c is a mess) hence why
> the core helpers don't support async flips yet.
I guess I didn't do a good job at looking at your v2: Cursor is still
using legacy interfaces and not a...
2016 May 25
3
[PATCH] Add virtio gpu driver.
...t/?h=virtio-gpu-2d&id=b8edf4f38a1ec5a50f6ac8948521a12f862d3d5a
>>
>> v2 coming, but I'll go over the other reviews first.
>
> Looking good. Wrt pageflip the current MO is to handroll it in your
> driver, common approach is to use the msm async commit implementation
> msm_atomic_commit. The issue is simply that right now there's still no
> useable generic vblank callback support (drm_irq.c is a mess) hence why
> the core helpers don't support async flips yet.
I guess I didn't do a good job at looking at your v2: Cursor is still
using legacy interfaces and not a...