search for: msgcode

...pened, and when. There was a change to rwrite() that seems to be preventing the error logging. This 2.6.1 code: if (am_server) { /* Pass it to non-server side, perhaps through our sibling. */ if (msg_fd_out >= 0) { send_msg((enum msgcode)code, buf, len); return; } if (io_multiplex_write((enum msgcode)code, buf, len)) return; } will send all errors to the client and none to the log when the daemon is the server. That code replaced this code in...

Hello, Noticed this (bug?) while testing out rsync. For a little background, I need to push files real-time to some front-end servers, and I am thinking of switching from some custom shell scripts that do this job to rsync. I am thinking of running rsync as a daemon on the front-end servers, and doing an upload from the back-end server to push the data out as it comes in. So, here is the deal:

seems the behavior of rsync has changed when dealing with output and using both -v and -q at the same time ... for example: $ mkdir test1 $ touch test1/foo $ rsync-2.6.0 -avq test1 test2 $ rm -r test2 $ rsync-2.6.8 -avq test1 test2 test1/ test1/fo $ rm -r test2 $ rsync-cvs -avq test1 test2 building file list ... test1/ test1/fo $ rm -r test2 the new output in 2.6.8 comes from the calls to

...c fails at link because flist.c is calling makedev(), which is actually named mkdev() on Interix. To make rsync compatible with this, I suggest the following change (similar to what pkgsrc.org uses at the moment to make rsync work on Interix). --- rsync.h.orig +++ rsync.h @@ -255,6 +255,9 @@ enum msgcode { #if MAJOR_IN_MKDEV #include <sys/mkdev.h> +# if !defined(makedev) && defined(mkdev) +# define makedev mkdev +# endif #elif MAJOR_IN_SYSMACROS #include <sys/sysmacros.h> #endif -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are re...

Hi all, Well, yeah, that's it, really. :-) Try it. Works consistently, on Doze and Linux here ... # rsync -vvrlHSPtiypogD --stats --numeric-ids --delete-after --force -- partial-dir=.partial /tmp/ /var/tmp/ [...show stats...] unknown message 4:1 [generator] rsync error: error in rsync protocol data stream (code 12) at io.c(307) [generator=2.6.9] rsync: connection unexpectedly closed (26

...d last chars, they may be \n */ + int i; + for (i=1; i<len-1; i++) + if (!isprint(buf[i])) + buf[i] = '?'; + } + if (am_server && msg_fd_out >= 0) { /* Pass the message to our sibling. */ send_msg((enum msgcode)code, buf, len);

https://bugzilla.samba.org/show_bug.cgi?id=13109 Bug ID: 13109 Summary: rsync hangs during transfer of many small files Product: rsync Version: 3.1.2 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org

...nder=3.0.0pre5] (Note the garbage #\001 at the end of the filename.) To fix this, mplex_write needs to convert the message data before sending its length. Here is a possible rewrite: /* Write an message to a multiplexed stream. If this fails, rsync exits. */ static void mplex_write(int fd, enum msgcode code, const char *buf, size_t len, int convert) { char buffer[BIGPATHBUFLEN]; /* Oversized for use by iconv code. */ size_t n = len; #ifdef ICONV_OPTION if (convert && ic_send == (iconv_t)-1) #endif convert = 0; #ifdef ICONV_OPTION /* We nee...

...FLAGS FLAG_DELETE +/* These flist flags can be set after the flist is transferred. */ + +/*#define FLAG_DELETE (1<<0) -- from the above list */ +#define FLAG_HLINK_LAST (1<<1) + /* update this if you make incompatible changes */ #define PROTOCOL_VERSION 28 @@ -384,7 +389,7 @@ enum msgcode { #define GID_NONE (gid_t) -1 struct hlink { - struct file_struct *head; + int index; struct file_struct *next; }; @@ -396,7 +401,7 @@ struct idev { #define F_DEV link_u.idev->dev #define F_INODE link_u.idev->inode -#define F_HEAD link_u.links->head +#define F_INDEX link_u.lin...

...LIVE_FLAGS FLAG_DELETE +/* These flist flags can be set after the flist is transferred. */ + +/*#define FLAG_DELETE (1<<0) -- from the above list */ +#define FLAG_SENT (1<<1) + /* update this if you make incompatible changes */ #define PROTOCOL_VERSION 28 @@ -120,6 +126,7 @@ enum msgcode { MSG_ERROR=FERROR, MSG_INFO=FINFO, MSG_LOG=FLOG, /* remote logging */ MSG_REDO=4, /* reprocess indicated flist index */ MSG_DONE=5, /* current phase is done */ + MSG_SUCCESS=6, /* successfully updated indicated flist index */ }; #include "errcode.h" Index: rsync.yo --- rsync.yo...

...NORMAL_FLUSH 0 -#define CLEAR_STRUCT 0 -#define FREE_STRUCT 1 +#if HAVE_LINK +#define WITH_HLINK 1 +#else +#define WITH_HLINK 0 +#endif +#define WITHOUT_HLINK 0 /* Log-message categories. FLOG is only used on the daemon side to * output messages to the log file. */ @@ -254,6 +258,7 @@ enum msgcode { #include <assert.h> +#include "lib/pool_alloc.h" #define BOOL int @@ -428,20 +433,25 @@ struct file_struct { uchar flags; /* this item MUST remain last */ }; -#define ARENA_SIZE (32 * 1024) +/* + * Extent size for allocation pools A minimum size of 128KB + * is need...

...attached to * @job: bsg job to be processed */ static enum fc_dispatch_result fc_bsg_host_dispatch(struct request_queue *q, struct Scsi_Host *shost, struct fc_bsg_job *job) { struct fc_internal *i = to_fc_internal(shost->transportt); int cmdlen = sizeof(uint32_t); /* start with length of msgcode */ int ret; /* Validate the host command */ switch (job->request->msgcode) { case FC_BSG_HST_ADD_RPORT: cmdlen += sizeof(struct fc_bsg_host_add_rport); break; case FC_BSG_HST_DEL_RPORT: cmdlen += sizeof(struct fc_bsg_host_del_rport); break; case FC_BSG_HST_ELS_NOLOGIN: cmdl...

...attached to * @job: bsg job to be processed */ static enum fc_dispatch_result fc_bsg_host_dispatch(struct request_queue *q, struct Scsi_Host *shost, struct fc_bsg_job *job) { struct fc_internal *i = to_fc_internal(shost->transportt); int cmdlen = sizeof(uint32_t); /* start with length of msgcode */ int ret; /* Validate the host command */ switch (job->request->msgcode) { case FC_BSG_HST_ADD_RPORT: cmdlen += sizeof(struct fc_bsg_host_add_rport); break; case FC_BSG_HST_DEL_RPORT: cmdlen += sizeof(struct fc_bsg_host_del_rport); break; case FC_BSG_HST_ELS_NOLOGIN: cmdl...