search for: msg_peek

Hi Matias, thanks for this patch! Since this patch only concerns virtio_transport, I'd use the 'vsock/virtio' prefix in the commit title: "vsock/virtio: add support for MSG_PEEK" Some comments below: On Sun, Sep 22, 2019 at 05:48:27PM +0000, Matias Ezequiel Vara Larsen wrote: > This patch adds support for MSG_PEEK. In such a case, packets are not > removed from the rx_queue and credit updates are not sent. > > Signed-off-by: Matias Ezequiel Vara Larsen...

This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> Tested-by: Stefano Garzarella <sgarzare at redhat.com> --- n...

> > Last two changes should fix this: > > > Not yet -- this may be unrelated(?) but here is what I have > after installing the newest source package: > > Error: Couldn't load required plugin /usr/local/lib/dovecot/lib90_sieve_plugin.so: > dlopen() failed: /usr/local/lib/dovecot/lib90_sieve_plugin.so: undefined symbol: > mail_deliver_ctx_get_log_var_expand_table

...ing for this. > Sorrys. I decided to "make clean" and do new "./configure" "make" and "make > install" for dovecot first, then pigeonhole to make sure nothing is off. After > I do that I get same original error: > > dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected > > I went to go verifying in dovecot-pigeonhole that the two new patches are there > by manual inspect the source files you patched. I found only the first one, not > http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/1eb0362461f0 maybe this > because I download...

This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> --- net/vmw_vsock/virtio_transport_common.c | 50 +++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 3 deletions...

This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> --- net/vmw_vsock/virtio_transport_common.c | 50 +++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 3 deletions...

This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> --- net/vmw_vsock/virtio_transport_common.c | 55 +++++++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 3 deletions...

...ything else of interesting for this. Sorrys. I decided to "make clean" and do new "./configure" "make" and "make install" for dovecot first, then pigeonhole to make sure nothing is off. After I do that I get same original error: dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected I went to go verifying in dovecot-pigeonhole that the two new patches are there by manual inspect the source files you patched. I found only the first one, not http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/1eb0362461f0 maybe this because I downloaded a snap shot link at t...

...ecot socket. Log shows only this dovecot: lmtp(test at example.com): Debug: wdi0Tb5VPlGfPnEAM/SpMA: sieve: action execute: running program: test dovecot: lmtp(test at example.com): Debug: Namespace : Using permissions from /vmail/example.com/test: mode=0770 gid=default dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected For testing I opened up the script and socket with permissions 777 but the error seems to indicate less about permissions more about some kind of protocol problem i guessing. Sieve script calls using this: execute "test"; Plugin config: plugin { sieve_plugins...

...2015 om 9:40: > Sorrys. I decided to "make clean" and do new "./configure" "make" and "make > install" for dovecot first, then pigeonhole to make sure nothing is off. After > I do that I get same original error: > > dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected > > I went to go verifying in dovecot-pigeonhole that the two new patches are there > by manual inspect the source files you patched. I found only the first one, not > http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/1eb0362461f0 maybe this > because I download...

...t;> >> dovecot: lmtp(test at example.com): Debug: wdi0Tb5VPlGfPnEAM/SpMA: sieve: action execute: running program: test >> dovecot: lmtp(test at example.com): Debug: Namespace : Using permissions from /vmail/example.com/test: mode=0770 gid=default >> dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected >> >> For testing I opened up the script and socket with >> permissions 777 but the error seems to indicate >> less about permissions more about some kind of >> protocol problem i guessing. > No one can help? Is anybody using the Sieve extprogr...

On 9/26/19 11:23 AM, Matias Ezequiel Vara Larsen wrote: > This patch adds support for MSG_PEEK. In such a case, packets are not > removed from the rx_queue and credit updates are not sent. > > Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> > --- > net/vmw_vsock/virtio_transport_common.c | 50 +++++++++++++++++++++++++++++++-- > 1 file changed,...

...ows only this > > dovecot: lmtp(test at example.com): Debug: wdi0Tb5VPlGfPnEAM/SpMA: sieve: action execute: running program: test > dovecot: lmtp(test at example.com): Debug: Namespace : Using permissions from /vmail/example.com/test: mode=0770 gid=default > dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected > > For testing I opened up the script and socket with > permissions 777 but the error seems to indicate > less about permissions more about some kind of > protocol problem i guessing. No one can help? Is anybody using the Sieve extprograms execute via Dovecot...

...t;> >> dovecot: lmtp(test at example.com): Debug: wdi0Tb5VPlGfPnEAM/SpMA: sieve: action execute: running program: test >> dovecot: lmtp(test at example.com): Debug: Namespace : Using permissions from /vmail/example.com/test: mode=0770 gid=default >> dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected >> >> For testing I opened up the script and socket with >> permissions 777 but the error seems to indicate >> less about permissions more about some kind of >> protocol problem i guessing. > No one can help? Is anybody using the Sieve extprogr...

...;> dovecot: lmtp(test at example.com): Debug: wdi0Tb5VPlGfPnEAM/SpMA: sieve: action execute: running program: test > >> dovecot: lmtp(test at example.com): Debug: Namespace : Using permissions from /vmail/example.com/test: mode=0770 gid=default > >> dovecot: script: Fatal: recv(MSG_PEEK) failed: disconnected > >> > >> For testing I opened up the script and socket with > >> permissions 777 but the error seems to indicate > >> less about permissions more about some kind of > >> protocol problem i guessing. > > No one can help? Is an...

...nl/dovecot-2.2-pigeonhole/rev/1eb0362461f0 maybe this > > because I downloaded a snap shot link at the top that wasn't built with the > > 2nd change? > > > > I put 2nd change in manually (its only one liner) rebuilded and after install..... > > same error with recv(MSG_PEEK) > > > > Thanks for ongoing help > > Argh! Ok, that fix was a bit incomplete still: > > http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/89e0cef5b264 Sorry I over-looking this. I just tested with this new fix. IT WORKS. > I wonder why my test didn't fail. > &...

On Thu, Sep 26, 2019 at 12:33:36PM -0700, Eric Dumazet wrote: > > > On 9/26/19 11:23 AM, Matias Ezequiel Vara Larsen wrote: > > This patch adds support for MSG_PEEK. In such a case, packets are not > > removed from the rx_queue and credit updates are not sent. > > > > Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> > > --- > > net/vmw_vsock/virtio_transport_common.c | 50 ++++++++++++++++++++++++++++++...

On Thu, Sep 26, 2019 at 12:33:36PM -0700, Eric Dumazet wrote: > > > On 9/26/19 11:23 AM, Matias Ezequiel Vara Larsen wrote: > > This patch adds support for MSG_PEEK. In such a case, packets are not > > removed from the rx_queue and credit updates are not sent. > > > > Signed-off-by: Matias Ezequiel Vara Larsen <matiasevara at gmail.com> > > --- > > net/vmw_vsock/virtio_transport_common.c | 50 ++++++++++++++++++++++++++++++...

On 9/27/19 1:55 AM, Stefano Garzarella wrote: > Good catch! > > Maybe we can solve in this way: > > list_for_each_entry(pkt, &vvs->rx_queue, list) { > size_t off = pkt->off; > > if (total == len) > break; > > while (total < len && off < pkt->len) { > /* using 'off' instead of 'pkt->off' */ >

...REAM socket semantics (send/recv, connect/accept, half-closed connections, simultaneous connections). The v1 of this series was originally sent by Stefan. v3: - Patch 6: * check the byte received in the recv_byte() * use send(2)/recv(2) instead of write(2)/read(2) to test also flags (e.g. MSG_PEEK) - Patch 8: * removed unnecessary control_expectln("CLOSED") [Stefan]. - removed patches 9,10,11 added in the v2 - new Patch 9 add parameters to list and skip tests (e.g. useful for vmci that doesn't support half-closed socket in the host) - new Patch 10 prints a list of options i...