search for: msg1944041

...ate: Thu Sep 11 16:47:04 2014 +0800 kvm: ioapic: conditionally delay irq delivery duringeoi broadcast But we still should do the shutdown right. I also propose to not shutdown msix from pci core shutdown if the device doesn't have shutdown function: http://www.spinics.net/lists/kernel/msg1944041.html With that patch is applied, the "nop" .shutdown in virtio-pci shouldn't hurt much. Regarding handing the requests, now I don't know if we really care about them at shutdown. As you said, waiting for requests may cause more hang. Ideas? Fam

...ate: Thu Sep 11 16:47:04 2014 +0800 kvm: ioapic: conditionally delay irq delivery duringeoi broadcast But we still should do the shutdown right. I also propose to not shutdown msix from pci core shutdown if the device doesn't have shutdown function: http://www.spinics.net/lists/kernel/msg1944041.html With that patch is applied, the "nop" .shutdown in virtio-pci shouldn't hurt much. Regarding handing the requests, now I don't know if we really care about them at shutdown. As you said, waiting for requests may cause more hang. Ideas? Fam

On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > Currently shutdown is nop for virtio devices, but the core code could > > remove things behind us such as MSI-X handler etc. For example in the > > case of virtio-scsi-pci, the device may still try to send interupts, > > which will be on IRQ lines seeing MSI-X

On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > Currently shutdown is nop for virtio devices, but the core code could > > remove things behind us such as MSI-X handler etc. For example in the > > case of virtio-scsi-pci, the device may still try to send interupts, > > which will be on IRQ lines seeing MSI-X