search for: mp_statvf

...e target free space - * estimation both require statvfs information from mountpoints, so - * get that information first. - *) - let mpstats = List.map ( - fun (dev, path) -> - let statvfs = g#statvfs path in - let vfs = g#vfs_type dev in - { mp_dev = dev; mp_path = path; mp_statvfs = statvfs; mp_vfs = vfs } - ) (g#mountpoints ()) in - - if verbose () then ( - (* This is useful for debugging speed / fstrim issues. *) - printf "mpstats:\n"; - List.iter (print_mpstat Pervasives.stdout) mpstats - ); - - (* Check there is enough free space to perform conver...

...; + (* We may install some packages, and they would usually go + * on the root filesystem. + *) + 20_000_000L + | _ -> + (* For everything else, just make sure there is some free space. *) + 10_000_000L + in + List.iter ( - fun { mp_path = mp; - mp_statvfs = { G.bfree; blocks; bsize } } -> - (* Ignore small filesystems. *) - let total_size = blocks *^ bsize in - if total_size > 100_000_000L then ( - (* bfree = free blocks for root user *) - let free_bytes = bfree *^ bsize in - let needed_bytes = - m...

...pstats = message (f_"Checking for sufficient free disk space in the guest"); @@ -399,14 +401,21 @@ and check_guest_free_space mpstats = 10_000_000L in + (* Reasonable headroom for conversion operations. *) + let needed_inodes = 100L in + List.iter ( - fun { mp_path; mp_statvfs = { G.bfree; bsize } } -> + fun { mp_path; mp_statvfs = { G.bfree; bsize; files; ffree } } -> (* bfree = free blocks for root user *) let free_bytes = bfree *^ bsize in let needed_bytes = needed_bytes_for_mp mp_path in if free_bytes < needed_bytes then...

...pstats = message (f_"Checking for sufficient free disk space in the guest"); @@ -399,14 +401,21 @@ and check_guest_free_space mpstats = 10_000_000L in + (* Reasonable headroom for conversion operations. *) + let needed_inodes = 100L in + List.iter ( - fun { mp_path; mp_statvfs = { G.bfree; bsize } } -> + fun { mp_path; mp_statvfs = { G.bfree; bsize; files; ffree } } -> (* bfree = free blocks for root user *) let free_bytes = bfree *^ bsize in let needed_bytes = needed_bytes_for_mp mp_path in if free_bytes < needed_bytes then...

...d usually go > + * on the root filesystem. > + *) > + 20_000_000L > + | _ -> > + (* For everything else, just make sure there is some free space. *) > + 10_000_000L > + in > + > List.iter ( > - fun { mp_path = mp; > - mp_statvfs = { G.bfree; blocks; bsize } } -> > - (* Ignore small filesystems. *) > - let total_size = blocks *^ bsize in > - if total_size > 100_000_000L then ( > - (* bfree = free blocks for root user *) > - let free_bytes = bfree *^ bsize in > - l...

This series is a second attempt to add a mode of virt-v2v operation where it leaves the config and disk image conversion, rollback on errors, registering with the destination hypervisor, etc. to a third-party toolset, and performs only tuning of the guest OS to run in the KVM-based hypervisor. The first 14 patches are just refactoring and rearrangement of the code, factoring the implementation

...in diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 74ba66a3d..355e55440 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -413,7 +413,7 @@ and check_guest_free_space mpstats = message (f_"Checking for sufficient free disk space in the guest"); List.iter ( fun { mp_path = mp; - mp_statvfs = { G.bfree = bfree; blocks = blocks; bsize = bsize } } -> + mp_statvfs = { G.bfree; blocks; bsize } } -> (* Ignore small filesystems. *) let total_size = blocks *^ bsize in if total_size > 100_000_000L then ( -- 2.13.2

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

...verbose () then printf "%s\n%!" cmd; + debug "%s" cmd; if Sys.command cmd <> 0 then error (f_"qemu-img command failed, see earlier errors"); @@ -453,16 +452,14 @@ and estimate_target_size mpstats targets = sum ( List.map (fun { mp_statvfs = s } -> s.G.blocks *^ s.G.bsize) mpstats ) in - if verbose () then - printf "estimate_target_size: fs_total_size = %Ld [%s]\n%!" - fs_total_size (human_size fs_total_size); + debug "estimate_target_size: fs_total_size = %Ld [%s]" + fs_total_size (human...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

..."Inspecting the overlay"); - let inspect = inspect_source ~verbose g root_choice in + let inspect = inspect_source g root_choice in (* Does the guest require UEFI on the target? *) let target_firmware = @@ -252,7 +252,7 @@ let rec main () = { mp_dev = dev; mp_path = path; mp_statvfs = statvfs; mp_vfs = vfs } ) (g#mountpoints ()) in - if verbose then ( + if verbose () then ( (* This is useful for debugging speed / fstrim issues. *) printf "mpstats:\n"; List.iter (print_mpstat Pervasives.stdout) mpstats @@ -264,7 +264,7 @@ let rec main () =...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623