search for: mp_path

...case --- v2v/v2v.ml | 55 ++++++++++++++++++++++++++++--------------------------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index b4c41e188..24b38458f 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -415,34 +415,35 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; *) and check_guest_free_space mpstats = message (f_"Checking for sufficient free disk space in the guest"); + + (* Check whether /boot has its own mount point. *) + let has_boot = List.exists (fun { mp_path } -> mp_path = "/boot") mpstats in + + let needed_by...

...100 available inodes. + =head3 Minimum free space check in the host You must have sufficient free space in the host directory used to diff --git a/v2v/v2v.ml b/v2v/v2v.ml index f9d81460..dc1dedd7 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -375,6 +375,8 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; (* Conversion can fail if there is no space on the guest filesystems * (RHBZ#1139543). To avoid this situation, check there is some * headroom. Mainly we care about the root filesystem. + * + * Also make sure filesystems have available inodes. (RHBZ#1764569) *) and check_guest_fre...

...inodes on filesystems that can provide inode counts. --- v2v/v2v.ml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 03590c9e..b5b2da08 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -375,6 +375,8 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; (* Conversion can fail if there is no space on the guest filesystems * (RHBZ#1139543). To avoid this situation, check there is some * headroom. Mainly we care about the root filesystem. + * + * Also make sure filesystems have available inodes. (RHBZ#1764569) *) and check_guest_fre...

...++++++++++++++++++++--------------------------- > 1 file changed, 28 insertions(+), 27 deletions(-) > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > index b4c41e188..24b38458f 100644 > --- a/v2v/v2v.ml > +++ b/v2v/v2v.ml > @@ -415,34 +415,35 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; > *) > and check_guest_free_space mpstats = > message (f_"Checking for sufficient free disk space in the guest"); > + > + (* Check whether /boot has its own mount point. *) > + let has_boot = List.exists (fun { mp_path } -> mp_path = "/boot")...

...ace check and the target free space - * estimation both require statvfs information from mountpoints, so - * get that information first. - *) - let mpstats = List.map ( - fun (dev, path) -> - let statvfs = g#statvfs path in - let vfs = g#vfs_type dev in - { mp_dev = dev; mp_path = path; mp_statvfs = statvfs; mp_vfs = vfs } - ) (g#mountpoints ()) in - - if verbose () then ( - (* This is useful for debugging speed / fstrim issues. *) - printf "mpstats:\n"; - List.iter (print_mpstat Pervasives.stdout) mpstats - ); - - (* Check there is enough free space...

...m> --- v2v/v2v.ml | 71 +++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 38 insertions(+), 33 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 9cb4a27..a2cf249 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -43,21 +43,7 @@ let print_mpstat chan { mp_dev = dev; mp_path = path; let () = Random.self_init () -let rec main () = - (* Handle the command line. *) - let input, output, - debug_gc, debug_overlays, do_copy, network_map, no_trim, - output_alloc, output_format, output_name, print_source, root_choice = - Cmdline.parse_cmdline () in - - (* Prin...

...timate then ( + print_source_disk_size_estimate cmdline g; + exit 0 + ); + (* Inspection - this also mounts up the filesystems. *) (match conversion_mode with | Copying _ -> message (f_"Inspecting the overlay") @@ -371,6 +377,48 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; fprintf chan " bsize=%Ld blocks=%Ld bfree=%Ld bavail=%Ld\n" s.Guestfs.bsize s.Guestfs.blocks s.Guestfs.bfree s.Guestfs.bavail +(* Print the estimated size of the source disk(s). + * + * These are somewhat related to mpstats above, except that + * we must also collect in...

...en ( + print_copy_size_estimate cmdline overlays; + exit 0 + ); + message (f_"Assigning disks to buses"); let target_buses = Target_bus_assignment.target_bus_assignment source guestcaps in @@ -371,6 +377,26 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; fprintf chan " bsize=%Ld blocks=%Ld bfree=%Ld bavail=%Ld\n" s.Guestfs.bsize s.Guestfs.blocks s.Guestfs.bfree s.Guestfs.bavail +(* Print the estimated size that will be copied for each disk. *) +and print_copy_size_estimate cmdline overlays = + let json = cmdline.machin...

This series is a second attempt to add a mode of virt-v2v operation where it leaves the config and disk image conversion, rollback on errors, registering with the destination hypervisor, etc. to a third-party toolset, and performs only tuning of the guest OS to run in the KVM-based hypervisor. The first 14 patches are just refactoring and rearrangement of the code, factoring the implementation

...k_size_estimate cmdline g; > + exit 0 > + ); > + > (* Inspection - this also mounts up the filesystems. *) > (match conversion_mode with > | Copying _ -> message (f_"Inspecting the overlay") > @@ -371,6 +377,48 @@ and print_mpstat chan { mp_dev = dev; mp_path = path; > fprintf chan " bsize=%Ld blocks=%Ld bfree=%Ld bavail=%Ld\n" > s.Guestfs.bsize s.Guestfs.blocks s.Guestfs.bfree s.Guestfs.bavail > > +(* Print the estimated size of the source disk(s). > + * > + * These are somewhat related to mpstats above, except that...

..._trim, + debug_overlays, do_copy, in_place, network_map, no_trim, output_alloc, output_format, output_name, print_source, root_choice diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 23bd708..26a9b64 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -41,12 +41,16 @@ let print_mpstat chan { mp_dev = dev; mp_path = path; fprintf chan " bsize=%Ld blocks=%Ld bfree=%Ld bavail=%Ld\n" s.G.bsize s.G.blocks s.G.bfree s.G.bavail +type conversion_mode = + | Copying of overlay list * target list + | In_place + let () = Random.self_init () let rec main () = (* Handle the command line....

This series is an attempt to add a mode of virt-v2v operation where it leaves the config and disk image conversion, rollback on errors, registering with the destination hypervisor, etc. to a third-party toolset, and performs only tuning of the guest OS to run in the KVM-based hypervisor. Roman Kagan (3): v2v: add --in-place mode v2v: document --in-place v2v: add test for --in-place ---

...t else loop rest in diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 74ba66a3d..355e55440 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -413,7 +413,7 @@ and check_guest_free_space mpstats = message (f_"Checking for sufficient free disk space in the guest"); List.iter ( fun { mp_path = mp; - mp_statvfs = { G.bfree = bfree; blocks = blocks; bsize = bsize } } -> + mp_statvfs = { G.bfree; blocks; bsize } } -> (* Ignore small filesystems. *) let total_size = blocks *^ bsize in if total_size > 100_000_000L then ( -- 2.13.2

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

...s. *) msg (f_"Inspecting the overlay"); - let inspect = inspect_source ~verbose g root_choice in + let inspect = inspect_source g root_choice in (* Does the guest require UEFI on the target? *) let target_firmware = @@ -252,7 +252,7 @@ let rec main () = { mp_dev = dev; mp_path = path; mp_statvfs = statvfs; mp_vfs = vfs } ) (g#mountpoints ()) in - if verbose then ( + if verbose () then ( (* This is useful for debugging speed / fstrim issues. *) printf "mpstats:\n"; List.iter (print_mpstat Pervasives.stdout) mpstats @@ -264,7 +264,7 @@ let r...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623