search for: mount_local_getattr

...filler, if (ss->val[i].ino >= 0) { struct stat statbuf; + memset (&statbuf, 0, sizeof statbuf); statbuf.st_dev = ss->val[i].dev; statbuf.st_ino = ss->val[i].ino; statbuf.st_mode = ss->val[i].mode; @@ -255,6 +256,7 @@ mount_local_getattr (const char *path, struct stat *statbuf) if (r == NULL) RETURN_ERRNO; + memset (statbuf, 0, sizeof *statbuf); statbuf->st_dev = r->dev; statbuf->st_ino = r->ino; statbuf->st_mode = r->mode; -- 1.8.3.1

...r FUSE wants to flush the + * pending changes (f.ex. to attributes) to a file. Since we don't have + * anything to do and don't want FUSE to think something went badly, + * just return 0. + */ + return 0; +} + static struct fuse_operations mount_local_operations = { .getattr = mount_local_getattr, .access = mount_local_access, @@ -902,6 +916,7 @@ static struct fuse_operations mount_local_operations = { .getxattr = mount_local_getxattr, .listxattr = mount_local_listxattr, .removexattr = mount_local_removexattr, + .flush = mount_local_flush, }; int -- 1.8.3.1

Previously if you were root, and you tried to change directory into a directory which was not owned by you and not readable (eg. 0700 bin:bin), it would fail. This doesn't fail on regular directories because when you are root the kernel just ignores permissions. Although libguestfs in general tries not to duplicate kernel code, in the case where we emulate the FUSE access(2) system call,

On Mon, Jun 26, 2017 at 10:27:54AM +0300, Maxim Kozover wrote: > I'd like to ask you, please, about multithreading with libguestfs. > I'm using libguestfs 1.36.4 with Perl front-end. > > Should it be possible to have the same libguestfs appliance provide both > fuse interface and periodically perform some longer APIs like find0? > > I mean make one Perl thread do

...s from https://www.redhat.com/archives/libguestfs/2017-June/ > msg00287.html and rebuilt. ... OK. > The system seems to work (with single-threaded fuse). > Changed fuse_loop to fuse_loop_mt, rebuilt and fuse is stuck on the first > call to appropriate fuse "system call" like mount_local_getattr in case of > ls. > It is stuck at guestfs_lstatns possibly at ACQUIRE_LOCK_FOR_CURRENT_SCOPE, > while being called from fuse. Can you get a stack trace from gdb. Use the command ‘t a a bt’ to show stacks from all threads at the same time. > What do you think could be a problem? Some...

...hives/libguestfs/2017-June/ > > msg00287.html and rebuilt. > > ... OK. > > > The system seems to work (with single-threaded fuse). > > Changed fuse_loop to fuse_loop_mt, rebuilt and fuse is stuck on the first > > call to appropriate fuse "system call" like mount_local_getattr in case > of > > ls. > > It is stuck at guestfs_lstatns possibly at ACQUIRE_LOCK_FOR_CURRENT_ > SCOPE, > > while being called from fuse. > > Can you get a stack trace from gdb. Use the command ‘t a a bt’ to > show stacks from all threads at the same time. > >...

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that

This changes the proposed API slightly. Previously 'mount-local' generating a 'mounted' event when the filesystem was ready, and from the 'mounted' event you had to effectively do a fork. Now, 'mount-local' just initializes the mountpoint and you have to call 'mount-local-run' to enter the FUSE main loop. Between these calls you can do a fork or whatever

...mtime_nsec; +#endif + statbuf.st_ctime = ss->val[i].st_ctime_sec; +#ifdef HAVE_STRUCT_STAT_ST_CTIM_TV_NSEC + statbuf.st_ctim.tv_nsec = ss->val[i].st_ctime_nsec; +#endif lsc_insert (g, path, names[i], now, &statbuf); } @@ -246,7 +255,7 @@ static int mount_local_getattr (const char *path, struct stat *statbuf) { const struct stat *buf; - CLEANUP_FREE_STAT struct guestfs_stat *r = NULL; + CLEANUP_FREE_STAT struct guestfs_statns *r = NULL; DECL_G (); DEBUG_CALL ("%s, %p", path, statbuf); @@ -256,24 +265,33 @@ mount_local_getattr (const char *...