search for: moduleanalysismanagerloopproxy

On 3/14/19 2:04 AM, Hiroshi Yamauchi wrote: > > > On Wed, Mar 13, 2019 at 2:37 PM Fedor Sergeev <fedor.sergeev at azul.com > <mailto:fedor.sergeev at azul.com>> wrote: > >> >> - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass >> to be able to get to the ModuleAnalysisManager in one step and >> PSI through it. > This is just an optimization of compile-time, saves one > indirection through FunctionAnalysisManager. > I'm not even sure if it is worth the effort. A...

...manager, implement a similar approach by using LazyBlockFrequencyInfo.) There is already an optional analysis in LoopStandardAnalysisResults - MemorySSA. We can do the same for BFI/BPI. And, yes - preserving those through loop passes is a cornerstone to this approach. > > - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass to be > able to get to the ModuleAnalysisManager in one step and PSI through it. This is just an optimization of compile-time, saves one indirection through FunctionAnalysisManager. I'm not even sure if it is worth the effort. And definitely not crucial for the overall ide...

...he CFG changes. We detect PGO based on the >>> command line flags and/or whether the module has the >>> profile summary info (we may need to pass the module to >>> more functions.) >>> >>> - Add a new proxy ModuleAnalysisManagerLoopProxy for a >>> loop pass to be able to get to the ModuleAnalysisManager >>> in one step and PSI through it. >>> >>> Alternative approaches >>> >>> Dropping BFI and use PSI only >>>...

...t before each loop pass that needs it. This doesn't seem avoidable because BFI can be invalidated whenever the CFG changes. We detect PGO based on the command line flags and/or whether the module has the profile summary info (we may need to pass the module to more functions.) - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass to be able to get to the ModuleAnalysisManager in one step and PSI through it. Alternative approaches Dropping BFI and use PSI only We could consider not using BFI and solely relying on PSI and function-level profiles only (as opposed to block-level), but profile precision would s...

...doesn't seem avoidable because BFI can >> be invalidated whenever the CFG changes. We detect PGO based on the command >> line flags and/or whether the module has the profile summary info (we >> may need to pass the module to more functions.) >> >> - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass to be >> able to get to the ModuleAnalysisManager in one step and PSI through it. >> >> Alternative approaches >> >> Dropping BFI and use PSI only >> We could consider not using BFI and solely relying on PSI and >> function-level profiles on...

...that needs it. This doesn't seem avoidable because BFI can > be invalidated whenever the CFG changes. We detect PGO based on the command > line flags and/or whether the module has the profile summary info (we may > need to pass the module to more functions.) > > - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass to be > able to get to the ModuleAnalysisManager in one step and PSI through it. > > Alternative approaches > > Dropping BFI and use PSI only > We could consider not using BFI and solely relying on PSI and > function-level profiles only (as opposed to block-leve...