search for: modmask

This patch fixes an undesirable behavior in the comparison of modifier bits necessary to initiate an action - if the modifier is not configured on the user's X server (thus having CompNoMask in its position in d->modMask), the comparison always behaves as though the modifier were pressed, due to CompNoMask falling outside the REAL_MOD_MASK & ~d->ignoredModMask bitmask. This causes actions to be invoked inappropriately (for instance, if the user has no keysyms assigned for the Super modifier, the zoom plugin...

...--- next part -------------- diff --git a/src/event.c b/src/event.c index 2d182be..b228dde 100644 --- a/src/event.c +++ b/src/event.c @@ -266,12 +266,18 @@ triggerButtonPressBindings (CompDisplay { if (action->button.button == event->xbutton.button) { - bindMods = virtualToRealModMask (d, action->button.modifiers); + /* if it has an edge mask set then make sure the mouse + is on that corner as well */ + if (!option->value.action.edgeMask || + (option->value.action.edgeMask & d->mouseOnEdge)) + { + bindMods = virtualToRealModMask (d, action->b...

...T_texture_from_pixmap #define GLX_BIND_TO_TEXTURE_RGB_EXT 0x20D0 -------------- next part -------------- diff --git a/src/event.c b/src/event.c index 5c4610d..b36468b 100644 --- a/src/event.c +++ b/src/event.c @@ -260,6 +260,7 @@ triggerButtonPressBindings (CompDisplay unsigned int modMask = REAL_MOD_MASK & ~d->ignoredModMask; unsigned int bindMods; + while (nOption--) { if (isInitiateBinding (option, CompBindingTypeButton, state, &action)) @@ -272,6 +273,15 @@ triggerButtonPressBindings (CompDisplay if ((*action->initiate) (d, action, stat...

...GB_EXT 0x20D0 > plain text document attachment (edgebutton-event.c.diff) > diff --git a/src/event.c b/src/event.c > index 5c4610d..b36468b 100644 > --- a/src/event.c > +++ b/src/event.c > @@ -260,6 +260,7 @@ triggerButtonPressBindings (CompDisplay > unsigned int modMask = REAL_MOD_MASK & ~d->ignoredModMask; > unsigned int bindMods; > > + > while (nOption--) > { > if (isInitiateBinding (option, CompBindingTypeButton, state, &action)) > @@ -272,6 +273,15 @@ triggerButtonPressBindings (CompDisplay >...