search for: mode_silk_only

Hello all, after FOMS I decided to take a look at the opus library and I found that I could improve a bit the build system and cleanup the code a little bit. Most of the changes to the code has been suggested by my two tools cowstats and missingstatic (part of the ruby-elf gem if you care). HTH, Diego

...higher than wideband for >20 ms frames, CELT-only for >20 ms and SILK-only for >60 ms */ + if ((frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY || st->bandwidth > OPUS_BANDWIDTH_WIDEBAND)) || + (frame_size > 3*st->Fs/50 && st->mode == MODE_SILK_ONLY)) At this point in the function st->mode is not yet finalized; it has only decided whether to use CELT-only mode. If st->mode == MODE_CELT_ONLY then it has decided to use CELT-only mode. Otherwise it has decided to use SILK-only or Hybrid mode, and will set st->mode to the correct mode...

...rames, >> CELT-only for >20 ms and SILK-only for >60 ms */ >> + if ((frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY || >> st->bandwidth > OPUS_BANDWIDTH_WIDEBAND)) || >> + (frame_size > 3*st->Fs/50 && st->mode == MODE_SILK_ONLY)) >> >> At this point in the function st->mode is not yet finalized; it has >> only decided whether to use CELT-only mode. If st->mode == >> MODE_CELT_ONLY then it has decided to use CELT-only mode. Otherwise >> it has decided to use SILK-only or Hybrid mode, a...

...or >20 ms and SILK-only for >60 ms */ > >>> + if ((frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY || > >>> st->bandwidth > OPUS_BANDWIDTH_WIDEBAND)) || > >>> + (frame_size > 3*st->Fs/50 && st->mode == MODE_SILK_ONLY)) > >>> > >>> At this point in the function st->mode is not yet finalized; it has > >>> only decided whether to use CELT-only mode. If st->mode == > >>> MODE_CELT_ONLY then it has decided to use CELT-only mode. Otherwise > >>> it h...

...for >20 ms frames, > CELT-only for >20 ms and SILK-only for >60 ms */ > + if ((frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY || > st->bandwidth > OPUS_BANDWIDTH_WIDEBAND)) || > + (frame_size > 3*st->Fs/50 && st->mode == MODE_SILK_ONLY)) > > At this point in the function st->mode is not yet finalized; it has > only decided whether to use CELT-only mode. If st->mode == > MODE_CELT_ONLY then it has decided to use CELT-only mode. Otherwise > it has decided to use SILK-only or Hybrid mode, and will set st->m...

...gt; CELT-only for >20 ms and SILK-only for >60 ms */ >>> + if ((frame_size > st->Fs/50 && (st->mode == MODE_CELT_ONLY || >>> st->bandwidth > OPUS_BANDWIDTH_WIDEBAND)) || >>> + (frame_size > 3*st->Fs/50 && st->mode == MODE_SILK_ONLY)) >>> >>> At this point in the function st->mode is not yet finalized; it has >>> only decided whether to use CELT-only mode. If st->mode == >>> MODE_CELT_ONLY then it has decided to use CELT-only mode. Otherwise >>> it has decided to use SILK-on...

Hi, I wondered if are there any further thoughts on these patches? Thanks, Felicia On Thu, Jun 2, 2016 at 2:13 PM Felicia Lim <flim at google.com> wrote: > OK, I've amended the second patch and also added 80 and 100 ms. > > Thanks, > Felicia > > > On Thu, Jun 2, 2016 at 7:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > >> On 06/01/2016 02:06

Just for fun, I tried to reproduce such an overflow. I turned on all debug macros, assertions, and checked arithmetic and then encoded 2 hours of mixed speech/audio with these parameters: Sample rate = 48000 Channels = 1 Application = OPUS_APPLICATION_AUDIO Bitrate = 24 KB/s Force Mode = MODE_SILK_ONLY Signal Type = OPUS_SIGNAL_AUTO Complexity = 10 Frame size = 480 samples (10ms) No errors came up in encoding. Chandrakala, are these the encoding parameters that you believe should trigger the error? - Logan Hi, > > We are looking at the VAD implementation used in opus. We are looking at &...

...Just for fun, I tried to reproduce such an overflow. I turned on all debug macros, assertions, and checked arithmetic and then encoded 2 hours of mixed speech/audio with these parameters: Sample rate = 48000 Channels = 1 Application = OPUS_APPLICATION_AUDIO Bitrate = 24 KB/s Force Mode = MODE_SILK_ONLY Signal Type = OPUS_SIGNAL_AUTO Complexity = 10 Frame size = 480 samples (10ms) No errors came up in encoding. Chandrakala, are these the encoding parameters that you believe should trigger the error? - Logan <blockquote> Hi, We are looking at the VAD implementation used in op...

Thank you Mark. I agree and have now updated the pull request with a new commit, addressing your comments. Please take a look. /Gustaf On Fri, 5 Apr 2019 at 11:41, Mark Harris <mark.hsj at gmail.com> wrote: > On 2019-04-01 3:37, Gustaf Ullberg wrote: > > Hi everyone, > > > > Some time ago, I sent a pull request > > <https://github.com/xiph/opus/pull/107>

..., since neither SILK not CELT stands alone in Opus. Simply feeding > the correct audio type should be sufficient. > > Oh, I see your previous message that you're benchmarking. You can import > opus_private.h and use opus_encoder_ctl(ctx,OPUS_SET_FORCE_MODE(mode)); > where mode is MODE_SILK_ONLY, MODE_CELT_ONLY, or MODE_HYBRID. Obviously, > don't do this in a real application! The numbers will be slightly different > due to bypassing the mode analyzer, so make sure to test the public API > primarily. > > > > > On 12/31/2015 5:17 PM, Amit Ashara wrote: > >...

...me size is reduced to less than 10 ms then it will have no choice but to switch to CELT immediately). If it ever switches back to SILK or Hybrid it will reset the SILK encoder state at that time, but until then the SILK encoder state may contain stale information. Checking that st->prev_mode is MODE_SILK_ONLY or MODE_HYBRID will verify that the SILK encoder state corresponds to the previous frame. - Mark

...s than > 10 ms then it will have no choice but to switch to CELT immediately). > If it ever switches back to SILK or Hybrid it will reset the SILK > encoder state at that time, but until then the SILK encoder state may > contain stale information. Checking that st->prev_mode is > MODE_SILK_ONLY or MODE_HYBRID will verify that the SILK encoder state > corresponds to the previous frame. > > - Mark > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20190410/cb01eda1/attachment.html> ----------...

...g macros, assertions, and checked arithmetic and then > encoded 2 hours of mixed speech/audio with these parameters: > > Sample rate = 48000 > Channels = 1 > Application = OPUS_APPLICATION_AUDIO > Bitrate = 24 KB/s > Force Mode = MODE_SILK_ONLY > Signal Type = OPUS_SIGNAL_AUTO > Complexity = 10 > Frame size = 480 samples (10ms) > > No errors came up in encoding. Chandrakala, are these the > encoding parameters that you believe should trigger the error? > > - Logan &...

...oduce such an overflow. I turned on all debug > macros, assertions, and checked arithmetic and then encoded 2 hours of > mixed speech/audio with these parameters: > > Sample rate = 48000 > Channels = 1 > Application = OPUS_APPLICATION_AUDIO > Bitrate = 24 KB/s > Force Mode = MODE_SILK_ONLY > Signal Type = OPUS_SIGNAL_AUTO > Complexity = 10 > Frame size = 480 samples (10ms) > > No errors came up in encoding. Chandrakala, are these the encoding > parameters that you believe should trigger the error? > > - Logan > > Hi, >> >> We are looking at t...

...on all >> debug macros, assertions, and checked arithmetic and then encoded 2 hours >> of mixed speech/audio with these parameters: >> >> Sample rate = 48000 >> Channels = 1 >> Application = OPUS_APPLICATION_AUDIO >> Bitrate = 24 KB/s >> Force Mode = MODE_SILK_ONLY >> Signal Type = OPUS_SIGNAL_AUTO >> Complexity = 10 >> Frame size = 480 samples (10ms) >> >> No errors came up in encoding. Chandrakala, are these the encoding >> parameters that you believe should trigger the error? >> >> - Logan >> >> H...