search for: mode_in_plac

...- string option +type cmdline = { + indisk : string; + format : string option; + ignores : string list; + machine_readable : bool; + zeroes : string list; + mode : mode_t; +} + +and mode_t = +| Mode_copying of + string * check_t * bool * string option * string option * string option | Mode_in_place and check_t = [`Ignore|`Continue|`Warn|`Fail] @@ -175,4 +184,10 @@ read the man page virt-sparsify(1). else Mode_in_place in - indisk, format, ignores, machine_readable, zeroes, mode + { indisk = indisk; + format = format; + ignores = ignores; + machine_readable = machi...

The first patch is just some simple refactoring. See the second patch for a description of the new virt-sparsify --tmp option. I tested this using a loopback device as my temporary block device, and it seems to work fine for me. Federico .. this needs a BZ :-) Rich.

...error (f_"you cannot use --in-place and --check-tmpdir options together"); @@ -175,15 +178,9 @@ read the man page virt-sparsify(1). if tmp <> None then error (f_"you cannot use --in-place and --tmp options together"); - indisk + indisk, Mode_in_place ) in - let mode = - if not in_place then - Mode_copying (outdisk, check_tmpdir, compress, convert, option, tmp) - else - Mode_in_place in - { indisk = indisk; format = format; ignores = ignores; -- 2.7.4

...t;" -> None | str -> Some str in - let debug_gc = !debug_gc in let format = match !format with "" -> None | str -> Some str in let ignores = List.rev !ignores in let in_place = !in_place in @@ -188,4 +186,4 @@ read the man page virt-sparsify(1). else Mode_in_place in - indisk, debug_gc, format, ignores, machine_readable, zeroes, mode + indisk, format, ignores, machine_readable, zeroes, mode diff --git a/sparsify/sparsify.ml b/sparsify/sparsify.ml index 1f631d8..30e3020 100644 --- a/sparsify/sparsify.ml +++ b/sparsify/sparsify.ml @@ -30,7 +30,7 @@ module...

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

...press, convert, option, tmp) -> Copying.run cmdline.indisk outdisk check_tmpdir compress convert - cmdline.format cmdline.ignores cmdline.machine_readable - option tmp cmdline.zeroes + cmdline.format cmdline.ignores option tmp cmdline.zeroes | Mode_in_place -> - In_place.run cmdline.indisk cmdline.format cmdline.ignores - cmdline.machine_readable cmdline.zeroes + In_place.run cmdline.indisk cmdline.format cmdline.ignores cmdline.zeroes ) let () = run_main_and_handle_errors main diff --git a/v2v/cmdline.ml b/v2v/cmdline....

Store the machine-readable flag globally, just like done for verbose/debug/etc, and enhance create_standard_options to provide --machine-readable automatically. --- common/mlstdutils/std_utils.ml | 4 ++++ common/mlstdutils/std_utils.mli | 7 +++++-- common/mltools/tools_utils.ml | 7 ++++++- common/mltools/tools_utils.mli | 5 ++++- 4 files changed, 19 insertions(+), 4 deletions(-) diff

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

...fy.ml @@ -36,8 +36,10 @@ let rec main () = | Mode_copying (outdisk, check_tmpdir, compress, convert, option, tmp) -> Copying.run cmdline.indisk outdisk check_tmpdir compress convert cmdline.format cmdline.ignores option tmp cmdline.zeroes + cmdline.ks | Mode_in_place -> In_place.run cmdline.indisk cmdline.format cmdline.ignores cmdline.zeroes + cmdline.ks ) let () = run_main_and_handle_errors main diff --git a/sparsify/virt-sparsify.pod b/sparsify/virt-sparsify.pod index f5e5d2395..8a074ec61 100644 --- a/sparsify/virt-sparsify.pod...

...let tmp = match !tmp with "" -> None | str -> Some str in - let verbose = !verbose in - let trace = !trace in let zeroes = List.rev !zeroes in (* No arguments and machine-readable mode? Print out some facts @@ -195,4 +191,4 @@ read the man page virt-sparsify(1). Mode_in_place in indisk, debug_gc, format, ignores, machine_readable, - quiet, verbose, trace, zeroes, mode + quiet, zeroes, mode diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 9f788b9..9f20fa3 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -39,7 +39,7 @@ type tmp_place =...

Hi, the following series adds a --key option in the majority of tools: this makes it possible to pass LUKS credentials programmatically, avoid the need to manually input them, or unsafely pass them via stdin. Thanks, Pino Toscano (2): mltools: create a cmdline_options struct Introduce a --key option in tools that accept keys builder/cmdline.ml | 2 +-

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623