search for: mode_in

...Priority: P5 Component: ssh Assignee: unassigned-bugs at mindrot.org Reporter: markus at blueflash.cc During initialization there a memory leak occurs in ssh_set_newkeys(). During startup ssh_set_newkeys() is called twice, once with MODE_OUT and once with MODE_IN. Accordingly the ccp pointer points to state->send_context and state->receive_context At this time state->newkeys[mode] is stil NULL, so the if-clause ("rekeying") does not apply. Further down cipher_init(ccp, ) is called. First thing that cipher_init() does is setting *ccp=...

...= buffer_get_binary(&m, &bloblen); current_keys[MODE_OUT] = mm_newkeys_from_blob(blob, bloblen); xfree(blob); debug3("%s: Waiting for second key", __func__); - blob = buffer_get_string(&m, &bloblen); + blob = buffer_get_binary(&m, &bloblen); current_keys[MODE_IN] = mm_newkeys_from_blob(blob, bloblen); xfree(blob); @@ -1618,18 +1618,18 @@ skip: /* Get the key context */ - child_state.keyout = buffer_get_string(&m, &child_state.keyoutlen); - child_state.keyin = buffer_get_string(&m, &child_state.keyinlen); + child_state.keyout = bu...