search for: mo_plt

Hi Anton and JF, Thanks for your review. After reading the source code more carefully, I have come up with a different way fix this issue. We can simply resolve this issue by adding ARMII::MO_PLT flags with MachineInstrBuilder in FastISel pass (without failing back to DAG lowering). The new patch is attached, and the test case is not changed. Sorry for your inconvenience. Please have a look. Thanks for your help. Sincerely, Logan On Wed, Aug 21, 2013 at 10:52 PM, JF Bastien <jfb...

For ARM targets on linux, revision 183966 made Fast ISel default. Unfortunately, Fast ISel is broken in terms of applying the ARMII::MO_PLT flags to calls in PIC mode (at least when emitting assembly); it never does this. The normal ISel pass handles this situation correctly so a temporary local change to disable FastISel for linux / NaCl targets is working for me right now. I'm not very familiar with the ISel passes. I'm...

...Aug 21, 2013 at 8:04 AM, Logan Chien <tzuhsiang.chien at gmail.com>wrote: > Hi Anton and JF, > > Thanks for your review. After reading the source code more carefully, I > have come up with a different way fix this issue. We can simply resolve > this issue by adding ARMII::MO_PLT flags with MachineInstrBuilder in > FastISel pass (without failing back to DAG lowering). > > The new patch is attached, and the test case is not changed. Sorry for > your inconvenience. Please have a look. Thanks for your help. > > Sincerely, > Logan > > > On Wed...

...:04 AM, Logan Chien <tzuhsiang.chien at gmail.com<mailto:tzuhsiang.chien at gmail.com>> wrote: Hi Anton and JF, Thanks for your review. After reading the source code more carefully, I have come up with a different way fix this issue. We can simply resolve this issue by adding ARMII::MO_PLT flags with MachineInstrBuilder in FastISel pass (without failing back to DAG lowering). The new patch is attached, and the test case is not changed. Sorry for your inconvenience. Please have a look. Thanks for your help. Sincerely, Logan On Wed, Aug 21, 2013 at 10:52 PM, JF Bastien <jfb...

...gt;> > On Tue, Aug 20, 2013 at 6:10 PM, Gordon Keiser <gkeiser at arxan.com> >> > wrote: >> > > For ARM targets on linux, revision 183966 made Fast ISel default. >> > > Unfortunately, Fast ISel is broken in terms of applying the >> > > ARMII::MO_PLT flags to calls in PIC mode (at least when emitting >> > > assembly); it never does this. The normal ISel pass handles this >> > > situation correctly so a temporary local change to disable FastISel >> > > for linux / NaCl targets is working for me right now. &g...

...Aug 20, 2013 at 6:10 PM, Gordon Keiser <gkeiser at arxan.com> > >> > wrote: > >> > > For ARM targets on linux, revision 183966 made Fast ISel default. > >> > > Unfortunately, Fast ISel is broken in terms of applying the > >> > > ARMII::MO_PLT flags to calls in PIC mode (at least when emitting > >> > > assembly); it never does this. The normal ISel pass handles this > >> > > situation correctly so a temporary local change to disable FastISel > >> > > for linux / NaCl targets is working for m...

.... > > Thanks! > > -eric > > On Tue, Aug 20, 2013 at 6:10 PM, Gordon Keiser <gkeiser at arxan.com> > wrote: > > For ARM targets on linux, revision 183966 made Fast ISel default. > > Unfortunately, Fast ISel is broken in terms of applying the > > ARMII::MO_PLT flags to calls in PIC mode (at least when emitting > > assembly); it never does this. The normal ISel pass handles this > > situation correctly so a temporary local change to disable FastISel > > for linux / NaCl targets is working for me right now. > > > > > >...

...a good start, go ahead and cc me and jfb at google.com. Thanks! -eric On Tue, Aug 20, 2013 at 6:10 PM, Gordon Keiser <gkeiser at arxan.com> wrote: > For ARM targets on linux, revision 183966 made Fast ISel default. > Unfortunately, Fast ISel is broken in terms of applying the ARMII::MO_PLT > flags to calls in PIC mode (at least when emitting assembly); it never does > this. The normal ISel pass handles this situation correctly so a temporary > local change to disable FastISel for linux / NaCl targets is working for me > right now. > > > > I’m not very famil...

...t; -eric > > > > On Tue, Aug 20, 2013 at 6:10 PM, Gordon Keiser <gkeiser at arxan.com> > > wrote: > > > For ARM targets on linux, revision 183966 made Fast ISel default. > > > Unfortunately, Fast ISel is broken in terms of applying the > > > ARMII::MO_PLT flags to calls in PIC mode (at least when emitting > > > assembly); it never does this. The normal ISel pass handles this > > > situation correctly so a temporary local change to disable FastISel > > > for linux / NaCl targets is working for me right now. > > >...

H all, I'm looking at generating PIC code for RISC-V in the context of Linux. Not sure if anyone is working on this already, any inputs are very welcome. I'm now looking at function calls which in the RISCV backend are represented via two pseudoinstructions RISCV::TAIL and RISCV::CALL. Currently those pseudos are lowered in MCCodeEmitter. They are expanded into AUIPC and JALR