search for: mnt_get_count

...layer. I guess something wrong when doing > a copy with linked SQEs (normal copy seems no problem). > I am inclined to agree with you. I also test liburing examples apps on ext4 partition, everything looks fine. I used below bpftrace method, the retval is '3'. bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') Thanks, Heming > > On 2/24/23 8:32 AM, Heming Zhao wrote: >> Hello List, >> >> I found a weird bug on ocfs2. I am busying with other jobs, if...

...doing >> a copy with linked SQEs (normal copy seems no problem). >> > > I am inclined to agree with you. I also test liburing examples apps > on ext4 partition, everything looks fine. > > I used below bpftrace method, the retval is '3'. > ?bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > > It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > Yes, that's the place return EBUSY. So the problem seems to be getmnt/putmnt not match in this case. Thanks, Joseph > >> >> On 2/2...

...linked SQEs (normal copy seems no problem). >>> >> >> I am inclined to agree with you. I also test liburing examples apps >> on ext4 partition, everything looks fine. >> >> I used below bpftrace method, the retval is '3'. >> ?bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >> >> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >> > Yes, that's the place return EBUSY. > So the problem seems to be getmnt/putmnt not match in this case. > I didn't familia...

...ms no problem). >>>> >>> >>> I am inclined to agree with you. I also test liburing examples apps >>> on ext4 partition, everything looks fine. >>> >>> I used below bpftrace method, the retval is '3'. >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>> >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>> >> Yes, that's the place return EBUSY. >> So the problem seems to be getmnt/putmnt not match in this case. >&gt...

...t;>> I am inclined to agree with you. I also test liburing examples apps >>>>>> on ext4 partition, everything looks fine. >>>>>> >>>>>> I used below bpftrace method, the retval is '3'. >>>>>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>>>>> >>>>>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>>>>> >>>>> Yes, that's the place return EBUSY. >>>>> So the probl...

...t; > >>> > >>> I am inclined to agree with you. I also test liburing examples apps > >>> on ext4 partition, everything looks fine. > >>> > >>> I used below bpftrace method, the retval is '3'. > >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > >>> > >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > >>> > >> Yes, that's the place return EBUSY. > >> So the problem seems to be getmnt/putmnt not ma...

...> >>> I am inclined to agree with you. I also test liburing examples apps > > >>> on ext4 partition, everything looks fine. > > >>> > > >>> I used below bpftrace method, the retval is '3'. > > >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > > >>> > > >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > > >>> > > >> Yes, that's the place return EBUSY. > > >> So the problem seems t...

...inclined to agree with you. I also test liburing examples apps >>>>>>> on ext4 partition, everything looks fine. >>>>>>> >>>>>>> I used below bpftrace method, the retval is '3'. >>>>>>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>>>>>> >>>>>>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>>>>>> >>>>>> Yes, that's the place return EBUSY. >>>>&...

I can reproduce this in my local VM. I've traced ocfs2_dismount_volume and found that it hasn't been called. So EBUSY is returned in VFS layer. I guess something wrong when doing a copy with linked SQEs (normal copy seems no problem). Thanks, Joseph On 2/24/23 8:32 AM, Heming Zhao wrote: > Hello List, > > I found a weird bug on ocfs2. I am busying with other jobs, if anyone

...on ocfs2. [1] Do the following steps can reproduce this BUG: mount -t ocfs2 /dev/vdc /mnt/ocfs2 cp testfile /mnt/ocfs2/ ./link-cp /mnt/ocfs2/testfile /mnt/ocfs2/testfile.1 umount /mnt/ocfs2 Then umount will fail, and it outputs: umount: /mnt/ocfs2: target is busy. While tracing umount, it blames mnt_get_count() not return as expected. Do a deep investigation for fget()/fput() on related code flow, I've finally found that fget() leaks since ocfs2 doesn't support nowait buffered read. io_issue_sqe |-io_assign_file // do fget() first |-io_read |-io_iter_do_read |-ocfs2_file_read_iter //...