search for: mnghuan

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk....

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk....

...d, if we can not allocate more memory in function init_vq. If host can support multiple virtual queues, and we fails to allocate necessary memory structures for vq, kernel may crash due to incorrect returning. To fix it, kernel will return correct value in init_vq. Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> --- drivers/block/virtio_blk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..40ecb2b 100644 --- a/drivers/block/virti...

...d, if we can not allocate more memory in function init_vq. If host can support multiple virtual queues, and we fails to allocate necessary memory structures for vq, kernel may crash due to incorrect returning. To fix it, kernel will return correct value in init_vq. Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> --- drivers/block/virtio_blk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..40ecb2b 100644 --- a/drivers/block/virti...

On 07/06/16 at 11:18P, Cornelia Huck wrote: > On Mon, 27 Jun 2016 10:09:18 +0800 > Minfei Huang <mnghuan at gmail.com> wrote: > > > The error number -ENOENT or 0 will be returned, if we can not allocate > > more memory in function init_vq. If host can support multiple virtual > > queues, and we fails to allocate necessary memory structures for vq, > > kernel may crash du...

On 07/06/16 at 11:18P, Cornelia Huck wrote: > On Mon, 27 Jun 2016 10:09:18 +0800 > Minfei Huang <mnghuan at gmail.com> wrote: > > > The error number -ENOENT or 0 will be returned, if we can not allocate > > more memory in function init_vq. If host can support multiple virtual > > queues, and we fails to allocate necessary memory structures for vq, > > kernel may crash du...

On Mon, 27 Jun 2016 10:09:18 +0800 Minfei Huang <mnghuan at gmail.com> wrote: > The error number -ENOENT or 0 will be returned, if we can not allocate > more memory in function init_vq. If host can support multiple virtual > queues, and we fails to allocate necessary memory structures for vq, > kernel may crash due to incorrect returning....

On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, > kernel will panic in guest machine, if virtio...

On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, > kernel will panic in guest machine, if virtio...

...tio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> --- v1: - Refactor the patch to make code more readable --- drivers/block/virtio_blk.c | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..d920512 100644 --- a...

...tio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> --- v1: - Refactor the patch to make code more readable --- drivers/block/virtio_blk.c | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..d920512 100644 --- a...

...t; To fix this bug, we should take care of allocation failure, and return > correct value to let caller know what happen. > > Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> > Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> > Signed-off-by: Minfei Huang <mnghuan at gmail.com> > --- > v1: > - Refactor the patch to make code more readable > --- > drivers/block/virtio_blk.c | 32 +++++++++++--------------------- > 1 file changed, 11 insertions(+), 21 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_b...

...memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 26 ++++++++------------------ 1 file changed, 8 insertions...

...memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 26 ++++++++------------------ 1 file changed, 8 insertions...

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20160718/3b4e899d/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-virtio_blk-Fix-a-slient-kernel-panic.patch Type: application/octet-stream Size: 2719 bytes Desc: not available

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20160718/3b4e899d/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-virtio_blk-Fix-a-slient-kernel-panic.patch Type: application/octet-stream Size: 2719 bytes Desc: not available