search for: mnfhuang

On 07/18/16 at 05:21P, Cornelia Huck wrote: > On Mon, 18 Jul 2016 22:01:29 +0800 > Minfei Huang <mnfhuang at gmail.com> wrote: > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 42758b5..d920512 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -381,9 +381,9 @@ static int init_vq(struct virtio_blk *vb...

On 07/18/16 at 05:21P, Cornelia Huck wrote: > On Mon, 18 Jul 2016 22:01:29 +0800 > Minfei Huang <mnfhuang at gmail.com> wrote: > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 42758b5..d920512 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -381,9 +381,9 @@ static int init_vq(struct virtio_blk *vb...

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return

On Tue, 19 Jul 2016 00:18:32 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > On 07/18/16 at 05:21P, Cornelia Huck wrote: > > On Mon, 18 Jul 2016 22:01:29 +0800 > > Minfei Huang <mnfhuang at gmail.com> wrote: > > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > > index 42758b5..d92051...

We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen.

We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen.

On Mon, 18 Jul 2016 22:01:29 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, > kernel will panic in guest machine, if virt...

On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At th...

On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that...