search for: mlaugea

...t shift of negative value". The issue actually lies in the OCaml headers (mlvalues.h in particular), and it was fixed in newer OCaml versions. Since the code is actually correct, disable -Wshift-negative-value with -Wno-shift-negative-value (checking whether the compiler has it). --- common/mlaugeas/Makefile.am | 2 +- m4/guestfs-c.m4 | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/common/mlaugeas/Makefile.am b/common/mlaugeas/Makefile.am index d71d0074d..0f3cea820 100644 --- a/common/mlaugeas/Makefile.am +++ b/common/mlaugeas/Makefile.am @@ -53,7 +53,7 @...

...re: http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical to the upstream version and should remain so. We can work towards using system ocaml-augeas, when it's more widely available. --- .gitignore | 1 + Makefile.am | 1 + common/mlaugeas/Makefile.am | 91 +++++++++++++ common/mlaugeas/augeas-c.c | 288 ++++++++++++++++++++++++++++++++++++++++++ common/mlaugeas/augeas.README | 8 ++ common/mlaugeas/augeas.ml | 59 +++++++++ common/mlaugeas/augeas.mli | 95 ++++++++++++++ configure.ac | 1 + daemo...

...lign/stamp-virt-alignment-scan.pod /align/virt-alignment-scan diff --git a/Makefile.am b/Makefile.am index 65106369e..0c52806bd 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,7 @@ SUBDIRS += lib docs examples # The daemon and the appliance. SUBDIRS += common/mlutils -SUBDIRS += common/mlaugeas +SUBDIRS += 3rdparty/ocaml-augeas SUBDIRS += common/mlpcre if ENABLE_DAEMON SUBDIRS += daemon @@ -316,7 +316,7 @@ ChangeLog: configure.ac docs/C_SOURCE_FILES: configure.ac rm -f $@ $@-t find $(DIST_SUBDIRS) -name '*.[ch]' | \ - grep -v -E '^(builder/index-parse\.|builder/index-...

This synchronizes the embedded ocaml-augeas copy, and reimplements the augeas APIs using it (dropping all the C code). The behaviour seems unchanged, although I may have not tested all the various corner cases. Pino Toscano (5): common/mlaugeas: Synchronize with latest ocaml-augeas daemon: fix/enhance error reporting of Augeas exceptions Revert "Revert "daemon: implement OptString for OCaml APIs"" daemon: move augeas APIs to OCaml daemon: drop usage of C augeas library .gitignore | 1 + co...

OCaml has a small runtime which is statically linked into the virt tools (providing things like GC and primitives). Since OCaml 4.03 it has been possible to select variants of this runtime, one of which is compiled with -fPIC, using ‘ocamlopt -runtime-variant _pic’. This has performance implications on i686, but is relatively free on other architectures. Since it (in theory) adds to the

Use also custom_compare_ext_default for the compare_ext field. According to the git logs, this was introduced in OCaml 3.12.1, which is earlier than out minimum required version. mlaugeas is not touched by this change, since it is a copy of a 3rd party library (and thus it will be fixed there first). --- common/mlpcre/pcre-c.c | 3 ++- common/mlprogress/progress-c.c | 3 ++- common/mlxml/xml-c.c | 9 ++++++--- ocaml/guestfs-c.c | 3 ++- v2v/qemuopts-...

Brought to you by the "I haven't rebuilt the libguestfs universe in a while" saga -- now with working test suite. Pino Toscano (5): build: remove extra gnulib submodule build: remove extra checks and submodules build: stop using gnulib in test-harness build: remove unused gnulib modules Remove extra entries from podfiles .gitmodules | 3 -- Makefile.am

...-dep.sh $^ -include .depend diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 9dbd375f5d..506c880297 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -318,11 +318,11 @@ XOBJECTS = $(BOBJECTS:.cmo=.cmx) OCAMLPACKAGES = \ -package str,unix,hivex \ - -I $(top_srcdir)/common/mlaugeas \ - -I $(top_srcdir)/common/mlstdutils \ - -I $(top_srcdir)/common/mlutils \ + -I $(top_builddir)/common/mlaugeas \ + -I $(top_builddir)/common/mlstdutils \ + -I $(top_builddir)/common/mlutils \ -I $(top_builddir)/common/utils/.libs \ - -I $(top_srcdir)/common/mlpcre \ + -I $(top_builddir)/commo...

Brought to you by the "I haven't rebuilt the libguestfs universe in a while" saga. Pino Toscano (5): build: remove extra gnulib submodule build: remove extra checks and submodules build: stop using gnulib in test-harness build: remove unused gnulib modules Remove extra entries from podfiles .gitmodules | 3 -- Makefile.am | 2 - bootstrap

ocaml-augeas is used only by virtlibguestfs, so move it to this repository, instead of having it around in the common submodule. The removal from common will happen later. Pino Toscano (2): Bundle the ocaml-augeas library for use by libguestfs build: switch embedded copy of ocaml-augeas .gitignore | 1 + 3rdparty/ocaml-augeas/COPYING.LIB | 515

...@@ SOURCES_ML = \ parted.ml \ listfs.ml \ realpath.ml \ + statvfs.ml \ inspect_types.ml \ inspect_utils.ml \ inspect_fs_unix_fstab.ml \ @@ -348,8 +349,10 @@ camldaemon.o: $(OBJECTS) $(OCAMLFIND) $(BEST) -output-obj -o $@ \ $(OCAMLFLAGS) $(OCAMLPACKAGES) \ -linkpkg \ - mlaugeas.$(MLARCHIVE) mlpcre.$(MLARCHIVE) \ - mlcutils.$(MLARCHIVE) mlstdutils.$(MLARCHIVE) \ + mlaugeas.$(MLARCHIVE) \ + mlpcre.$(MLARCHIVE) \ + mlstdutils.$(MLARCHIVE) \ + mlcutils.$(MLARCHIVE) \ $(OBJECTS) # OCaml dependencies. @@ -399,8 +402,8 @@ endif OCAMLLINKFLAGS = \...

...ml-dep.sh $^ -include .depend diff --git a/daemon/Makefile.am b/daemon/Makefile.am index c534baab0..94ee866a0 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -318,11 +318,11 @@ XOBJECTS = $(BOBJECTS:.cmo=.cmx) OCAMLPACKAGES = \ -package str,unix,hivex \ - -I $(top_srcdir)/common/mlaugeas \ - -I $(top_srcdir)/common/mlstdutils \ - -I $(top_srcdir)/common/mlutils \ + -I $(top_builddir)/common/mlaugeas \ + -I $(top_builddir)/common/mlstdutils \ + -I $(top_builddir)/common/mlutils \ -I $(top_builddir)/common/utils/.libs \ - -I $(top_srcdir)/common/mlpcre \ + -I $(top_builddir)/commo...

On Monday, 31 July 2017 17:40:51 CEST Richard W.M. Jones wrote: > This commit embeds the ocaml-augeas library (upstream here: > http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical > to the upstream version and should remain so. > > We can work towards using system ocaml-augeas, when it's more widely > available. > --- > daemon/Makefile.am |

...our control. It does mean that any time > there's a change to common/, we would need to add a commit to the > other 3 repos updating the submodule hash. The current common/ subdirectory is a giant mixup of different components needed by some or just one tool each; few examples: - common/mlaugeas -> only for the daemon - common/mllibvirt -> only for v2v - common/mlxml -> only for v2v - some of the ml modules are need by any OCaml stuff - some of the ml modules are used by 1/2 tools - etc -- Pino Toscano

...IRS += common/mllibvirt -endif SUBDIRS += customize SUBDIRS += builder builder/templates SUBDIRS += get-kernel diff --git a/configure.ac b/configure.ac index 7ec2c9b46..4d043dd02 100644 --- a/configure.ac +++ b/configure.ac @@ -235,14 +235,12 @@ AC_CONFIG_FILES([Makefile common/mlaugeas/Makefile common/mlcustomize/Makefile common/mlgettext/Makefile - common/mllibvirt/Makefile common/mlpcre/Makefile common/mlprogress/Makefile common/mlstdutils/Makefile common...

...t any time > > there's a change to common/, we would need to add a commit to the > > other 3 repos updating the submodule hash. > > The current common/ subdirectory is a giant mixup of different > components needed by some or just one tool each; few examples: > - common/mlaugeas -> only for the daemon > - common/mllibvirt -> only for v2v > - common/mlxml -> only for v2v > - some of the ml modules are need by any OCaml stuff > - some of the ml modules are used by 1/2 tools > - etc It's a step on the path rather than the end point. We can defin...

v2 -> v3: - Drop gnulib fallback.

It started out as "this'll be just a simple fix ..." and turned into something a bit over-engineered in the end. Here it is anyway. Rich.

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

...e's a change to common/, we would need to add a commit to the > > > other 3 repos updating the submodule hash. > > > > The current common/ subdirectory is a giant mixup of different > > components needed by some or just one tool each; few examples: > > - common/mlaugeas -> only for the daemon > > - common/mllibvirt -> only for v2v > > - common/mlxml -> only for v2v > > - some of the ml modules are need by any OCaml stuff > > - some of the ml modules are used by 1/2 tools > > - etc > > It's a step on the path rathe...