search for: mkdtemp

Add a simple function to ease the usage of Mkdtemp.mkdtemp. --- mllib/mkdtemp.ml | 5 +++++ mllib/mkdtemp.mli | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/mllib/mkdtemp.ml b/mllib/mkdtemp.ml index 2e64862..353b04b 100644 --- a/mllib/mkdtemp.ml +++ b/mllib/mkdtemp.ml @@ -16,4 +16,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA...

...08efa5d 100644 > --- a/builder/sigchecker.ml > +++ b/builder/sigchecker.ml > @@ -54,7 +54,7 @@ let import_keyfile ~gpg ~gpghome ~verbose keyfile = > > let rec create ~verbose ~gpg ~gpgkey ~check_signature = > (* Create a temporary directory for gnupg. *) > - let tmpdir = Mkdtemp.mkdtemp (Filename.temp_dir_name // "vb.gpghome.XXXXXX") in > + let tmpdir = Mkdtemp.temp_dir "vb.gpghome." "" in > rmdir_on_exit tmpdir; > (* Make sure we have no check_signature=true with no actual key. *) > let check_signature, gpgkey = > dif...

Much similar to unlink_on_exit, but recursively cleaning directories. --- mllib/common_utils.ml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index 3943417..f49ede6 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -386,6 +386,35 @@ let unlink_on_exit = registered_handlers := true )

...ays of renaming directories :) I do have a second machine but I have to juggle the disk partitions to make enough room so I have not been able to use that. Besides for some reason it did not want to build binutils-2.15 :( Okay it looks like the newer "uptodate" Cygwin has a problem with mkdtemp(). It looks like mkdtemp() exists in a library and is linkable, but there is no function prototype for it in the headers. The configuration system compiles a function :- /* Override any gcc2 internal prototype to avoid an error. */ | #ifdef __cplusplus | extern "C" | { | #endif | /* We...

...sumes a metric ton of other changes), but mostly a heads-up where I'm going. >From 62cbebffe9859046019b500e4bcdb0e44e575755 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 11 Aug 2009 17:17:08 +0200 Subject: [PATCH libguestfs] generator.ml: constify do_mkdtemp * daemon/dir.c (do_mkdtemp): Rewrite for a "const" parameter. * src/generator.ml (mkdtemp): Declare parameter to be of type Pathname. --- daemon/dir.c | 27 ++++++++------------------- src/generator.ml | 8 +++----- 2 files changed, 11 insertions(+), 24 deletions(-) diff --git...

...Makefile diff --git a/builder/Makefile.am b/builder/Makefile.am index 083e3a4..fcaa70a 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -72,13 +72,13 @@ SOURCES_ML = \ builder.ml SOURCES_C = \ - $(top_srcdir)/mllib/fsync-c.c \ - $(top_srcdir)/mllib/uri-c.c \ - $(top_srcdir)/mllib/mkdtemp-c.c \ - $(top_srcdir)/customize/perl_edit-c.c \ - $(top_srcdir)/customize/crypt-c.c \ - $(top_srcdir)/fish/uri.c \ - $(top_srcdir)/fish/file-edit.c \ + ../mllib/fsync-c.c \ + ../mllib/uri-c.c \ + ../mllib/mkdtemp-c.c \ + ../customize/perl_edit-c.c \ + ../customize/crypt-c.c \ + ../fish/uri.c \ + .....

...a/v2v/input_vmx.ml b/v2v/input_vmx.ml index f1d143e97..7a7647e53 100644 --- a/v2v/input_vmx.ml +++ b/v2v/input_vmx.ml @@ -389,8 +389,7 @@ and find_nics vmx = class input_vmx input_password input_transport arg = let tmpdir = - let base_dir = (open_guestfs ())#get_cachedir () in - let t = Mkdtemp.temp_dir ~base_dir "vmx." in + let t = Mkdtemp.temp_dir "vmx." in rmdir_on_exit t; t in object diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml index 65317f9b9..06b240b54 100644 --- a/v2v/nbdkit.ml +++ b/v2v/nbdkit.ml @@ -105,8 +105,7 @@ let add_filter_if_available cmd f...

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1354507 Main explanation is in patch #3. Rich.

Max Okumoto <okumoto@ucsd.edu> wrote: [CC changed to freebsd-security instead of the cvs list] We're talking about replacing the home-grown mkfifo() funktion in make (a modified copy of mkstemp()) with mkdtemp() and creating the fifo in this new directory. Max worries about a possible race with this new approach. > Its not a race between two nice programs :-) The function mkdtmp() > creates a uniq directory, but make would then need to create a fifo > in it. (This is two steps, and thus can a...

...s needed to check > > > the > > > signature. > > > > > > The only exception is when a non-default fingerprint is used: in > > > this > > > case, that key is read from the user's keyring, since it is where it > > > is. > > The mkdtemp part is fine. You could spin that off into a separate > > commit, so it could be a candidate for backporting. > > Hm but it would not be used by anything else so far, so not sure what > would the backport of it actually do. Just thinking that we might use the mkdtemp binding some...

...' llvm[1]: Compiling Path.cpp for Debug build In file included from /usr/src/llvm/lib/System/Path.cpp:104: /usr/src/llvm/lib/System/Unix/Path.inc: In static member function `static llvm:: sys::Path llvm::sys::Path::GetTemporaryDirectory()': /usr/src/llvm/lib/System/Unix/Path.inc:93: error: `mkdtemp' undeclared (first us e this function) /usr/src/llvm/lib/System/Unix/Path.inc:93: error: (Each undeclared identifier is reported only once for each function it appears in.) make[1]: *** [/usr/build/llvm/lib/System/Debug/Path.o] Error 1 make[1]: Leaving directory `/usr/build/llvm/lib/System'...

...ry `/home/home/ac/psimmons/llvm/llvm-2.7/lib/System' llvm[1]: Compiling Path.cpp for Release build In file included from Path.cpp:262: Unix/Path.inc: In static member function 'static llvm::sys::Path llvm::sys::Path::GetTemporaryDirectory(std::string*)': Unix/Path.inc:142: error: 'mkdtemp' was not declared in this scope Unix/Path.inc: In static member function 'static llvm::sys::Path llvm::sys::Path::GetMainExecutable(const char*, void*)': Unix/Path.inc:365: error: 'Dl_info' was not declared in this scope Unix/Path.inc:365: error: expected `;' before 'DL...

>> >Just an aside .. are you putting these Cygwin installs on the same >> box? >> >Can you do that? I didn't think it was allowed. >> >> Ahh, we have ways of renaming directories :) > >Yes, but do you have ways of renaming the registry which contains >references to the DLL's installed by Cygwin. Personally, I think you're >playing with

Reid, Just done a proper check and there are no cygwin DLL references in the registry. Aaron

...+++++++++++++++++++ gobject/Makefile.inc | 6 ++++-- po/POTFILES | 2 ++ src/MAX_PROC_NR | 2 +- 5 files changed, 104 insertions(+), 3 deletions(-) diff --git a/daemon/dir.c b/daemon/dir.c index aed45d6..b58cc2a 100644 --- a/daemon/dir.c +++ b/daemon/dir.c @@ -212,3 +212,64 @@ do_mkdtemp (const char *template) return r; } + +char * +do_mktemp (const char *template, + int dir, + const char *suffix) +{ + char *dest_name = NULL; + size_t suffix_len = 0; + char *r; + int err; + if (!(optargs_bitmask & GUESTFS_MKTEMP_DIR_BITMASK)) + dir = 0; + + if...

...quot;); > - > - cmderror: It seems like it is still necessary to me. > + } else { > + fs_buf = strdup ("/tmp/btrfs.XXXXXX"); > + if (fs_buf == NULL) { > + fprintf (stderr, "strdup\n"); > + return NULL; > + } > + > + if (mkdtemp (fs_buf) == NULL) { > + fprintf (stderr, "mkdtemp: %s\n", fs_buf); > + free (fs_buf); > + return NULL; > + } > + > + if (mount_vfs_nochroot ("", NULL, fs, fs_buf, "<internal>") == -1) { > + if (rmdir (fs_buf) == -1 &...

...ns/llvm/llvm-2.7/lib/System' > llvm[1]: Compiling Path.cpp for Release build > In file included from Path.cpp:262: > Unix/Path.inc: In static member function 'static llvm::sys::Path > llvm::sys::Path::GetTemporaryDirectory(std::string*)': > Unix/Path.inc:142: error: 'mkdtemp' was not declared in this scope > Unix/Path.inc: In static member function 'static llvm::sys::Path > llvm::sys::Path::GetMainExecutable(const char*, void*)': > Unix/Path.inc:365: error: 'Dl_info' was not declared in this scope > Unix/Path.inc:365: error: expected `;...

v1 was here: https://www.redhat.com/archives/libguestfs/2020-April/msg00007.html There's a BZ for this now which I forgot to add to the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1814611 For v2: - Fix incorrect reference to $TMPDIR in existing manual. - Separate handling for small temporary files and large temporary files. Small temporary files go into $TMPDIR

...on eBay for you for replacement 2.5" harddisks but they > were expensive and in short supply :( LOL. > > >That all sounds right to me. Must be the "new" version of Cygwin. Go > >to /usr/include and do this: > > > >find . -name '*.h' -exec grep mkdtemp {} \; -print > > Its giving me zilch. Okay, so Cygwin doesn't have a mkdtemp. Perhaps it never did. So why is configure "finding" one? > > >and let me know if you get any output. The output will tell you which > >header file mkdtemp is defined in. Make sure t...

.../System' >> llvm[1]: Compiling Path.cpp for Release build >> In file included from Path.cpp:262: >> Unix/Path.inc: In static member function 'static llvm::sys::Path >> llvm::sys::Path::GetTemporaryDirectory(std::string*)': >> Unix/Path.inc:142: error: 'mkdtemp' was not declared in this scope >> Unix/Path.inc: In static member function 'static llvm::sys::Path >> llvm::sys::Path::GetMainExecutable(const char*, void*)': >> Unix/Path.inc:365: error: 'Dl_info' was not declared in this scope >> Unix/Path.inc:365: er...