search for: miscq

On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > Add a new vq, miscq, to handle miscellaneous requests between the device > and the driver. > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES implements > request sent from the device. Commands are sent from host and handled on guest. In fact how is this so different from stats? How...

On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > Add a new vq, miscq, to handle miscellaneous requests between the device > and the driver. > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES implements > request sent from the device. Commands are sent from host and handled on guest. In fact how is this so different from stats? How...

Add a new vq, miscq, to handle miscellaneous requests between the device and the driver. This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES request sent from the device. Upon receiving this request from the miscq, the driver offers to the device the guest unused pages. Tests have shown that skipping...

...NK_TYPE_BALLOON: Ballooned (i.e. inflated/deflated) pages > to chunk. For the ballooned type, it uses the basic chunk msg format: > > virtio_balloon_page_chunk_hdr + > virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > > 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq msg > format: > miscq_hdr + > virtio_balloon_page_chunk_hdr + > virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > > The chunk msg is actually the payload of the miscq msg. > > So just combine the two message formats and then it'll all be easier? > > > +#define...

...NK_TYPE_BALLOON: Ballooned (i.e. inflated/deflated) pages > to chunk. For the ballooned type, it uses the basic chunk msg format: > > virtio_balloon_page_chunk_hdr + > virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > > 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq msg > format: > miscq_hdr + > virtio_balloon_page_chunk_hdr + > virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > > The chunk msg is actually the payload of the miscq msg. > > So just combine the two message formats and then it'll all be easier? > > > +#define...

...oned (i.e. inflated/deflated) pages >> to chunk. For the ballooned type, it uses the basic chunk msg format: >> >> virtio_balloon_page_chunk_hdr + >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS >> >> 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq msg >> format: >> miscq_hdr + >> virtio_balloon_page_chunk_hdr + >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS >> >> The chunk msg is actually the payload of the miscq msg. >> >> > So just combine the two message formats and then it'll all be...

On Thu, Apr 27, 2017 at 02:33:44PM +0800, Wei Wang wrote: > On 04/14/2017 01:08 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > > > Add a new vq, miscq, to handle miscellaneous requests between the device > > > and the driver. > > > > > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES > > implements > > > > > request sent from the device. > > Commands are sent from host an...

On Thu, Apr 27, 2017 at 02:33:44PM +0800, Wei Wang wrote: > On 04/14/2017 01:08 AM, Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: > > > Add a new vq, miscq, to handle miscellaneous requests between the device > > > and the driver. > > > > > > This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES > > implements > > > > > request sent from the device. > > Commands are sent from host an...

...pages > >> to chunk. For the ballooned type, it uses the basic chunk msg format: > >> > >> virtio_balloon_page_chunk_hdr + > >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > >> > >> 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq > >> msg > >> format: > >> miscq_hdr + > >> virtio_balloon_page_chunk_hdr + > >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > >> > >> The chunk msg is actually the payload of the miscq msg. > >> > >> > > So just...

...pages > >> to chunk. For the ballooned type, it uses the basic chunk msg format: > >> > >> virtio_balloon_page_chunk_hdr + > >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > >> > >> 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq > >> msg > >> format: > >> miscq_hdr + > >> virtio_balloon_page_chunk_hdr + > >> virtio_balloon_page_chunk * MAX_PAGE_CHUNKS > >> > >> The chunk msg is actually the payload of the miscq msg. > >> > >> > > So just...

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler

On 04/14/2017 01:08 AM, Michael S. Tsirkin wrote: > On Thu, Apr 13, 2017 at 05:35:08PM +0800, Wei Wang wrote: >> Add a new vq, miscq, to handle miscellaneous requests between the device >> and the driver. >> >> This patch implemnts the VIRTIO_BALLOON_MISCQ_INQUIRE_UNUSED_PAGES > implements > >> request sent from the device. > Commands are sent from host and handled on guest. > In fact how is t...

...ges and then discarding changes made to the pages that it gets from guest before it sent the command. Changes: v9->v10: 1) mm: put report_unused_page_block() under CONFIG_VIRTIO_BALLOON; 2) virtio-balloon: add virtballoon_validate(); 3) virtio-balloon: msg format change; 4) virtio-balloon: move miscq handling to a task on system_freezable_wq; 5) virtio-balloon: code cleanup. v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler function to get the free page block. v7->v8:...

...ges and then discarding changes made to the pages that it gets from guest before it sent the command. Changes: v9->v10: 1) mm: put report_unused_page_block() under CONFIG_VIRTIO_BALLOON; 2) virtio-balloon: add virtballoon_validate(); 3) virtio-balloon: msg format change; 4) virtio-balloon: move miscq handling to a task on system_freezable_wq; 5) virtio-balloon: code cleanup. v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler function to get the free page block. v7->v8:...

...ferent protocols. 1) PAGE_CHUNK_TYPE_BALLOON: Ballooned (i.e. inflated/deflated) pages to chunk. For the ballooned type, it uses the basic chunk msg format: virtio_balloon_page_chunk_hdr + virtio_balloon_page_chunk * MAX_PAGE_CHUNKS 2) PAGE_CHUNK_TYPE_UNUSED: unused pages to chunk. It uses this miscq msg format: miscq_hdr + virtio_balloon_page_chunk_hdr + virtio_balloon_page_chunk * MAX_PAGE_CHUNKS The chunk msg is actually the payload of the miscq msg. >> +#define MAX_PAGE_CHUNKS 4096 > This is an order-4 allocation. I'd make it 4095 and then it's > an order-3 one. Sou...

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned

...virtqueue; > 3)??virtio_balloon: use cmdq to report guest memory statistics. > > v9->v10: > 1) mm: put report_unused_page_block() under CONFIG_VIRTIO_BALLOON; > 2) virtio-balloon: add virtballoon_validate(); > 3) virtio-balloon: msg format change; > 4) virtio-balloon: move miscq handling to a task on > system_freezable_wq; > 5) virtio-balloon: code cleanup. > > v8->v9: > 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and > VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous > implementation; > 2) Simpler function...

...catterlist sg; + + hdr->flags = 0; + sg_init_one(&sg, hdr, VIRTIO_BALLOON_CMDQ_HDR_SIZE); + + if (virtqueue_add_inbuf(vb->cmd_vq, &sg, 1, hdr, GFP_KERNEL) < 0) { + __virtio_clear_bit(vb->vdev, + VIRTIO_BALLOON_F_CMD_VQ); + dev_warn(&vb->vdev->dev, "%s: add miscq msg buf err\n", + __func__); + return; + } + + virtqueue_kick(vb->cmd_vq); +} + +static void cmdq_handle_unused_pages(struct virtio_balloon *vb) +{ + struct virtqueue *vq = vb->cmd_vq; + struct vring_desc *hdr_desc = &vb->cmdq_unused_page.desc_table[0]; + unsigned long hdr_pa;...