search for: minfei

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is use...

From: Minfei Huang <mnghuan at gmail.com> We do a lot of memory allocation in function init_vq, and don't handle the allocation failure properly. Then this function will return 0, although initialization fails due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is use...

...0 will be returned, if we can not allocate more memory in function init_vq. If host can support multiple virtual queues, and we fails to allocate necessary memory structures for vq, kernel may crash due to incorrect returning. To fix it, kernel will return correct value in init_vq. Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> --- drivers/block/virtio_blk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..40ecb2b 100644 --- a/d...

...0 will be returned, if we can not allocate more memory in function init_vq. If host can support multiple virtual queues, and we fails to allocate necessary memory structures for vq, kernel may crash due to incorrect returning. To fix it, kernel will return correct value in init_vq. Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> --- drivers/block/virtio_blk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 42758b5..40ecb2b 100644 --- a/d...

...s due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> --- v1: - Refactor the patch to make code more readable --- drivers/block/virtio_blk.c | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers...

...s due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> --- v1: - Refactor the patch to make code more readable --- drivers/block/virtio_blk.c | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers...

On Tue, 19 Jul 2016 12:32:42 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to la...

On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang <mnfhuang at gmail.com> wrote: > From: Minfei Huang <mnghuan at gmail.com> > > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lack...

On 07/18/16 at 05:21P, Cornelia Huck wrote: > On Mon, 18 Jul 2016 22:01:29 +0800 > Minfei Huang <mnfhuang at gmail.com> wrote: > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 42758b5..d920512 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -381,9 +381,9 @@ static int init_vq(st...

On 07/18/16 at 05:21P, Cornelia Huck wrote: > On Mon, 18 Jul 2016 22:01:29 +0800 > Minfei Huang <mnfhuang at gmail.com> wrote: > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 42758b5..d920512 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -381,9 +381,9 @@ static int init_vq(st...

On Mon, 27 Jun 2016 10:09:18 +0800 Minfei Huang <mnghuan at gmail.com> wrote: > The error number -ENOENT or 0 will be returned, if we can not allocate > more memory in function init_vq. If host can support multiple virtual > queues, and we fails to allocate necessary memory structures for vq, > kernel may crash due to in...

On Mon, 18 Jul 2016 22:01:29 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > We do a lot of memory allocation in function init_vq, and don't handle > the allocation failure properly. Then this function will return 0, > although initialization fails due to lacking memory. At that moment, > kernel will panic in gue...

On 07/06/16 at 11:18P, Cornelia Huck wrote: > On Mon, 27 Jun 2016 10:09:18 +0800 > Minfei Huang <mnghuan at gmail.com> wrote: > > > The error number -ENOENT or 0 will be returned, if we can not allocate > > more memory in function init_vq. If host can support multiple virtual > > queues, and we fails to allocate necessary memory structures for vq, > > k...

On 07/06/16 at 11:18P, Cornelia Huck wrote: > On Mon, 27 Jun 2016 10:09:18 +0800 > Minfei Huang <mnghuan at gmail.com> wrote: > > > The error number -ENOENT or 0 will be returned, if we can not allocate > > more memory in function init_vq. If host can support multiple virtual > > queues, and we fails to allocate necessary memory structures for vq, > > k...

...s due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 26 ++++++++------------------ 1 file cha...

...s due to lacking memory. At that moment, kernel will panic in guest machine, if virtio is used to drive disk. To fix this bug, we should take care of allocation failure, and return correct value to let caller know what happen. Tested-by: Chao Fan <fanc.fnst at cn.fujitsu.com> Signed-off-by: Minfei Huang <mnghuan at gmail.com> Signed-off-by: Minfei Huang <minfei.hmf at alibaba-inc.com> Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 26 ++++++++------------------ 1 file cha...

On Tue, 19 Jul 2016 00:18:32 +0800 Minfei Huang <mnfhuang at gmail.com> wrote: > On 07/18/16 at 05:21P, Cornelia Huck wrote: > > On Mon, 18 Jul 2016 22:01:29 +0800 > > Minfei Huang <mnfhuang at gmail.com> wrote: > > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > > in...

...n <mst at redhat.com> ---------------------------------------------------------------- Christian Borntraeger (1): virtio/s390: keep early_put_chars Cornelia Huck (1): virtio/s390: deprecate old transport Michael S. Tsirkin (1): virtio: fix error handling for debug builds Minfei Huang (1): virtio_blk: Fix a slient kernel panic Stefan Hajnoczi (2): vhost/vsock: fix vhost virtio_vsock_pkt use-after-free virtio-vsock: fix include guard typo Vegard Nossum (1): 9p/trans_virtio: use kvfree() for iov_iter_get_pages_alloc() Wei Yongjun (1): virtio:...

...n <mst at redhat.com> ---------------------------------------------------------------- Christian Borntraeger (1): virtio/s390: keep early_put_chars Cornelia Huck (1): virtio/s390: deprecate old transport Michael S. Tsirkin (1): virtio: fix error handling for debug builds Minfei Huang (1): virtio_blk: Fix a slient kernel panic Stefan Hajnoczi (2): vhost/vsock: fix vhost virtio_vsock_pkt use-after-free virtio-vsock: fix include guard typo Vegard Nossum (1): 9p/trans_virtio: use kvfree() for iov_iter_get_pages_alloc() Wei Yongjun (1): virtio:...

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20160718/3b4e899d/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-virtio_blk-Fix-a-slient-kernel-panic.patch Type: application/octet-stream Size: 2719 bytes Desc: not available