search for: min_memsize

Alternate way to fix test-255-disks.sh running out of memory. See previous discussion here: https://www.redhat.com/archives/libguestfs/2018-May/msg00082.html Rich.

...) diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h index adeb9478a..83eaebe75 100644 --- a/lib/guestfs-internal.h +++ b/lib/guestfs-internal.h @@ -94,7 +94,7 @@ * creating device nodes. */ #ifdef __powerpc__ -# define DEFAULT_MEMSIZE 768 +# define DEFAULT_MEMSIZE 1024 # define MIN_MEMSIZE 256 #endif @@ -104,16 +104,16 @@ * common on aarch64, treat this like the ppc case above. */ #ifdef __aarch64__ -# define DEFAULT_MEMSIZE 768 +# define DEFAULT_MEMSIZE 1024 # define MIN_MEMSIZE 256 #endif /* The default and minimum memory size for most users. */ #ifndef DEFAULT_MEM...

...6 100644 > --- a/src/guestfs-internal.h > +++ b/src/guestfs-internal.h > @@ -93,7 +93,7 @@ > > /* The default and minimum memory size for most users. */ > #ifndef DEFAULT_MEMSIZE > -# define DEFAULT_MEMSIZE 500 > +# define DEFAULT_MEMSIZE 768 > #endif > #ifndef MIN_MEMSIZE > # define MIN_MEMSIZE 128 If only we had a more sensible way to allocate memory :-( Anyway, this patch needs to remove the earlier lines which set DEFAULT_MEMSIZE to 768 on __powerpc__ and __aarch64__. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones...

Use %d to parse them as int (since the variables for them as int) instead of %u, even if they both need to be at least > 0. --smp was already checked to be >= 1 while --memsize not, so check that the specified memory size is not < 128 (which is semi-arbitrary, but enough as a minimum threshold). --- rescue/rescue.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)

...#39; which should not be used in production builds.\n"); - exit (119); - } - } -#endif - return 1; } diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index bbd7fb4..cf6e534 100644 --- a/src/guestfs-internal.h +++ b/src/guestfs-internal.h @@ -79,18 +79,6 @@ # define MIN_MEMSIZE 256 #endif -/* Valgrind has a fairly hefty memory overhead. Using the defaults - * caused the C API tests to fail. - */ -#ifdef VALGRIND_DAEMON -# ifndef DEFAULT_MEMSIZE -# define DEFAULT_MEMSIZE 768 -# endif -# ifndef MIN_MEMSIZE -# define MIN_MEMSIZE 256 -# endif -#endif - /* The d...

Previously posted here: https://www.redhat.com/archives/libguestfs/2015-June/msg00266.html Rich.

...treat this like the ppc case above. */ #ifdef __aarch64__ -# define DEFAULT_MEMSIZE 1024 +# define DEFAULT_MEMSIZE 1280 #endif /* The default and minimum memory size for most users. */ #ifndef DEFAULT_MEMSIZE -# define DEFAULT_MEMSIZE 768 +# define DEFAULT_MEMSIZE 1280 #endif #ifndef MIN_MEMSIZE # define MIN_MEMSIZE 256 -- 2.26.2

Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to

These three patches (for discussion only, NOT to be applied) implement a mutex system that lets the user limit the number of libguestfs instances that can be launched per host. There are two uses that I have identified for this: firstly so we can enable parallel-tests (the default in automake >= 1.13) without blowing up the host. Secondly oVirt has raised concerns about how to limit the

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.