search for: michael_c_berg

...math flag should override the NoContraction decoration as that's mostly the point of that decoration to begin with, to have fine granular control while still having a broad sweeping optimization. Did I miss your point? I feel like I did. >> On Thu, Aug 23, 2018, 3:42 PM Michael Berg <michael_c_berg at apple.com <mailto:michael_c_berg at apple.com>> wrote: >> Ryan, >> Given that the global fast math flag overrides most fp behavior also >> mapped to IR FMF flags as a control, I think we should remove it >> from the argument. The Global fast math sho...

...bal fast math flag should override the NoContraction decoration as that's mostly the point of that decoration to begin with, to have fine granular control while still having a broad sweeping optimization. Did I miss your point? I feel like I did. On Thu, Aug 23, 2018, 3:42 PM Michael Berg <michael_c_berg at apple.com> wrote: > Ryan, > > Given that the global fast math flag overrides most fp behavior also > mapped to IR FMF flags as a control, I think we should remove it from the > argument. The Global fast math should override behavior without IR flag > opposition, as that is...

All: There will be a BoF talk at the EuroLLVM conference regarding Numerics (FMF and module flags which control fp behavior and optimization). Even if you are not going to be in attendance, please reply to this thread as we are collecting open issues and ideas for future direction in all layers of LLVM for which optimizations are controlled by numerics flags. Please read over the numerics blog

...n. The problem is you can have 2 fp arith instructions with no contracts and no reassoc with global fast math flag set, how can you differentiate between the two instructions when you want one to be contract and the other to be no contract? -Ryan On Thu, Aug 23, 2018 at 2:27 PM Michael Berg <michael_c_berg at apple.com> wrote: > Ryan: > > I think this will take more, here is the SPIR-V relevant text ( > https://www.khronos.org/registry/spir-v/specs/1.0/SPIRV.pdf ): > > <start> > > NoContraction > > Apply to an arithmetic instruction to indicate the operation ca...

On Sun, Mar 17, 2019 at 1:47 PM Craig Topper <craig.topper at gmail.com> wrote: > Can we move HasValueHandle out of the byte used for SubClassOptionalData and move it to the flags at the bottom of value by shrinking NumUserOperands to 27? I like this approach because it is less work for me. :) But I agree with Sanjay below that this only kicks the can slightly further down the road

Maybe there is a cleaner solution but it seems like adding a 'nocontract' flag is close to the intention of spir-v and is an easy check in the DAGCombiner without breaking anything else and its intentions are very clear. Right now the DAGCombiner logic doesn't seem to be able to handle the case of having fast math globally with instruction level flags to turn off fast math. Right now,