search for: mhnd_sentinel

...==================== --- src/modules/internet/libcurl.c (revision 86484) +++ src/modules/internet/libcurl.c (working copy) @@ -55,6 +55,47 @@ static int current_timeout = 0; +// The multi-handle is shared between downloads for reusing connections +static CURLM *shared_mhnd = NULL; +static SEXP mhnd_sentinel = NULL; + +static void cleanup_mhnd(SEXP ignored) +{ + if(shared_mhnd){ + curl_multi_cleanup(shared_mhnd); + shared_mhnd = NULL; + } + curl_global_cleanup(); +} +static void rollback_mhnd_sentinel(void* sentinel) { + // Failed to allocate memory while registering a finaliz...

I'd like to raise this again now that 4.4 is out. Below is a more complete patch which includes a function to properly cleanup libcurl when R quits. Implementing this is a little tricky because libcurl is a separate "module" in R, perhaps there is a better way, but this works: view: https://github.com/r-devel/r-svn/pull/166/files patch:

...et/libcurl.c (revision 86484) > +++ src/modules/internet/libcurl.c (working copy) > @@ -55,6 +55,47 @@ > > static int current_timeout = 0; > > +// The multi-handle is shared between downloads for reusing connections > +static CURLM *shared_mhnd = NULL; > +static SEXP mhnd_sentinel = NULL; > + > +static void cleanup_mhnd(SEXP ignored) > +{ > + if(shared_mhnd){ > + curl_multi_cleanup(shared_mhnd); > + shared_mhnd = NULL; > + } > + curl_global_cleanup(); > +} > +static void rollback_mhnd_sentinel(void* sentinel) { > + /...