search for: mguzik

...a port is already open by another process. Use EBUSY for that. This does change what we report to userspace, but I believe userspace can look at it this way: it gets EBUSY, a new error code, instead of EMFILE. It's still an error, and that's not changing. Reported-by: Mateusz Guzik <mguzik at redhat.com> Signed-off-by: Amit Shah <amit.shah at redhat.com> --- Rusty, is this OK? It's a change for the userspace, so is it considered breakage? OTOH the current return value is obviously wrong, 'Broken' userspace code could be relying on the exact error type (curren...

...a port is already open by another process. Use EBUSY for that. This does change what we report to userspace, but I believe userspace can look at it this way: it gets EBUSY, a new error code, instead of EMFILE. It's still an error, and that's not changing. Reported-by: Mateusz Guzik <mguzik at redhat.com> Signed-off-by: Amit Shah <amit.shah at redhat.com> --- Rusty, is this OK? It's a change for the userspace, so is it considered breakage? OTOH the current return value is obviously wrong, 'Broken' userspace code could be relying on the exact error type (curren...

...private_data field before we've successfully done all our checks. This means we can return an error with the private_data field updated. This could lead to problems. Fix by moving the assignment after all checks are done. CC: <stable at vger.kernel.org> Reported-by: Mateusz Guzik <mguzik at redhat.com> Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index a39702a..7728af9 100644 --- a/drivers/char/virtio_con...

...ng the assignment after all checks are done. No, this is a bit weird, but it's fine. If we fail open, filp will be destroyed; we won't be told about it, and private_data will never be accessed. Cheers, Rusty. > CC: <stable at vger.kernel.org> > Reported-by: Mateusz Guzik <mguzik at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index a39702a..7728af9 10...

...ow between find_port_by_devt() returning a port and us taking a kref on the port, where the port could get unplugged. Fix it by taking the reference in find_port_by_devt() itself. Problem reported and analyzed by Mateusz Guzik. CC: <stable at vger.kernel.org> Reported-by: Mateusz Guzik <mguzik at redhat.com> Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..291f437 100644 --- a/drivers/c...

...ng the assignment after all checks are done. No, this is a bit weird, but it's fine. If we fail open, filp will be destroyed; we won't be told about it, and private_data will never be accessed. Cheers, Rusty. > CC: <stable at vger.kernel.org> > Reported-by: Mateusz Guzik <mguzik at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index a39702a..7728af9 10...

...gt; by taking the reference in find_port_by_devt() itself. > > Problem reported and analyzed by Mateusz Guzik. This fix is clearly correct, but what about the other find_port_by_* functions? Applied, Rusty. > > CC: <stable at vger.kernel.org> > Reported-by: Mateusz Guzik <mguzik at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456...

...gt; by taking the reference in find_port_by_devt() itself. > > Problem reported and analyzed by Mateusz Guzik. This fix is clearly correct, but what about the other find_port_by_* functions? Applied, Rusty. > > CC: <stable at vger.kernel.org> > Reported-by: Mateusz Guzik <mguzik at redhat.com> > Signed-off-by: Amit Shah <amit.shah at redhat.com> > --- > drivers/char/virtio_console.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456...

Hello, This series fixes a few races with port unplug and the various file operations: read(), write(), close() and poll(). There still might be more races lurking, but testing this series looks good to at least solve the easily-triggerable ones. I've run the virtio-serial testsuite and a few open/close/unplug tests, and haven't seen any badness. I've marked these patches for

Hello, This series fixes a few races with port unplug and the various file operations: read(), write(), close() and poll(). There still might be more races lurking, but testing this series looks good to at least solve the easily-triggerable ones. I've run the virtio-serial testsuite and a few open/close/unplug tests, and haven't seen any badness. I've marked these patches for

Hello, This series fixes a few bugs and races with port unplug and the various file operations: read(), write(), close() and poll(). There still might be more races lurking, but testing this series looks good to at least solve the easily-triggerable ones. I've run the virtio-serial testsuite and a few open/close/unplug tests, and haven't seen any badness. I've marked these patches

Hello, This series fixes a few bugs and races with port unplug and the various file operations: read(), write(), close() and poll(). There still might be more races lurking, but testing this series looks good to at least solve the easily-triggerable ones. I've run the virtio-serial testsuite and a few open/close/unplug tests, and haven't seen any badness. I've marked these patches

Hello, This series fixes a few bugs and races with port unplug and the various file operations: read(), write() and close(). I started coding up an alternative locking mechanism based on the discussion earlier in this series, but some of what we already have has to remain, and the new code is sufficiently different, so I'd rather it bakes for a while, and I ensure there are no regressions

Hello, This series fixes a few bugs and races with port unplug and the various file operations: read(), write() and close(). I started coding up an alternative locking mechanism based on the discussion earlier in this series, but some of what we already have has to remain, and the new code is sufficiently different, so I'd rather it bakes for a while, and I ensure there are no regressions

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...

...; Masanari Iida <standby24x7@gmail.com> Masanari Iida<standby24x7@gmail.com> Masatake YAMATO <yamato@redhat.com> Massimo Morana <massimo.morana@canonical.com> Mat Martineau <mathewm@codeaurora.org> Matan Barak <matanb@mellanox.com> Mateusz Guzik <mguzik@redhat.com> Mathias Froehlich <Mathias.Froehlich@web.de> Mathias Jeppsson <mathias.jeppsson@sonymobile.com> Mathias Krause <minipli@googlemail.com> Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de> Mathias Leblanc <mathias.leblanc@st.com> Mathi...