search for: mgtdev

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

...deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9138ef2fb2c8..e2e7ebd71798 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct auxiliary_device *auxdev) mgtdev = auxiliary_get_drvdata(auxdev); ndev = mgtdev->ndev; - free_irqs(ndev); + if (ndev) + free_irqs(ndev); } static const struct auxiliary_device_id mlx5v_id_table[] = { -- 2.41.0

...> > > index 9138ef2fb2c8..e2e7ebd71798 100644 > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct auxiliary_device > > > *auxdev) > > > ????????mgtdev = auxiliary_get_drvdata(auxdev); > > > ????????ndev = mgtdev->ndev; > > > ? > > > -???????free_irqs(ndev); > > > +???????if (ndev) > > > +???????????????free_irqs(ndev); > > > ?} > > > ? > > > > something I don't get...

...ef2fb2c8..e2e7ebd71798 100644 > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct auxiliary_device > > > > *auxdev) > > > > ????????mgtdev = auxiliary_get_drvdata(auxdev); > > > > ????????ndev = mgtdev->ndev; > > > > ? > > > > -???????free_irqs(ndev); > > > > +???????if (ndev) > > > > +???????????????free_irqs(ndev); > > > > ?} > > > > ? > > &...

...0644 > > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct auxiliary_device > > > > > *auxdev) > > > > > ????????mgtdev = auxiliary_get_drvdata(auxdev); > > > > > ????????ndev = mgtdev->ndev; > > > > > ? > > > > > -???????free_irqs(ndev); > > > > > +???????if (ndev) > > > > > +???????????????free_irqs(ndev); > > > > > ?} &gt...

...> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct auxiliary_device > > > > > > *auxdev) > > > > > > mgtdev = auxiliary_get_drvdata(auxdev); > > > > > > ndev = mgtdev->ndev; > > > > > > > > > > > > - free_irqs(ndev); > > > > > > + if (ndev) > > > > > > + free_irqs(ndev); > &gt...

...> > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > @@ -3556,7 +3556,8 @@ static void mlx5v_shutdown(struct > > > > > > > auxiliary_device > > > > > > > *auxdev) > > > > > > > ??????? mgtdev = auxiliary_get_drvdata(auxdev); > > > > > > > ??????? ndev = mgtdev->ndev; > > > > > > > > > > > > > > -?????? free_irqs(ndev); > > > > > > > +?????? if (ndev) > > > > > > > +??????????????...

...goto err_res2; > >> } > >> > >> - ndev->nb.notifier_call = event_handler; > >> - mlx5_notifier_register(mdev, &ndev->nb); > >> - ndev->nb_registered = true; > >> mvdev->vdev.mdev = &mgtdev->mgtdev; > >> err = _vdpa_register_device(&mvdev->vdev, max_vqs + 1); > >> if (err) > >> @@ -3318,10 +3345,7 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *v_mdev, struct vdpa_device * > >> > >> mlx5_vdpa_remo...

Live migration of vdpa would typically require re-instate vdpa device with an idential set of configs on the destination node, same way as how source node created the device in the first place. In order to allow live migration orchestration software to export the initial set of vdpa attributes with which the device was created, it will be useful if the vdpa tool can report the config on demand

...mvdev->wq = NULL; > destroy_workqueue(wq); > _vdpa_unregister_device(dev); What if the user tries to access debugfs after _vdpa_unregister_device()? Thanks > + mlx5_vdpa_remove_debugfs(ndev->debugfs); > + ndev->debugfs = NULL; > mgtdev->ndev = NULL; > } > > -- > 2.38.1 >