search for: mgmtdev

...dpa dev config show" command that usually goes with the live value in the device config space, and is not reliable subject to the dynamics of feature negotiation or possible change by driver to the config space. Examples: 1) Create vDPA by default without any config attribute $ vdpa dev add mgmtdev pci/0000:41:04.2 name vdpa0 $ vdpa dev show vdpa0 vdpa0: type network mgmtdev pci/0000:41:04.2 vendor_id 5555 max_vqs 9 max_vq_size 256 $ vdpa dev -jp show vdpa0 { "dev": { "vdpa0": { "type": "network", "mgmtdev":...

In below example, before the fix, mtu attribute is supported by the parent mgmtdev, but the error message showing "All provided are not supported" is just misleading. $ vdpa mgmtdev show vdpasim_net: supported_classes net max_supported_vqs 3 dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM $ vdpa dev add mgmtdev vdpasim_net name vd...

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

...bits, use the device defaults. > If user doesn?t supply any feature fits, that means user wants to run with some device defaults. > In that case its fine to run with device defaults. Noted, we don't have this device defaults exposed to users yet other than what's shown in the parent mgmtdev (dev_features). And the current and the only safe behavior for mlx5_vdpa is to inherit all device supported features from parent mgmtdev, otherwise user can't know in advance what default features the device might come up with implicitly underneath. Basically it would need to add new CLI in...

...F. Users who favor memory saving over packet rate could enable > this feature but we want to keep it off by default. > > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > > Acked-by: Jason Wang <jasowang at redhat.com> > Signed-off-by: Eli Cohen <elic at nvidia.com> I have a question. Could you guys try with the recent XDP mergeable buffer rework? Does this address the performance issue you...

...; > > One can still enable it when creating the vdpa device using > > > > > > > vdpa tool by providing features that include it. > > > > > > > > > > > > > > For example: > > > > > > > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 > > > > > > > device_features 0x300cb982b > > > > > > > > > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > > > What's the reason to turn it off by default? It's generally...

...ice(s) in the PF > + devlink dev param set pci/$PF_BDF name enable_vnet value true cmode runtime > + > + # Create a VF for vDPA use > + echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs > + > + # Find the vDPA services/devices available > + PDS_VDPA_MGMT=`vdpa mgmtdev show | grep vDPA | head -1 | cut -d: -f1` > + > + # Create a vDPA device for use in virtio network configurations > + vdpa dev add name vdpa1 mgmtdev $PDS_VDPA_MGMT mac 00:11:22:33:44:55 > + > + # Set up an ethernet interface on the vdpa device > + modprobe virtio_vdpa > +...

...; sln > > > > > > Thanks > > > > > >> + # Create a VF for vDPA use > >> + echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs > >> + > >> + # Find the vDPA services/devices available > >> + PDS_VDPA_MGMT=`vdpa mgmtdev show | grep vDPA | head -1 | cut -d: -f1` > >> + > >> + # Create a vDPA device for use in virtio network configurations > >> + vdpa dev add name vdpa1 mgmtdev $PDS_VDPA_MGMT mac 00:11:22:33:44:55 > >> + > >> + # Set up an ethernet interface on the vdp...

On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > Signed-off-by: Eli Cohen <elic at nvidia.com> What's the reason to turn it off by default? It's generally a performance win isn't it? > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 ++ > 1 file changed, 2 insertio...

...wrote: > > On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > > > One can still enable it when creating the vdpa device using vdpa tool by > > > providing features that include it. > > > > > > For example: > > > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > What's the reason to turn it off by default? It's generally a > > performance win isn't it? > It has negative impact on packet rate so we wa...

...AM +0200, Eli Cohen wrote: > > > > > One can still enable it when creating the vdpa device using vdpa > > > > > tool by providing features that include it. > > > > > > > > > > For example: > > > > > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features > > > > > 0x300cb982b > > > > > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > What's the reason to turn it off by default? It's generally a > > > > performance win i...

...12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: >>>>> One can still enable it when creating the vdpa device using vdpa >>>>> tool by providing features that include it. >>>>> >>>>> For example: >>>>> $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features >>>>> 0x300cb982b >>>>> >>>>> Signed-off-by: Eli Cohen <elic at nvidia.com> >>>> What's the reason to turn it off by default? It's generally a >>>> performance win isn't it? >&...

...atch is preparation and moves the buffer allocation into devices, the second patch adds the `shared_buffer_mutex` parameter to vdpa_sim_blk to use the same ramdisk for all devices. Tested with QEMU v8.0.0-rc2 in this way: modprobe vhost_vdpa modprobe vdpa_sim_blk shared_backend=true vdpa dev add mgmtdev vdpasim_blk name blk0 vdpa dev add mgmtdev vdpasim_blk name blk1 qemu-system-x86_64 -m 512M -smp 2 -M q35,accel=kvm,memory-backend=mem \ ?-object memory-backend-file,share=on,id=mem,size="512M",mem-path="/dev/shm" ?... ?-blockdev node-name=drive_src1,driver=virtio-blk-vhost-...