search for: metadatatyid

Hi llvm, 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, which is empty in 2.6. I noticed that it does not check all types, for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID and etc are ignored in the 'default' branch. Does it mean we dont need to check them? Another question is: How much does Verifier.cpp check statically? Can I take it as a type checker for SSA? Is there any static semantics that has not been checked yet? 2) visitFreeInst has been removed f...

On Mar 6, 2010, at 9:13 AM, Jianzhou Zhao wrote: > Hi llvm, > > 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, > which is empty in 2.6. I noticed that it does not check all types, > for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID > and etc are ignored in the 'default' branch. Does it mean we dont > need to check them? They are leaf types (just like integer type), there is nothing to check. > Another question is: How much does Verifier.cpp check statically? > Can I take it as a type checker for SSA? Is...

Jianzhou Zhao wrote: > Hi llvm, > > 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, > which is empty in 2.6. I noticed that it does not check all types, > for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID > and etc are ignored in the 'default' branch. Does it mean we dont > need to check them? We do need to check union. I'll add that. The others don't need a case because they don't contain subtypes; it's impossible to have an illegal label type. It's either a lab...

...ing :) In UnionValType methods, please use "UT" instead of "ST" as an acronym. +bool UnionType::isValidElementType(const Type *ElemTy) { + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != LabelTyID && + ElemTy->getTypeID() != MetadataTyID && ! isa<FunctionType>(ElemTy); +} Please use "!ElemTy->isVoidTy()" etc. --- lib/VMCore/ConstantsContext.h (revision 93451) +template<> +struct ConstantKeyData<ConstantUnion> { + typedef Constant* ValType; + static ValType getValType(ConstantUnion *CS) {...

...e methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!ElemTy->isVoidTy()" etc. > > --- lib/VMCore/ConstantsContext.h (revision 93451) > > +template<> > +struct ConstantKeyData<ConstantUnion> { > + typedef Constant* ValType...

...e methods, please use "UT" instead of "ST" as an acronym. > > +bool UnionType::isValidElementType(const Type *ElemTy) { > + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != > LabelTyID && > + ElemTy->getTypeID() != MetadataTyID && > !isa<FunctionType>(ElemTy); > +} > > Please use "!ElemTy->isVoidTy()" etc. > > --- lib/VMCore/ConstantsContext.h (revision 93451) > > +template<> > +struct ConstantKeyData<ConstantUnion> { > + typedef Constant* ValType...

...; > On Mar 6, 2010, at 9:13 AM, Jianzhou Zhao wrote: > >> Hi llvm, >> >> 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, >> which is empty in 2.6. I noticed that it does not check all types, >> for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID >> and etc are ignored in the 'default' branch. Does it mean we dont >> need to check them? > > They are leaf types (just like integer type), there is nothing to check. > >> Another question is: How much does Verifier.cpp check statically? >> Can I take it a...

...olas at mxc.ca> wrote: > Jianzhou Zhao wrote: >> >> Hi llvm, >> >> 1) The lib/VMCore/Verifier.cpp in 2.7 implements Verifier::VerifyType, >> which is empty in 2.6. I noticed that it does not check all types, >> for example, UnionTyID, OpaqueTyID, LabelTyID, MetadataTyID >> and etc are ignored in the 'default' branch. Does it mean we dont >> need to check them? > > We do need to check union. I'll add that. The others don't need a case > because they don't contain subtypes; it's impossible to have an illegal > label ty...

OK here's the patch for real this time :) On Fri, Jan 15, 2010 at 4:36 PM, Talin <viridia at gmail.com> wrote: > Here's a work in progress of the union patch. Note that the test "union.ll" > does not work, so you probably don't want to check this in as is. However, > I'd be interested in any feedback you're willing to give. > > -- > -- Talin

Here's a work in progress of the union patch. Note that the test "union.ll" does not work, so you probably don't want to check this in as is. However, I'd be interested in any feedback you're willing to give. -- -- Talin -------------- next part -------------- An HTML attachment was scrubbed... URL:

...e "UT" instead of "ST" as an acronym. >> >> +bool UnionType::isValidElementType(const Type *ElemTy) { >> + return ElemTy->getTypeID() != VoidTyID && ElemTy->getTypeID() != >> LabelTyID && >> + ElemTy->getTypeID() != MetadataTyID && >> !isa<FunctionType>(ElemTy); >> +} >> >> Please use "!ElemTy->isVoidTy()" etc. >> >> --- lib/VMCore/ConstantsContext.h (revision 93451) >> >> +template<> >> +struct ConstantKeyData<ConstantUnion>...