search for: mergesymbolrecords

...s in the EXE PDB will be different than they were in the JIT PDB, but the symbol records will refer to the JIT PDB type indices. So these need to be fixed up. LLD already has code to do this, you can probably borrow a similar algorithm with some slight modifications (lldb/COFF/PDB.cpp, search for mergeSymbolRecords) 3) Merge in the new section contributions and section map. See LLD again for how to modify these. Hopefully the object file you exported contains relocated symbol addresses so you don't have to do any fixups here. 4) Merge in the publics and globals. This shouldn't be too hard, I thin...

...han they were in the JIT PDB, but the symbol >> records will refer to the JIT PDB type indices. So these need to be fixed >> up. LLD already has code to do this, you can probably borrow a similar >> algorithm with some slight modifications (lldb/COFF/PDB.cpp, search for >> mergeSymbolRecords) >> >> 3) Merge in the new section contributions and section map. See LLD again >> for how to modify these. Hopefully the object file you exported contains >> relocated symbol addresses so you don't have to do any fixups here. >> >> 4) Merge in the publics...

...t the symbol >>>> records will refer to the JIT PDB type indices. So these need to be fixed >>>> up. LLD already has code to do this, you can probably borrow a similar >>>> algorithm with some slight modifications (lldb/COFF/PDB.cpp, search for >>>> mergeSymbolRecords) >>>> >>>> 3) Merge in the new section contributions and section map. See LLD >>>> again for how to modify these. Hopefully the object file you exported >>>> contains relocated symbol addresses so you don't have to do any fixups here. >>&g...

...for the symbol records, some of these records might be the same in 2 different object files, and some might be different. So we need to de-duplicate them into the final PDB. LLD actually already does this, so a lot of the code for this portion is probably already written in LLD. See PDBLinker::mergeSymbolRecords in lld/COFF/PDB.cpp. The algorithm is slightly different when merging 2 PDBs, but that's the general idea. 3) We need to merge the publics and globals stream, similar to the above. For #2 and #3 above, this is going to be tricky. How do you know if 2 symbols are actually the same symbol?...

...ymbol records will refer to the JIT PDB type indices. So these need to be >>>>>> fixed up. LLD already has code to do this, you can probably borrow a >>>>>> similar algorithm with some slight modifications (lldb/COFF/PDB.cpp, search >>>>>> for mergeSymbolRecords) >>>>>> >>>>>> 3) Merge in the new section contributions and section map. See LLD >>>>>> again for how to modify these. Hopefully the object file you exported >>>>>> contains relocated symbol addresses so you don't have t...

...to the JIT PDB type indices. So these need to be >>>>>>>> fixed up. LLD already has code to do this, you can probably borrow a >>>>>>>> similar algorithm with some slight modifications (lldb/COFF/PDB.cpp, search >>>>>>>> for mergeSymbolRecords) >>>>>>>> >>>>>>>> 3) Merge in the new section contributions and section map. See LLD >>>>>>>> again for how to modify these. Hopefully the object file you exported >>>>>>>> contains relocated symbol a...

...ices. So these need >>>>>>>>>> to be fixed up. LLD already has code to do this, you can probably borrow a >>>>>>>>>> similar algorithm with some slight modifications (lldb/COFF/PDB.cpp, search >>>>>>>>>> for mergeSymbolRecords) >>>>>>>>>> >>>>>>>>>> 3) Merge in the new section contributions and section map. See >>>>>>>>>> LLD again for how to modify these. Hopefully the object file you exported >>>>>>>>>...

The merge feature was implemented primarily for testing but was never really productionized, so your guess about what the underlying problem is sounds correct to me. We could probably hide the subcommand so users don’t accidentally use it, or if someone wants to properly implement the missing features, that would be even better On Sat, Dec 22, 2018 at 10:48 AM Vivien Millet via llvm-dev <

...;>>>>>>>>>>> to be fixed up. LLD already has code to do this, you can probably borrow a >>>>>>>>>>>> similar algorithm with some slight modifications (lldb/COFF/PDB.cpp, search >>>>>>>>>>>> for mergeSymbolRecords) >>>>>>>>>>>> >>>>>>>>>>>> 3) Merge in the new section contributions and section map. See >>>>>>>>>>>> LLD again for how to modify these. Hopefully the object file you exported >>>...

...>>>>>>>>>>>>>>>>>>>>>>>> you can probably borrow a similar algorithm with some slight modifications >>>>>>>>>>>>>>>>>>>>>>>> (lldb/COFF/PDB.cpp, search for mergeSymbolRecords) >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> 3) Merge in the new section contributions and >>>>>>>>>>>>>>&g...

...>>>>>>>>>>>>>>>>>>>>>> you can probably borrow a similar algorithm with some slight modifications >>>>>>>>>>>>>>>>>>>>>>>>>> (lldb/COFF/PDB.cpp, search for mergeSymbolRecords) >>>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>>>> 3) Merge in the new section contributions and >>>>>>>>>>&g...