search for: mergedglobals

On Fri, Feb 27, 2015 at 1:38 PM Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote: > On Thu, Feb 26, 2015 at 2:33 AM, Kristof Beyls <kristof.beyls at arm.com> > wrote: > > > > Hi Ahmed, > > > > Did you run these experiments on a platform with a linker that makes > > use of the AArch64CollectLOH-pass-produced information? > > As Jim says,

On Fri, Feb 27, 2015 at 1:42 PM, Eric Christopher <echristo at gmail.com> wrote: > > > On Fri, Feb 27, 2015 at 1:38 PM Ahmed Bougacha <ahmed.bougacha at gmail.com> > wrote: >> >> On Thu, Feb 26, 2015 at 2:33 AM, Kristof Beyls <kristof.beyls at arm.com> >> wrote: >> > >> > Hi Ahmed, >> > >> > Did you run these

On Thu, Feb 26, 2015 at 2:33 AM, Kristof Beyls <kristof.beyls at arm.com> wrote: > > Hi Ahmed, > > Did you run these experiments on a platform with a linker that makes > use of the AArch64CollectLOH-pass-produced information? As Jim says, I'm on iOS, so yes. However, I'm mostly running tests with the pass disabled. > > I'm guessing that the

Hi Ahmed, Did you run these experiments on a platform with a linker that makes use of the AArch64CollectLOH-pass-produced information? I'm guessing that the AArch64CollectLOH-pass information and a linker that makes use of that information could affect the profitability of the GlobalMerge pass? Thanks, Kristof > -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu

...For > > example, take test/CodeGen/ARM/global-merge-addrspace.ll > > > > ; RUN: llc < %s -mtriple=thumb-apple-darwin -O3 | FileCheck %s > > ; Test the GlobalMerge pass. Check that the pass does not crash when using > > ; multiple address spaces. > > ; CHECK: _MergedGlobals: > > @g1 = internal addrspace(1) global i32 1 > > @g2 = internal addrspace(1) global i32 2 > > ; CHECK: _MergedGlobals1: > > @g3 = internal addrspace(2) global i32 3 > > @g4 = internal addrspace(2) global i32 4 > > > > With my change, the symbol is named Me...

On Fri, Feb 27, 2015 at 2:13 PM Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote: > On Fri, Feb 27, 2015 at 1:42 PM, Eric Christopher <echristo at gmail.com> > wrote: > > > > > > On Fri, Feb 27, 2015 at 1:38 PM Ahmed Bougacha <ahmed.bougacha at gmail.com > > > > wrote: > >> > >> On Thu, Feb 26, 2015 at 2:33 AM, Kristof Beyls

...ll always be correct, but the tests as written do not pass. For example, take test/CodeGen/ARM/global-merge-addrspace.ll ; RUN: llc < %s -mtriple=thumb-apple-darwin -O3 | FileCheck %s ; Test the GlobalMerge pass. Check that the pass does not crash when using ; multiple address spaces. ; CHECK: _MergedGlobals: @g1 = internal addrspace(1) global i32 1 @g2 = internal addrspace(1) global i32 2 ; CHECK: _MergedGlobals1: @g3 = internal addrspace(2) global i32 3 @g4 = internal addrspace(2) global i32 4 With my change, the symbol is named MergedGlobals.1, hence it fails this test. I could change these 60 tes...