search for: menzynski

https://bugs.freedesktop.org/show_bug.cgi?id=111724 Bug ID: 111724 Summary: NVE6 (GK106) memory re-clocking breaks GpuTest plot3d benchmark Product: xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: not set

trello card: https://trello.com/c/admzDRvd/50-reduce-performance-refuse-to-boot-if-not-all-the-power-connectors-are-plugged Mark Menzynski (4): moved gpio so it is sorted by values gpio: checking if gpu power cable is connected gpio: added power check for another GPIO gpio: added power check for another GPIO drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 ++++- drm/nouveau/nvkm/subdev/gpio/base.c | 25 +++++++++++++...

Added config override for power checks. Mark Menzynski (4): bios/gpio: sort gpios by values gpio: fail if gpu external power is missing gpio: check the gpio function 16 in the power check as well gpio: check function 76 in the power check as well drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 +++- drm/nouveau/nvkm/subdev/gpio/base.c...

Trello: https://trello.com/c/admzDRvd/50-reduce-performance-refuse-to-boot-if-not-all-the-power-connectors-are-plugged Fixed commit messages. Mark Menzynski (4): bios/gpio: sort gpios by values gpio: fail if gpu external power is missing gpio: check the gpio function 16 in the power check as well gpio: check function 76 in the power check as well drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 ++++- drm/nouveau/nvkm/subdev/gpio/base.c...

Please add a config override to skip this, since we'll invariably get it wrong for some setup, and should be able to provide users with workarounds while the issue is being worked out. On Mon, Jul 15, 2019 at 5:43 AM Mark Menzynski <mmenzyns at redhat.com> wrote: > > Currently, nouveau doesn't check if GPU is missing power. This > patch makes nouveau fail when this happens on latest GPUs. > > It checks GPIO function 121 (External Power Emergency), which > should detect power problems on GPU initial...

...ies, thus users not being able to set higher clocks. When changing this value Nvidia driver still appeared to ignore it, and I wasn't able to find out why, thus the code is ignoring the value if it is zero. CC: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/nvkm/subdev/bios/volt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drm/nouveau/nvkm/subdev/bios/volt.c b/drm/nouveau/nvkm/subdev/bios/volt.c index 7143ea46..33a9fb5a 100644 --- a/drm/nouveau/nvkm/subdev/bios/volt.c +++ b/drm/nouveau/nvkm/su...

...n't know what it's really for. Actual bit setting this BYPASS_PLL_CHECK is on 0x10: lookup -ac0 0x137000 0x10 PCLOCK.CLK0_CTRL => { BYPASS_PLL_CHECK | UNK12 = 0 } Also, disabling this bit on other CLKs doesn't seem to break anything. v2: Add back PLL lock test Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/nvkm/subdev/clk/gf100.c | 1 - drm/nouveau/nvkm/subdev/clk/gk104.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/gf100.c b/drm/nouveau/nvkm/subdev/clk/gf100.c index 7f67f9f5..fe56817b 100644 --- a/drm/nouveau/nvkm/su...

From: Mark Menzynski <mmenzyns at redhat.com> [ Upstream commit a1af2afbd244089560794c260b2d4326a86e39b6 ] Some, mostly Fermi, vbioses appear to have zero max voltage. That causes Nouveau to not parse voltage entries, thus users not being able to set higher clocks. When changing this value Nvidia driver still...

From: Mark Menzynski <mmenzyns at redhat.com> [ Upstream commit a1af2afbd244089560794c260b2d4326a86e39b6 ] Some, mostly Fermi, vbioses appear to have zero max voltage. That causes Nouveau to not parse voltage entries, thus users not being able to set higher clocks. When changing this value Nvidia driver still...

From: Mark Menzynski <mmenzyns at redhat.com> [ Upstream commit a1af2afbd244089560794c260b2d4326a86e39b6 ] Some, mostly Fermi, vbioses appear to have zero max voltage. That causes Nouveau to not parse voltage entries, thus users not being able to set higher clocks. When changing this value Nvidia driver still...

From: Mark Menzynski <mmenzyns at redhat.com> [ Upstream commit a1af2afbd244089560794c260b2d4326a86e39b6 ] Some, mostly Fermi, vbioses appear to have zero max voltage. That causes Nouveau to not parse voltage entries, thus users not being able to set higher clocks. When changing this value Nvidia driver still...

...ering if perhaps we shouldn't limit this to a warning (which people tend to report) for a while first too. Also, what's NV's behaviour here? Do they refuse to load, or do they do something like force the GPU into its lowest pstate? Ben. > > On Mon, Jul 15, 2019 at 5:43 AM Mark Menzynski <mmenzyns at redhat.com> wrote: > > > > Currently, nouveau doesn't check if GPU is missing power. This > > patch makes nouveau fail when this happens on latest GPUs. > > > > It checks GPIO function 121 (External Power Emergency), which > > should detect...

...ting this BYPASS_PLL_CHECK is on 0x10: lookup -ac0 0x137000 0x10 PCLOCK.CLK0_CTRL => { BYPASS_PLL_CHECK | UNK12 = 0 } Also, disabling this bit on other CLKs doesn't seem to break anything. v2: add back PLL lock test v3: add restoring original value after PLL lock test Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/nvkm/subdev/clk/gf100.c | 7 +++++-- drm/nouveau/nvkm/subdev/clk/gk104.c | 5 ++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/gf100.c b/drm/nouveau/nvkm/subdev/clk/gf100.c index 7f67f9f5..a97af0e9 10064...

Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h index b71a3555..2f40935f 100644 --- a/drm/nouveau/include/nvk...

Tested on TU104, GP106 and GF100 Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c | 23 +++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h i...

this one is mainly used on Rankine and Curie and rarely on Tesla GPUs untested, wrote according to documentation Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h index a70ec9e8..fc2b5fb0...

Currently, nouveau doesn't check if GPU is missing power. This patch makes nouveau fail when this happens on latest GPUs. It checks GPIO function 121 (External Power Emergency), which should detect power problems on GPU initialization. Tested on TU104, GP106 and GF100. Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c | 23 +++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h i...

...on't know what it's really for. Actual bit setting this BYPASS_PLL_CHECK is on 0x10: lookup -ac0 0x137000 0x10 PCLOCK.CLK0_CTRL => { BYPASS_PLL_CHECK | UNK12 = 0 } Also, disabling this bit on other CLKs doesn't seem to break anything. Tested with GF119 NVS 310. Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/nvkm/subdev/clk/gf100.c | 8 -------- drm/nouveau/nvkm/subdev/clk/gk104.c | 8 -------- 2 files changed, 16 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/gf100.c b/drm/nouveau/nvkm/subdev/clk/gf100.c index 7f67f9f5..7ba2a000 100644 --- a/drm/...

...0x10: lookup -ac0 0x137000 0x10 PCLOCK.CLK0_CTRL => { BYPASS_PLL_CHECK | UNK12 = 0 } Also, disabling this bit on other CLKs doesn't seem to break anything. v2: add back PLL lock test v3: add restoring original value after PLL lock test v4: read the bit with nvkm_mask Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/nvkm/subdev/clk/gf100.c | 8 +++++--- drm/nouveau/nvkm/subdev/clk/gk104.c | 6 ++++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/gf100.c b/drm/nouveau/nvkm/subdev/clk/gf100.c index 7f67f9f5..510ab8ce 100...