Displaying 3 results from an estimated 3 matches for "memsetf".
Did you mean:
memset
2009 Sep 07
2
[LLVMdev] PR4882
Hello,
This patch fixes bug 4882.
Regards
-Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr4882.patch
Type: application/octet-stream
Size: 6856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090907/266f900c/attachment.obj>
2009 Sep 07
0
[LLVMdev] PR4882
Hi Jakub, looks good.
> + LLVMContext *Context = &SI->getContext();
I guess this could be
LLVMContext &Context = SI->getContext();
which means you can use Context rather than *Context below.
> - const Type *Ty = Type::getInt64Ty(SI->getContext());
> - MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset, &Ty, 1);
> + const Type *Tys[] = {Type::getInt64Ty(*Context)};
> + MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,
> + Tys, 1);
Why did you introduce Tys and not stick with T...
2009 Sep 07
1
[LLVMdev] PR4882
...t = &SI->getContext();
>
> I guess this could be
> LLVMContext &Context = SI->getContext();
> which means you can use Context rather than *Context below.
Right, C bad habit ;) Fixed.
>> - const Type *Ty = Type::getInt64Ty(SI->getContext());
>> - MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,
>> &Ty, 1);
>> + const Type *Tys[] = {Type::getInt64Ty(*Context)};
>> + MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,
>> + Tys, 1);
>
> Why did you in...