search for: memcpy_fromiovecend

...--git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index d695b16..dc78d87 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1079,7 +1079,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq) req_size, vq->iov[0].iov_len); break; } - ret = memcpy_fromiovecend(req, &vq->iov[0], 0, req_size); + ret = copy_from_user(req, vq->iov[0].iov_base, req_size); if (unlikely(ret)) { vq_err(vq, "Faulted on virtio_scsi_cmd_req\n"); break; diff --git a/include/linux/uio.h b/include/linux/uio.h index 02bd8a9..3e0cb4e 100644 --- a/include/...

...--git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index d695b16..dc78d87 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1079,7 +1079,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq) req_size, vq->iov[0].iov_len); break; } - ret = memcpy_fromiovecend(req, &vq->iov[0], 0, req_size); + ret = copy_from_user(req, vq->iov[0].iov_base, req_size); if (unlikely(ret)) { vq_err(vq, "Faulted on virtio_scsi_cmd_req\n"); break; diff --git a/include/linux/uio.h b/include/linux/uio.h index 02bd8a9..3e0cb4e 100644 --- a/include/...

Il 19/05/2014 21:07, Nicholas A. Bellinger ha scritto: > Hi MST, > > So I've finally got some cycles to get back to this code, and wanted to > verify the outstanding items you had previously raised: > > - Convert vhost-scsi to be independent of IOV layout using > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > operation..?) > - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. > - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of > iovecs. This is the only item really required, since the bytes field is what will be in...

Il 19/05/2014 21:07, Nicholas A. Bellinger ha scritto: > Hi MST, > > So I've finally got some cycles to get back to this code, and wanted to > verify the outstanding items you had previously raised: > > - Convert vhost-scsi to be independent of IOV layout using > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > operation..?) > - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. > - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of > iovecs. This is the only item really required, since the bytes field is what will be in...

...viewed for > > the next merge window. > > > > Hi MST, > > So I've finally got some cycles to get back to this code, and wanted to > verify the outstanding items you had previously raised: > > - Convert vhost-scsi to be independent of IOV layout using > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > operation..?) Ideally yes. > - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. > - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of > iovecs. > - Ensure virtio_scsi_cmd_req_pi is naturally aligned It tur...

...viewed for > > the next merge window. > > > > Hi MST, > > So I've finally got some cycles to get back to this code, and wanted to > verify the outstanding items you had previously raised: > > - Convert vhost-scsi to be independent of IOV layout using > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > operation..?) Ideally yes. > - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. > - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of > iovecs. > - Ensure virtio_scsi_cmd_req_pi is naturally aligned It tur...

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > >

...d(struct iov_iter *i, size_t count) size_t csum_and_copy_to_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); -int memcpy_fromiovec(unsigned char *kdata, struct iovec *iov, int len); int memcpy_fromiovecend(unsigned char *kdata, const struct iovec *iov, int offset, int len); int memcpy_toiovecend(const struct iovec *v, unsigned char *kdata, diff --git a/lib/iovec.c b/lib/iovec.c index 2d99cb4..4a90875 100644 --- a/lib/iovec.c +++ b/lib/iovec.c @@ -3,31 +3,6 @@ #include <linux/uio.h> /*...

...d(struct iov_iter *i, size_t count) size_t csum_and_copy_to_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); -int memcpy_fromiovec(unsigned char *kdata, struct iovec *iov, int len); int memcpy_fromiovecend(unsigned char *kdata, const struct iovec *iov, int offset, int len); int memcpy_toiovecend(const struct iovec *v, unsigned char *kdata, diff --git a/lib/iovec.c b/lib/iovec.c index 2d99cb4..4a90875 100644 --- a/lib/iovec.c +++ b/lib/iovec.c @@ -3,31 +3,6 @@ #include <linux/uio.h> /*...

...; vhost_discard_vq_desc(vq, headcount); break; diff --git a/include/linux/uio.h b/include/linux/uio.h index af3439f..02bd8a9 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -137,7 +137,4 @@ size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct io int memcpy_fromiovecend(unsigned char *kdata, const struct iovec *iov, int offset, int len); -int memcpy_toiovecend(const struct iovec *v, unsigned char *kdata, - int offset, int len); - #endif diff --git a/lib/iovec.c b/lib/iovec.c index 4a90875..d8f17a9 100644 --- a/lib/iovec.c +++ b/lib/iovec.c @@ -3,32 +3,...

...; vhost_discard_vq_desc(vq, headcount); break; diff --git a/include/linux/uio.h b/include/linux/uio.h index af3439f..02bd8a9 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -137,7 +137,4 @@ size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct io int memcpy_fromiovecend(unsigned char *kdata, const struct iovec *iov, int offset, int len); -int memcpy_toiovecend(const struct iovec *v, unsigned char *kdata, - int offset, int len); - #endif diff --git a/lib/iovec.c b/lib/iovec.c index 4a90875..d8f17a9 100644 --- a/lib/iovec.c +++ b/lib/iovec.c @@ -3,32 +3,...

...y need to get this moving to have the interface reviewed for > the next merge window. > Hi MST, So I've finally got some cycles to get back to this code, and wanted to verify the outstanding items you had previously raised: - Convert vhost-scsi to be independent of IOV layout using memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi operation..?) - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of iovecs. - Ensure virtio_scsi_cmd_req_pi is naturally aligned - Figure out why QEMU is not acking (any) vhost...

...gt; > > > > > > Hi MST, > > > > So I've finally got some cycles to get back to this code, and wanted to > > verify the outstanding items you had previously raised: > > > > - Convert vhost-scsi to be independent of IOV layout using > > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > > operation..?) > > Ideally yes. Er, so changing vhost-scsi to be independent of IOV layout will have the side effect of breaking existing non PI virtio-scsi logic..? > > > - Report VIRTIO_F_ANY_LAYOUT feature bit to users...

...); + if (unlikely(head < 0)) + break; + + if (unlikely(head == vq->num)) { + if (unlikely(vhost_enable_notify(&blk->dev, vq))) { + vhost_disable_notify(&blk->dev, vq); + continue; + } + break; + } + move_iovec(vq->iov, vq->hdr, sizeof(hdr), out); + ret = memcpy_fromiovecend((unsigned char *)&hdr, vq->hdr, 0, + sizeof(hdr)); + if (ret < 0) { + vq_err(vq, "Failed to get block header!\n"); + vhost_discard_vq_desc(vq, 1); + break; + } + + if (vhost_blk_req_handle(vq, &hdr, head, out, in, f) < 0) + break; + } +} + +static int vh...

...); + if (unlikely(head < 0)) + break; + + if (unlikely(head == vq->num)) { + if (unlikely(vhost_enable_notify(&blk->dev, vq))) { + vhost_disable_notify(&blk->dev, vq); + continue; + } + break; + } + move_iovec(vq->iov, vq->hdr, sizeof(hdr), out); + ret = memcpy_fromiovecend((unsigned char *)&hdr, vq->hdr, 0, + sizeof(hdr)); + if (ret < 0) { + vq_err(vq, "Failed to get block header!\n"); + vhost_discard_vq_desc(vq, 1); + break; + } + + if (vhost_blk_req_handle(vq, &hdr, head, out, in, f) < 0) + break; + } +} + +static int vh...

...); + if (unlikely(head < 0)) + break; + + if (unlikely(head == vq->num)) { + if (unlikely(vhost_enable_notify(&blk->dev, vq))) { + vhost_disable_notify(&blk->dev, vq); + continue; + } + break; + } + move_iovec(vq->iov, vq->hdr, sizeof(hdr), out); + ret = memcpy_fromiovecend((unsigned char *)&hdr, vq->hdr, 0, + sizeof(hdr)); + if (ret < 0) { + vq_err(vq, "Failed to get block header!\n"); + vhost_discard_vq_desc(vq, 1); + break; + } + + if (vhost_blk_req_handle(vq, &hdr, head, out, in, f) < 0) + break; + + if (!llist_empty(&...

...); + if (unlikely(head < 0)) + break; + + if (unlikely(head == vq->num)) { + if (unlikely(vhost_enable_notify(&blk->dev, vq))) { + vhost_disable_notify(&blk->dev, vq); + continue; + } + break; + } + move_iovec(vq->iov, vq->hdr, sizeof(hdr), out); + ret = memcpy_fromiovecend((unsigned char *)&hdr, vq->hdr, 0, + sizeof(hdr)); + if (ret < 0) { + vq_err(vq, "Failed to get block header!\n"); + vhost_discard_vq_desc(vq, 1); + break; + } + + if (vhost_blk_req_handle(vq, &hdr, head, out, in, f) < 0) + break; + + if (!llist_empty(&...

As multi-queue nics were commonly used for high-end servers, current single queue based tap can not satisfy the requirement of scaling guest network performance as the numbers of vcpus increase. So the following series implements multiple queue support in tun/tap. In order to take advantages of this, a multi-queue capable driver and qemu were also needed. I just rebase the latest version of

As multi-queue nics were commonly used for high-end servers, current single queue based tap can not satisfy the requirement of scaling guest network performance as the numbers of vcpus increase. So the following series implements multiple queue support in tun/tap. In order to take advantages of this, a multi-queue capable driver and qemu were also needed. I just rebase the latest version of