search for: mdnodekeyimpl

...endering - sorry] > > Hi list, > > Let's talk about adding a new type of debug info metadata. Here are the steps (at minimum - probably incomplete) one needs to take: > > 1. Create a new class in the hierarchy > 2. Implement two forms of `MD_NODE_GET` > 3. Specialize `MDNodeKeyImpl` > 4. Modify `LLParser.cpp` and add serialization code for your special type > 5. Modify `AsmWriter.cpp` and add serialization code for your special type > > I believe we can accomplish everything needed for debug info with just step 1 using a pattern found in Boost Serialization. Ima...

[Resending due to accidental markdown rendering - sorry] Hi list, Let's talk about adding a new type of debug info metadata. Here are the steps (at minimum - probably incomplete) one needs to take: 1. Create a new class in the hierarchy 2. Implement two forms of `MD_NODE_GET` 3. Specialize `MDNodeKeyImpl` 4. Modify `LLParser.cpp` and add serialization code for your special type5. Modify `AsmWriter.cpp` and add serialization code for your special type I believe we can accomplish everything needed for debug info with just step 1 using a pattern found in Boost Serialization. Imagine a new API ba...

...dering - sorry] > > Hi list, > > Let's talk about adding a new type of debug info metadata. Here are the > steps (at minimum - probably incomplete) one needs to take: > > 1. Create a new class in the hierarchy > 2. Implement two forms of `MD_NODE_GET` > 3. Specialize `MDNodeKeyImpl` > 4. Modify `LLParser.cpp` and add serialization code for your special type > 5. Modify `AsmWriter.cpp` and add serialization code for your special type > > I believe we can accomplish everything needed for debug info with just > step 1 using a pattern found in Boost Serialization....

...> Hi list, >> >> Let's talk about adding a new type of debug info metadata. Here are the steps (at minimum - probably incomplete) one needs to take: >> >> 1. Create a new class in the hierarchy >> 2. Implement two forms of `MD_NODE_GET` >> 3. Specialize `MDNodeKeyImpl` >> 4. Modify `LLParser.cpp` and add serialization code for your special type >> 5. Modify `AsmWriter.cpp` and add serialization code for your special type >> >> I believe we can accomplish everything needed for debug info with just step 1 using a pattern found in Boost Se...

...a to me. In addition to the cost of adding new nodes, having less repetitive manually-written existing code reduces the chances for bugs and increases readability. There are some irregularities in the existing code that I'm aware of that would need to be still handled separately: >> - The MDNodeKeyImpl currently is manually tuned to only hash members that are likely to differ. >> - The deserialization code also supports various older serialization formats. > > These are the two corner cases I was thinking of. I had these ones in mind as well and my experience using the template visi...

Hi list, Let’s talk about adding a new type of debug info metadata. Here are the steps (at minimum - probably incomplete) one needs to take: 1. Create a new class in the hierarchy 2. Implement two forms of MD_NODE_GET 3. Specialize MDNodeKeyImpl 4. Modify LLParser.cpp and add serialization code for your special type 5. Modify AsmWriter.cpp and add serialization code for your special typeI believe we can accomplish everything needed for debug info with just step 1 using a pattern found in Boost Serialization. Imagine a new API based o...

...me. In addition to the cost of adding new nodes, having less repetitive manually-written existing code reduces the chances for bugs and increases readability. There are some irregularities in the existing code that I'm aware of that would need to be still handled separately: >>> - The MDNodeKeyImpl currently is manually tuned to only hash members that are likely to differ. >>> - The deserialization code also supports various older serialization formats. >> >> These are the two corner cases I was thinking of. > > I had these ones in mind as well and my experience u...