search for: mdil

Should tablegen detect this as an error, or is it documented as a limitation somewhere that we've missed? In the tablegen-generated file AMDILGenIntrinsics.inc, we have a bunch of if statements comparing strings, many of which are dead, preventing correct recognition of some intrinsics in the their text form. I'm not quite sure what GET_FUNCTION_RECOGNIZER is used for, but if it's used, it's broken… ;-) Here's a small...

If the source being scanned has "llvm.AMDIL.barrier.global, it will match the first barrier test and return AMDIL_barrier, not AMDIL_barrier_global. On Nov 29, 2012, at 7:19 PM, Chris Lattner <clattner at apple.com> wrote: > Out of curiosity, what is wrong about that? It looks ok to me. > > -Chris > > On Nov 29, 2...

...out that? It looks ok to me. -Chris On Nov 29, 2012, at 6:52 PM, "Relph, Richard" <Richard.Relph at amd.com> wrote: > Should tablegen detect this as an error, or is it documented as a limitation somewhere that we've missed? > > In the tablegen-generated file AMDILGenIntrinsics.inc, we have a bunch of if statements comparing strings, many of which are dead, preventing correct recognition of some intrinsics in the their text form. I'm not quite sure what GET_FUNCTION_RECOGNIZER is used for, but if it's used, it's broken… ;-) > > Here'...

...itely sounds like a bug, no intrinsically in mainline are a > prefix if another one, or we are getting lucky. > > -Chris > > On Nov 29, 2012, at 7:24 PM, "Relph, Richard" <Richard.Relph at amd.com> > wrote: > > > If the source being scanned has "llvm.AMDIL.barrier.global, it will > match the first barrier test and return AMDIL_barrier, not > AMDIL_barrier_global. > > > > > > On Nov 29, 2012, at 7:19 PM, Chris Lattner <clattner at apple.com> > > wrote: > > > >> Out of curiosity, what is wrong about th...

Yes that definitely sounds like a bug, no intrinsically in mainline are a prefix if another one, or we are getting lucky. -Chris On Nov 29, 2012, at 7:24 PM, "Relph, Richard" <Richard.Relph at amd.com> wrote: > If the source being scanned has "llvm.AMDIL.barrier.global, it will match the first barrier test and return AMDIL_barrier, not AMDIL_barrier_global. > > > On Nov 29, 2012, at 7:19 PM, Chris Lattner <clattner at apple.com> > wrote: > >> Out of curiosity, what is wrong about that? It looks ok to me. >> &gt...