search for: mcwin32coff

...ate and send the most recent version? I'd like to get this cleaned up applied even if it isn't functionally perfect yet. Thanks! A general comment: for many of these, I only list one instance of a particular issue. +++ lib/MC/WinCOFF.h (working copy) @@ -0,0 +1,327 @@ +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- C++ -*-===// Please fix the filename in the comment line. +#include <llvm/MC/MCObjectWriter.h> +#include <llvm/ADT/SmallString.h> +#include <llvm/ADT/SmallVector.h> Please use "" style includes for llvm headers. +namespace co...

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

...this cleaned up applied even if it isn't > functionally perfect yet. > > Thanks! > > > A general comment: for many of these, I only list one instance of a > particular issue. > > > +++ lib/MC/WinCOFF.h (working copy) > @@ -0,0 +1,327 @@ > +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- > C++ -*-===// > > Please fix the filename in the comment line. > > +#include <llvm/MC/MCObjectWriter.h> > +#include <llvm/ADT/SmallString.h> > +#include <llvm/ADT/SmallVector.h> > > Please use "" style...

...functionally >> perfect yet. >> >> Thanks! >> >> >> A general comment: for many of these, I only list one instance of a >> particular issue. >> >> >> +++ lib/MC/WinCOFF.h (working copy) >> @@ -0,0 +1,327 @@ >> +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- C++ >> -*-===// >> >> Please fix the filename in the comment line. >> >> +#include <llvm/MC/MCObjectWriter.h> >> +#include <llvm/ADT/SmallString.h> >> +#include <llvm/ADT/SmallVector.h> >> >...