Displaying 2 results from an estimated 2 matches for "mayloadorstor".
Did you mean:
mayloadorstore
2020 Sep 10
2
Change prototype for TargetInstrInfo::foldMemoryOperandImpl
...MI);
}
The MI is ARM::tBL, and it doesn't have mayLoad set, which hits the
assert in MachineVerifier, since it still has memory operands attached
by foldMemoryOperand.
I have attached patch (changes to foldMemoryOperand), that checks if
the MI returned by foldMemoryOperandImpl has mayLoad or mayLoadOrStore
property set, and then proceed with adding memory operands, which
seems to resolve the issue.
Testing with make check-llvm with enable expensive checks doesn't show
unexpected failures.
Do the changes to foldMemoryOperand look OK ?
Thanks,
Prathamesh
On Wed, 9 Sep 2020 at 22:30, Quentin Colo...
2020 Sep 07
2
Change prototype for TargetInstrInfo::foldMemoryOperandImpl
Hi,
While working on https://reviews.llvm.org/D79785, we wanted to define
foldMemoryOperandImpl hook for Thumb1, that folds load, indirect call
to direct call tLDRpci, tBLX -> tBL. This triggered an assertion
error with expensive checks turned on in MachineVerifier because the
newly created tBL insn by
Thumb1InstrInfo::foldMemoryOperandImpl had memory operands of LoadMI
attached by