Displaying 7 results from an estimated 7 matches for "max_qlp_coeff_precision".
2015 Apr 18
2
"keep qlp coeff precision such that only 32-bit math is required"
stream_encoder.c has the following code:
/* try to keep qlp coeff precision such that only 32-bit math is required for decode of <=16bps streams */
if(subframe_bps <= 16) {
...
But FLAC can convert 16-bit input to 17-bit if mid-side coding is used.
So, does it make sense to compare subframe_bps with 17?
(The patch is attached. What do you think about it?)
-------------- next part
2014 Jul 28
1
Duplicate QLP coefficient restricting code
...tream_encoder
> if(encoder->protected_->do_qlp_coeff_prec_search) {
> min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION;
> /* try to ensure a 32-bit datapath throughout for
> 16bps(+1bps for side channel) or less */
> if(subframe_bps <= 17) {
> max_qlp_coeff_precision = flac_min(32 - subframe_bps -
> lpc_order, FLAC__MAX_QLP_COEFF_PRECISION);
> max_qlp_coeff_precision =
> flac_max(max_qlp_coeff_precision, min_qlp_coeff_precision);
> }
> else
> max_qlp_coeff_precision = FLAC__MAX_QLP_COEFF_PRECISION;
> }
> else {...
2014 Jul 28
0
[PATCH] Fix bug when using -p switch during compression
...me_(
}
if(encoder->protected_->do_qlp_coeff_prec_search) {
min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION;
- /* try to ensure a 32-bit datapath throughout for 16bps(+1bps for side channel) or less */
- if(subframe_bps <= 17) {
- max_qlp_coeff_precision = flac_min(32 - subframe_bps - lpc_order, FLAC__MAX_QLP_COEFF_PRECISION);
+ /* try to keep qlp coeff precision such that only 32-bit math is required for decode of <=16bps streams */
+ if(subframe_bps <= 16) {
+ max_qlp_coeff_precision = flac_min(32 - subframe_bps - F...
2015 Apr 18
2
"keep qlp coeff precision such that only 32-bit math is required"
...the history of the code, but flac 1.2.1 stream_encoder.c has
>
> min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION;
> /* try to ensure a 32-bit datapath throughout for 16bps(+1bps for side channel) or less */
> if(subframe_bps <= 17) {
> max_qlp_coeff_precision = min(32 - subframe_bps - lpc_order, FLAC__MAX_QLP_COEFF_PRECISION);
> max_qlp_coeff_precision = max(max_qlp_coeff_precision, min_qlp_coeff_precision);
> }
>
> in process_subframe_(), whereas evaluate_lpc_subframe_() has the comments that you refer to.
>
> I...
2012 Apr 05
2
[PATCH 2/2] V2: Use a single definition of MIN and MAX in sources
...);
/*
* Setup the frame
@@ -3332,8 +3323,8 @@ FLAC__bool process_subframe_(
min_qlp_coeff_precision = FLAC__MIN_QLP_COEFF_PRECISION;
/* try to ensure a 32-bit datapath throughout for 16bps(+1bps for side channel) or less */
if(subframe_bps <= 17) {
- max_qlp_coeff_precision = min(32 - subframe_bps - lpc_order, FLAC__MAX_QLP_COEFF_PRECISION);
- max_qlp_coeff_precision = max(max_qlp_coeff_precision, min_qlp_coeff_precision);
+ max_qlp_coeff_precision = flac_min(32 - subframe_bps - lpc_order, FLAC__MAX_QLP_COEFF_PRECISION);
+ max_qlp_coeff_prec...
2015 Apr 20
2
"keep qlp coeff precision such that only 32-bit math is required"
Martijn van Beurden wrote:
> Or maybe the question is: why is this code in evaluate_lpc_subframe anyway,
> i.e, why is this code duplicated? If process_subframe_ sets the
> qlp_precision for evaluate_lpc_subframe, why should the latter ignore that?
>
> We can only speculate about this, but I think this code has been duplicated
> by accident, and therefore it wasn't changed
2015 Apr 22
2
"keep qlp coeff precision such that only 32-bit math is required"
...he
> qlp_coeff_precision value is limited in the loop but MAX is not
> limited, the loop does the exact same thing multiple times: a
> waste of time. Therefore, only the MAX should be limited.
>
> I don't think the logic is needed directly after
>> min_qlp_coeff_precision = max_qlp_coeff_precision = encoder->protected_->qlp_coeff_precision;
> because that value is either chosen by the encoder (it is a
> lookup value, and is always small enough not to trigger this,
> set in stream_encoder.c around line 700) or it is set through
> the encoder, in which case it should probably...