search for: max_framesize

sorry about the delay... first, yes you are calling it correctly. if your encoded files have max_framesize == 0, then that should mean that either 1) you were using the command-line flac to encode to stdout; or 2) you are using libFLAC directly. if 2, you can replicate the functionality that is in src/flac/encode.c:metadata_callback() to write back statistics and seek table to the metadata in the flac...

Hi, I checked the archives, but I didn't find anything regarding this problem. FLAC__file_decoder_seek_absolute takes an incredibly long time to seek. What can I do about this? How do I fix it? Here's how I'm calling the function: if (argc > 2) { secs = atoi(argv[2]); seek_point = (FLAC__uint64) secs * sample_rate; printf("seeking to %d:%02d\n", secs/60,

On Fri, Jan 25, 2002 at 07:22:05PM -0800, Josh Coalson wrote: > sorry about the delay... first, yes you are calling it > correctly. if your encoded files have max_framesize == 0, > then that should mean that either 1) you were using the > command-line flac to encode to stdout; or 2) you are using > libFLAC directly. if 2, you can replicate the functionality > that is in src/flac/encode.c:metadata_callback() to write > back statistics and seek table to...

...00000000 +0200 +++ src/libFLAC/seekable_stream_decoder.c 2003-07-10 14:52:05.000000000 +0200 @@ -826,8 +826,8 @@ const unsigned min_blocksize = decoder->private_->stream_info.min_blocksize; const unsigned max_blocksize = decoder->private_->stream_info.max_blocksize; const unsigned max_framesize = decoder->private_->stream_info.max_framesize; - const unsigned channels = FLAC__seekable_stream_decoder_get_channels(decoder); - const unsigned bps = FLAC__seekable_stream_decoder_get_bits_per_sample(decoder); + const unsigned channels = decoder->private_->stream_info.channels; + cons...

...======================================= RCS file: /cvsroot/flac/flac/src/libFLAC/stream_decoder.c,v retrieving revision 1.119 diff -u -r1.119 stream_decoder.c --- stream_decoder.c 6 Nov 2006 16:48:33 -0000 1.119 +++ stream_decoder.c 7 Nov 2006 09:13:30 -0000 @@ -2935,10 +2935,16 @@ const unsigned max_framesize = decoder->private_->stream_info.data.stream_info.max_framesize; const unsigned min_framesize = decoder->private_->stream_info.data.stream_info.min_framesize; /* take these from the current frame in case they've changed mid-stream */ - const unsigned channels = FLAC__stream_deco...

..._info.total_samples; const unsigned min_blocksize = decoder->private_->stream_info.min_blocksize; @@ -862,12 +862,14 @@ * the first and last frames. */ lower_bound = first_frame_offset; + lower_bound_sample = 0; /* calc the upper_bound, beyond which we never want to seek */ if(max_framesize > 0) upper_bound = stream_length - (max_framesize + 128 + 2); /* 128 for a possible ID3V1 tag, 2 for indexing differences */ else upper_bound = stream_length - ((channels * bps * FLAC__MAX_BLOCK_SIZE) / 8 + 128 + 2); + upper_bound_sample = total_samples; /* * Now we refine the bou...

...FLAC__uint64 total_samples = FLAC__stream_decoder_get_total_samples(decoder); const unsigned min_blocksize = decoder->private_->stream_info.data.stream_info.min_blocksize; const unsigned max_blocksize = decoder->private_->stream_info.data.stream_info.max_blocksize; const unsigned max_framesize = decoder->private_->stream_info.data.stream_info.max_framesize; - const unsigned channels = FLAC__stream_decoder_get_channels(decoder); - const unsigned bps = FLAC__stream_decoder_get_bits_per_sample(decoder); + const unsigned channels = decoder->private_->stream_info.data.stream_info....

ok, tried it out... passes test/test_seeking.sh and my "xmms twitch" test, checked in to CVS. thanks! Josh --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > On Fri, Nov 03, 2006 at 10:01:42AM +0100, Miroslav Lichvar wrote: > > Thanks. Sending latest version of the patch. Now it can seek in > files > > that have large id3 tag (or any random data) at

...FLAC__uint64 total_samples = FLAC__stream_decoder_get_total_samples(decoder); const unsigned min_blocksize = decoder->private_->stream_info.data.stream_info.min_blocksize; const unsigned max_blocksize = decoder->private_->stream_info.data.stream_info.max_blocksize; const unsigned max_framesize = decoder->private_->stream_info.data.stream_info.max_framesize; - const unsigned channels = FLAC__stream_decoder_get_channels(decoder); - const unsigned bps = FLAC__stream_decoder_get_bits_per_sample(decoder); + const unsigned min_framesize = decoder->private_->stream_info.data.stream_...

I think I figured out where the problem is. In my metadata_callback, I added a thing to print out the max_framesize and max_framesize from the stream_info block. Those are both zero. The ..._seek_absolute() function of the SeekableStreamDecoder uses the max_framesize to guess at where to seek. It doesn't seem to handle the case when max_frame_size is zero very well. I'm looking at seekable_stream...

...les, FLAC FLAC__bitwriter_clear(encoder->private_->frame); if(samples > 0) { - encoder->private_->streaminfo.data.stream_info.min_framesize = min(bytes, encoder->private_->streaminfo.data.stream_info.min_framesize); - encoder->private_->streaminfo.data.stream_info.max_framesize = max(bytes, encoder->private_->streaminfo.data.stream_info.max_framesize); + encoder->private_->streaminfo.data.stream_info.min_framesize = flac_min(bytes, encoder->private_->streaminfo.data.stream_info.min_framesize); + encoder->private_->streaminfo.data.stream_info.max_...

..._info.total_samples; const unsigned min_blocksize = decoder->private_->stream_info.min_blocksize; @@ -903,12 +903,14 @@ * the first and last frames. */ lower_bound = first_frame_offset; + lower_bound_sample = 0; /* calc the upper_bound, beyond which we never want to seek */ if(max_framesize > 0) upper_bound = stream_length - (max_framesize + 128 + 2); /* 128 for a possible ID3V1 tag, 2 for indexing differences */ else upper_bound = stream_length - ((channels * bps * FLAC__MAX_BLOCK_SIZE) / 8 + 128 + 2); + upper_bound_sample = total_samples > 0 ? total_samples : target_sa...

Ok, here is a patch waiting for new CVS :). It works fine for me, but please check it before commiting... -- Miroslav Lichvar -------------- next part -------------- --- src/libFLAC/bitbuffer.c.orig 2003-01-30 17:36:01.000000000 +0100 +++ src/libFLAC/bitbuffer.c 2003-01-30 21:53:18.000000000 +0100 @@ -51,6 +51,25 @@ */ static const unsigned FLAC__BITBUFFER_DEFAULT_CAPACITY = ((65536 - 64) *